Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] m68k: Revive _TIF_* masks
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
References: <20200826122923.22821-1-geert@linux-m68k.org>
From:   Greg Ungerer <gerg@linux-m68k.org>
Message-ID: <aae200e7-2618-b17a-3e88-ee349a75c74d@linux-m68k.org>
Date:   Thu, 27 Aug 2020 10:14:42 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200826122923.22821-1-geert@linux-m68k.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Geert,

On 26/8/20 10:29 pm, Geert Uytterhoeven wrote:
> While the core m68k code does not use the _TIF_* masks anymore, there
> exists generic code that relies on their presence.  Fortunately none of
> that code is used on m68k, currently.
> 
> Re-add the various _TIF_* masks, which were removed in commit
> cddafa3500fde4a0 ("m68k/m68knommu: merge MMU and non-MMU
> thread_info.h"), to avoid future nasty surprises.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Regards
Greg


>   arch/m68k/include/asm/thread_info.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/m68k/include/asm/thread_info.h b/arch/m68k/include/asm/thread_info.h
> index 015f1ca383053a39..3689c6718c883d23 100644
> --- a/arch/m68k/include/asm/thread_info.h
> +++ b/arch/m68k/include/asm/thread_info.h
> @@ -68,4 +68,12 @@ static inline struct thread_info *current_thread_info(void)
>   #define TIF_MEMDIE		16	/* is terminating due to OOM killer */
>   #define TIF_RESTORE_SIGMASK	18	/* restore signal mask in do_signal */
>   
> +#define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
> +#define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
> +#define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
> +#define _TIF_DELAYED_TRACE	(1 << TIF_DELAYED_TRACE)
> +#define _TIF_SYSCALL_TRACE	(1 << TIF_SYSCALL_TRACE)
> +#define _TIF_MEMDIE		(1 << TIF_MEMDIE)
> +#define _TIF_RESTORE_SIGMASK	(1 << TIF_RESTORE_SIGMASK)
> +
>   #endif	/* _ASM_M68K_THREAD_INFO_H */
>