Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200826201420.3414123-1-ndesaulniers@google.com>
 <CANiq72no2qO3BBTU3MhVCp4mDLqzMg7NhWGObHV3wtFCRjaziw@mail.gmail.com> <20200826212648.GA1005132@ubuntu-n2-xlarge-x86>
In-Reply-To: <20200826212648.GA1005132@ubuntu-n2-xlarge-x86>
Reply-To: sedat.dilek@gmail.com
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Thu, 27 Aug 2020 09:19:08 +0200
Message-ID: <CA+icZUX_mR6E+tO+qR4xML78qBZe2Rs4Ck7BgerwtgGaGJ9hgA@mail.gmail.com>
Subject: Re: [PATCH] compiler-clang: add build check for clang 10.0.1
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Marco Elver <elver@google.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 26, 2020 at 11:26 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote:
> > On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> > >
> > > During Plumbers 2020, we voted to just support the latest release of
> > > Clang for now.  Add a compile time check for this.
> >
> > Since this effectively enforces a minimum version for Clang, I'd
> > also update `Documentation/process/changes.rst` and
> > `Documentation/admin-guide/README.rst` to mention this, and perhaps
> > use that as a commit title ("implement minimum version for Clang")
> > since that is the important change, not the implementation so much!
>
> I was actually going to comment on this separately but you beat me to it
> :) this patch probably should have been sent as a series with the
> Documentation update to avoid confusion for the reviewers:
>

Agreed... This patch should be combined with the other one and sent as
a patch-series.

- Sedat -

> https://lore.kernel.org/lkml/20200826191555.3350406-1-ndesaulniers@google.com/
>
> Cheers,
> Nathan
>
> > [Actually, I'd remove the particular GCC version from the
> > `admin-guide/README.rst` to avoid having the version in 2 places (that
> > doc already links to the other one), but that should be another
> > patch.]
> >
> > Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> >
> > Cheers,
> > Miguel