Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp248980pxa; Thu, 27 Aug 2020 00:47:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMpOpY4+tbJa4Zfebi8jTi1JbLaHHQiCb3hsV5BnFMysMtKaJL9aTT1odDnFV38M5VwZw8 X-Received: by 2002:a17:906:40c8:: with SMTP id a8mr19326142ejk.536.1598514424031; Thu, 27 Aug 2020 00:47:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598514424; cv=none; d=google.com; s=arc-20160816; b=Z4vJTZ05Cm0IoiUYEfN74pm6NsMxH+cQxiEfwqnUhvjMTN3OdLaHKTz7UTFkURGpfw 8OqFhGnbWILSxjsDJPnn658C0uOKdwysf5TJI5l6Xyk48jETkOfhFCde1dvEm08nx71F O0iXOztZuxebBRVuFoeIOPC0Y+9tPk3x5ft4fU8FxRe5QooalOripNtNM4wboPMv8pnD nVvpoTOZOsjVz7EAdkBm1fXqxru3zCbcCMMVIC95mShFdP+oodpw8i45gSjNuJFIAecp CJB+XAa3Y10IdUtYg4eDq3YxacOf+ZMOvA5/DLchGZTYPjrEpDPStvOhSxpHiRfk0T4M ZbNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=K28VLY1TatJnhcXgz0QkSDgDHU4uVNvQ66A4Yusz9EY=; b=SZEKYkBOkINXYM1Q7xkBCbsutlTrqfbiWAiLdpArRZEmI3h9asDwE4CIKZbovCOnA8 lVC6cUAadrTHtF40aJJbeZGPZIfolN8Hy/UV03TshPqHhk3kjMVAhX2oZbIahCAT6yay nB9uixEqqNZmnfR0wDLyjBTTebhmcWu/lHP8ApoUQVDm2UfcLoD8iZPLagmWbrK9Wlpd 3Or+HycycnTrjijGDOnTP9B9EJp8vWAE3KAHofby2Fd8iN4kdTOVTaTwTLOVUxzEIm0p YCY89y9S+ILoR79sMLsVSJoksMKr7L2ZeQmekvauCwamQri3eAS7jUrFqdYot/7FXfxh dpCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy23si983414edb.311.2020.08.27.00.46.40; Thu, 27 Aug 2020 00:47:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728126AbgH0Hn7 (ORCPT + 99 others); Thu, 27 Aug 2020 03:43:59 -0400 Received: from spam.zju.edu.cn ([61.164.42.155]:18616 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726851AbgH0Hn5 (ORCPT ); Thu, 27 Aug 2020 03:43:57 -0400 Received: from localhost.localdomain (unknown [210.32.144.184]) by mail-app2 (Coremail) with SMTP id by_KCgAH8J4tZEdfKIg7Ag--.5581S4; Thu, 27 Aug 2020 15:43:45 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: ref-verify: Fix memleak in add_extent_data_ref Date: Thu, 27 Aug 2020 15:43:39 +0800 Message-Id: <20200827074339.22950-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: by_KCgAH8J4tZEdfKIg7Ag--.5581S4 X-Coremail-Antispam: 1UD129KBjvdXoW7GF4UXr1kJry3Ar4rCF17KFg_yoWxCrX_Ka yfCr18Wr1UWw1UCw18Kan7JrZ5Awn5Kr1UXws2kF12kw42qFyFgFZ7Xrs8G3Z8GrW7GF9x GrZFvF13u347ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIkFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E 87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c 8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_ Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwI xGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r4xMxAIw28IcxkI7VAKI48J MxAIw28IcVCjz48v1sIEY20_GFWkJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_ Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x0JUBpB-UUUUU= X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAg0EBlZdtPrBDAAXsS Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When lookup_root_entry() fails, ref should be freed just like when insert_ref_entry() fails. Signed-off-by: Dinghao Liu --- fs/btrfs/ref-verify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/ref-verify.c b/fs/btrfs/ref-verify.c index 7f03dbe5b609..712f5cfde404 100644 --- a/fs/btrfs/ref-verify.c +++ b/fs/btrfs/ref-verify.c @@ -419,6 +419,7 @@ static int add_extent_data_ref(struct btrfs_fs_info *fs_info, if (!re) { spin_unlock(&fs_info->ref_verify_lock); btrfs_err(fs_info, "missing root in new block entry?"); + kfree(ref); return -EINVAL; } re->num_refs += num_refs; -- 2.17.1