Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp252566pxa; Thu, 27 Aug 2020 00:56:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzo5MhywBeSUUbWkI39pRU+Q+aNDqw73V/GUEFrjGFM+BB8GlHBt9WZ/+tMjQgIWtfodknv X-Received: by 2002:a05:6402:1696:: with SMTP id a22mr19093212edv.126.1598515011206; Thu, 27 Aug 2020 00:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598515011; cv=none; d=google.com; s=arc-20160816; b=POAXziNpLn0YGHtDL6kcxgat71F+QabYEhQkDzxNnBDyuhmTEMZYPtl2pMjGWzMROn MJT1m2g6L4DvKBmhuLev0/OVAo/NsbZzEJU6Pjaf9WrpIjeCxHAzxt9PMtdlhoae3LAb sbDMpJd5sdKGTDc4IM8UzRCiPzIu4sAXjMVMgqZazhMZuT6Ch+QEcgnKZac99DtQFW52 t3uYKROzghmGBqQ5LIoxPuDOC6Ry29z0abY5DXX4MB42znwB5+v/7myW7DrzhSeoZAH7 g9/jFIqHBluEas2KKq9+nfJiiQglB7N2+PXQ0b3tC9JF5a2AO4YPI1a2PpVG9KvGVaGl dFeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:reply-to:ironport-sdr :ironport-sdr; bh=imwl/n0KzrhyUQHdROfBX+mm5Xb0OuAmEHccgwLYBcY=; b=n5+VHbaGRKd9VQvWU9Gga936+rDbtcl8b35xR//snezWi49fQ1kgYuX6GMZSMaDacv +oQE2YX6wnConfeHVkl6IBkzikMOZAJ4wdL3lcYqsJG30y+cR5WYOAZ7WMGhM1VNEVIg rH+PNz8RMLZ7tesMSZu6nWpR3C0l/8OACVfLZy1LSxCOHR5wCtsRDwOW22q/7eeZOa3u VN3yGoDkdT7GI1tTi8C0hcRsJeLk4xZks0PZahhzdURVcdQVKVTknEpLmXl6WJIXkA+H 0zbXInLAIEmpPG4qRqSrkbcCmrRQq86dAuFyGqmP6SrQtRNjB0n0If3Ws/k+BAhFVl24 DmQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si1035206edy.540.2020.08.27.00.56.28; Thu, 27 Aug 2020 00:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgH0HyC (ORCPT + 99 others); Thu, 27 Aug 2020 03:54:02 -0400 Received: from mga06.intel.com ([134.134.136.31]:13056 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgH0HyC (ORCPT ); Thu, 27 Aug 2020 03:54:02 -0400 IronPort-SDR: vz4bzoQ2rOVep7gF8OnzVv2aaOcIS+Q9r3sY/Js14XZW9M1UBFwXOFDpCIQGWnAm9Y3E8/9QRd VxnZps+SMYiw== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="217988356" X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="217988356" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 00:54:01 -0700 IronPort-SDR: /BlwljAFZPlXT5EC9L5SRl7mceno88GYplxunrJ7L2uL1bUWgMSzIEaQL0RSsrVtsYVIhpPo00 ai3Jx3cDTxYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="295638978" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 27 Aug 2020 00:54:01 -0700 Received: from [10.249.76.175] (vramuthx-MOBL1.gar.corp.intel.com [10.249.76.175]) by linux.intel.com (Postfix) with ESMTP id D6A1A5806C6; Thu, 27 Aug 2020 00:53:57 -0700 (PDT) Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com Subject: Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability To: Chanwoo Choi , linux-kernel@vger.kernel.org Cc: vijaikumar.kanagarajan@gmail.com, krzk@kernel.org, myungjoo.ham@samsung.com, heikki.krogerus@linux.intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, yin1.li@intel.com References: <20200827065128.55094-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200827065128.55094-2-vadivel.muruganx.ramuthevar@linux.intel.com> From: "Ramuthevar, Vadivel MuruganX" Message-ID: <47fef2ec-012c-03c7-13ef-0882b4f7146b@linux.intel.com> Date: Thu, 27 Aug 2020 15:53:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 27/8/2020 3:56 pm, Chanwoo Choi wrote: > On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan >> >> Set the capability value of property for VBUS and POLARITY. >> >> Signed-off-by: Ramuthevar Vadivel Murugan >> --- >> drivers/extcon/extcon-ptn5150.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c >> index 841c9fe211f1..20d49a54c36e 100644 >> --- a/drivers/extcon/extcon-ptn5150.c >> +++ b/drivers/extcon/extcon-ptn5150.c >> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) >> return ret; >> } >> >> + extcon_set_property_capability(info->edev, EXTCON_USB, >> + EXTCON_PROP_USB_VBUS); >> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, >> + EXTCON_PROP_USB_VBUS); >> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, >> + EXTCON_PROP_USB_TYPEC_POLARITY); > > Above codes used the space for the indentation to keep the vertical line. > I think that we better to use tab for the indentation. > > If there are no objection, I'll fix and then apply it. Thank you!, no objection , please fix it. Regards Vadivel > >> + >> /* Initialize PTN5150 device and print vendor id and version id */ >> ret = ptn5150_init_dev_type(info); >> if (ret) >> > >