Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp271890pxa;
        Thu, 27 Aug 2020 01:39:31 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzkmT9IpmZtexFQaXOldyTItAD87WTlJfbe8yB1OixnaRU0+M6usniFqzhTt7V81uR8JTAo
X-Received: by 2002:aa7:da87:: with SMTP id q7mr18547652eds.166.1598517571262;
        Thu, 27 Aug 2020 01:39:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598517571; cv=none;
        d=google.com; s=arc-20160816;
        b=MjtFg/4RJFvL7rgL+c7QRGP0n2omew39K+T6x+8Ivt5cg158IGruio94f4kZCDw29Z
         zL6bm1viI8ShIYRuXSy8e05aub0ZDv+MDP1YjbLVV2kUYsLvkwbAHC5HOXpeh/Nk6/Fj
         OgPJIu3721hZC4cTsN0eujWsctl81D6jLCfGS2u3UHvi0m2Yb4DkmakvIxAwMWbxWcUu
         4M9AhEYsQopV+xQ83xvrui4TsAsEop6sj4lLQYhsY/PKhUmCb/HbrDiXhBF0Baq1C8mj
         1XF1DDpY/v9RQDdaecF+uxrpAr4BCebTejmqqzLLPi8rs0z2ztqJVRPtNuhq+PIp4N6w
         WQjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=o5+xPEQxoEEyAdnso83ls1nfUNx+yX31JYi8krguPtk=;
        b=JDY4G/cP8Vad+KmPwv2W7GI2C6gFgYThwcAkKSnbpQ+8bF8JB9GIB3xXWVo0NW/lsO
         VqpsuSSBxzD+TMS8IQo2ncD/kUrrzaBubyo3TnOZW92XgtXp/nU0cEXSGUvnYLKVmE69
         IYbtgvqXmPVtjEjL9YM2VRBq6iyT0pr58VoYJSc22PX3d8tX+DCEChB97I3NjaTsU2fs
         GXJ94h3smOq/rmr8Oveu+Z73+M4pJiP32m6tFtPE04M7yyYdKE7VFSiU40B++GsTdYNI
         2n8eeegRDfC/5Bpwkp+4fTtrMZkiuUV2YiY7UAOHOJZtPXUT/DcpucIJd5ECkMJ51wFF
         MSIg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=UK69VdUq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id di23si1040800edb.171.2020.08.27.01.39.07;
        Thu, 27 Aug 2020 01:39:31 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=UK69VdUq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728192AbgH0Ig1 (ORCPT <rfc822;daisukeokaopensource@gmail.com>
        + 99 others); Thu, 27 Aug 2020 04:36:27 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59084 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726826AbgH0Ig0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Aug 2020 04:36:26 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3495CC061264;
        Thu, 27 Aug 2020 01:36:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=o5+xPEQxoEEyAdnso83ls1nfUNx+yX31JYi8krguPtk=; b=UK69VdUqhTbBTdlbAAxYMJtxrl
        entONaNmGq3w0fuYxiC9Tjlpd+IhsF4BIQ0MiASfoj9j2ql78Jaqh1V3HwyO1hsMnFfJayIL9oPQS
        aAFZTzXMprC4RwQYFKBSzISZ0FzIZryxYKojdslclEqMr2gmc6PHD2bmbYhCRkCO1cvjOPGf5TKdw
        3rtdVl6HR8OJUQ34E2dmxOZm/i+KXH1mYQI7FMWH0Fc1wO224Y7IpYp6xIIbDjLcVQ8G+8425ygry
        ohbiO+F3qMGneAOLudfVIQ8QQknoVuXTH/wb4RXGKNvzZrzb0vO8iPbDz0iw5NBQY/bnevpbdOaJA
        2S3RuaWQ==;
Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kBDOS-0003qi-L9; Thu, 27 Aug 2020 08:36:24 +0000
Date:   Thu, 27 Aug 2020 09:36:24 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] iomap: Convert write_count to byte count
Message-ID: <20200827083624.GD11067@infradead.org>
References: <20200824145511.10500-1-willy@infradead.org>
 <20200824145511.10500-8-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200824145511.10500-8-willy@infradead.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 24, 2020 at 03:55:08PM +0100, Matthew Wilcox (Oracle) wrote:
> Instead of counting bio segments, count the number of bytes submitted.
> This insulates us from the block layer's definition of what a 'same page'
> is, which is not necessarily clear once THPs are involved.

Looks good (module the field naming as comment on the previous patch):

Reviewed-by: Christoph Hellwig <hch@lst.de>