Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] iio: stm32-dac: Replace indio_dev->mlock with own
 device lock
To:     Alexandru Ardelean <ardeleanalex@gmail.com>,
        Alexandru Ardelean <alexandru.ardelean@analog.com>
CC:     linux-iio <linux-iio@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        LKML <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Jonathan Cameron <jic23@kernel.org>, <alexandre.torgue@st.com>,
        Sergiu Cuciurean <sergiu.cuciurean@analog.com>
References: <20200826063850.47625-1-alexandru.ardelean@analog.com>
 <20200826120042.200364-1-alexandru.ardelean@analog.com>
 <CA+U=DsrMDSTQKEc2_3+W8u4bLraAowVB3nB4huKY--v8gnds2Q@mail.gmail.com>
From:   Fabrice Gasnier <fabrice.gasnier@st.com>
Message-ID: <c3a9411e-186d-a3ac-5ad0-bd70ad78f147@st.com>
Date:   Thu, 27 Aug 2020 11:03:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CA+U=DsrMDSTQKEc2_3+W8u4bLraAowVB3nB4huKY--v8gnds2Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/27/20 10:55 AM, Alexandru Ardelean wrote:
> On Wed, Aug 26, 2020 at 3:03 PM Alexandru Ardelean
> <alexandru.ardelean@analog.com> wrote:
>> From: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
>>
>> As part of the general cleanup of indio_dev->mlock, this change replaces
>> it with a local lock. The lock protects against potential races when
>> reading the CR reg and then updating, so that the state of pm_runtime
>> is consistent between the two operations.
>>
>> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>> ---
> Forgot the changelog here.
> Apologies.
> 
> Changelog v1 -> v2:
> * removed whitespace change for 'common' field
> * updated comment about the lock usage

Hi Alexandru,

Sorry if I missed it... is there an update on the comment :-) ?

Best Regards,
Fabrice
> 
>>  drivers/iio/dac/stm32-dac.c | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c
>> index 092c796fa3d9..7a8aed476850 100644
>> --- a/drivers/iio/dac/stm32-dac.c
>> +++ b/drivers/iio/dac/stm32-dac.c
>> @@ -26,9 +26,11 @@
>>  /**
>>   * struct stm32_dac - private data of DAC driver
>>   * @common:            reference to DAC common data
>> + * @lock:              lock to protect the data buffer during regmap ops
>>   */
>>  struct stm32_dac {
>>         struct stm32_dac_common *common;
>> +       struct mutex            lock;
>>  };