Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp289727pxa;
        Thu, 27 Aug 2020 02:19:22 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzOsZbc5ZKJ+gELLcntBu6/vklq9AF9fQxdXeh/P4DiEOZxvU7z+GLhUD5ZZ9hm1+Mfgfkg
X-Received: by 2002:a17:906:7f0b:: with SMTP id d11mr21428597ejr.116.1598519961755;
        Thu, 27 Aug 2020 02:19:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598519961; cv=none;
        d=google.com; s=arc-20160816;
        b=S3vYmwCKBbic5zZbAjK8ZiVtHPEqfL/DVP6mWJykPTxi8TB3/wA0nqSGglryJI4/RT
         FjdFvHwvya8om5dOquNk3I/SyjaxQVSF7w0F+kN7NKV6s7d19ZaJPsQFG4GH/jaJxqvn
         7Qmhk7lpqLAyeR5IVinxv11AUymo9hSSuisv6OrPZPVCoEDQmzs/2S7smtIHnG6vlSHO
         XbDnjYDonG5NSQlY8X/5CKOFa0PzAA7xNewcFNOnvV8BL/5ra0Ke1X19aTRO9+/t3G3H
         f4luWDxdrjmAzLiFnR0BARGRtPDE12fiWHAN/KGilupk0JEyHjzWwR3x57iYIYxcCqi9
         Kr7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=6+F90NR/FY53Xu6VvhUtNDnXcBQMlNBJAnTJEy7H35A=;
        b=c1wnrioj1PBV71twcXBvX2HxF9IY1CiWprxmipkk5XtMV/lYhJVo8uel9FEt1zMzW3
         0410RzwoYpMkjw0Rds3dt6KHl14Va4Cz3Jnv/BMyoNSZFz0nkZhTTCvgBTbMXkMqZGrQ
         7sZshY7kTTmReuDjxPcvXjCwdpQwLakJntoh//aC1dfx9AxIC00J6nXOPo55H3zV3xwz
         BZ77MlCjKj/rGIW26cvVKEgzgr90dNehpBTp4Ec/QbtqIfGLhFIQ/JubpbASngorZuXR
         pVkk6oq6GJxAHUywF3Vc0COJwhyIVjoIhjPy9S7TZ5QhDKkO2cgmMefWPCeFmHVm9+cb
         okmA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r21si1026539ejs.441.2020.08.27.02.18.59;
        Thu, 27 Aug 2020 02:19:21 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728413AbgH0JSK (ORCPT <rfc822;daisukeokaopensource@gmail.com>
        + 99 others); Thu, 27 Aug 2020 05:18:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37388 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726938AbgH0JSJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Aug 2020 05:18:09 -0400
Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25732C061264
        for <linux-kernel@vger.kernel.org>; Thu, 27 Aug 2020 02:18:09 -0700 (PDT)
Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5])
        by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
        (Exim 4.92)
        (envelope-from <mfe@pengutronix.de>)
        id 1kBE2Y-0004qN-Hf; Thu, 27 Aug 2020 11:17:50 +0200
Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89)
        (envelope-from <mfe@pengutronix.de>)
        id 1kBE2U-0007L7-JH; Thu, 27 Aug 2020 11:17:46 +0200
Date:   Thu, 27 Aug 2020 11:17:46 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Yu Kuai <yukuai3@huawei.com>
Cc:     timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
        festevam@gmail.com, shengjiu.wang@gmail.com, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        linux-imx@nxp.com, xobs@kosagi.com, alsa-devel@alsa-project.org,
        yi.zhang@huawei.com, linux-kernel@vger.kernel.org,
        yukuai@huawei.com, linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: fsl: imx-es8328: add missing put_device() call
 in imx_es8328_probe()
Message-ID: <20200827091746.xcbggzqqufndyuk7@pengutronix.de>
References: <20200825120531.1479304-1-yukuai3@huawei.com>
 <20200825120531.1479304-3-yukuai3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200825120531.1479304-3-yukuai3@huawei.com>
X-Sent-From: Pengutronix Hildesheim
X-URL:  http://www.pengutronix.de/
X-IRC:  #ptxdist @freenode
X-Accept-Language: de,en
X-Accept-Content-Type: text/plain
X-Uptime: 11:08:08 up 286 days, 26 min, 272 users,  load average: 0.04, 0.12,
 0.08
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5
X-SA-Exim-Mail-From: mfe@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-08-25 20:05, Yu Kuai wrote:
> if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have
> a corresponding put_device().

Why do we need the ssi_pdev reference here at all?

Regards,
  Marco