Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] memory: omap-gpmc: Fix build error without CONFIG_OF
To:     YueHaibing <yuehaibing@huawei.com>, <tony@atomide.com>,
        <krzk@kernel.org>, <ladis@linux-mips.org>, <bbrezillon@kernel.org>,
        <peter.ujfalusi@ti.com>
CC:     <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200818125338.58148-1-yuehaibing@huawei.com>
 <20200826125919.22172-1-yuehaibing@huawei.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <c4d64ed6-2bd6-9b6e-63e1-59eb50157b87@ti.com>
Date:   Thu, 27 Aug 2020 12:27:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200826125919.22172-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 26/08/2020 15:59, YueHaibing wrote:
> If CONFIG_OF is n, gcc fails:
> 
> drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
> omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'
> 
> Add gpmc_read_settings_dt() helper function to fix this.
> 
> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: add gpmc_read_settings_dt() stub
> ---
>   drivers/memory/omap-gpmc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index cd9e80748591..02c0c694ecaf 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2310,6 +2310,9 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
>   	}
>   }
>   #else
> +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
> +{

I will suggest to set gpmc_settings data structure to zero here so that
the caller doesn't proceed with random/invalid settings.

> +}
>   static int gpmc_probe_dt(struct platform_device *pdev)
>   {
>   	return 0;
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki