Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp330862pxa; Thu, 27 Aug 2020 03:41:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzS7dla30tNNXBAG3MTxyVm4gLWoRLeu8aMkxXR5aIXd9MOYtkJRcOIn3iRKveKB3637gMx X-Received: by 2002:a17:906:6859:: with SMTP id a25mr20032852ejs.524.1598524869943; Thu, 27 Aug 2020 03:41:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598524869; cv=none; d=google.com; s=arc-20160816; b=0kyCMcS8/6tF5ygwStj5Mq7igmNAu6wvZ7N+cwLzMtPt2pPZ8j2fZedTnm6ImgmW0o WVZQnwBPm1rDaXYVvr+FOBNT+dpdjErFNT/W4wr/Vdqsp9h/XZbjFpMke0OpiZCmemTT kSQkaIM9G69fnY2uxDZP4dg7d25OVhUogYSbteMjd84m6XHfXGTY0yU3OfT056faxi/0 b8LcTjq19WpcTiUfSRbb6GtUXoyqT3Hns0GGP9njNnyRi0e+SO1Eh7On8PrH0NypTvZr xR5x8CJq5fxMh1kZpPrdhHqoLeL+0M6ctHmKA0QddPGgW35pMyF+vUOH00s32PCyBU2+ pl3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8mEIx/a3yrzoKPFt6Yw2usL4Qm923jMWVkTk06lBsNQ=; b=g132LrUZnY8Kbd8iq8oDJwxj6BYByd06pc84dK8DduTKD+Vhc/6hD/Ioo6gXXxaUKk cx+XFUHDvtIV4qtnobESCb4JGoGFGnUL8y9+MNvvaPzuNS8gdDAhK7o0c+P1+xpW8VQB 2TFubLYH5BQaos/bVGtOSQnGLLWWiJURhKuQoz120GxfMjVxAcYdno5MMaWnjv+mlpAp Vvdjzg8jlOVbqJanZX4NgrUYik1PyZzelYtAL4FJK7dLFmVfbU2+9mX89OkJ1dRthjBb m+OHQqia6JTBuE/GOAXFq6BnulQTYVujE3eMgUIu0hm08e13BHZ7h/isIQ74rT2KhtkT mAqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="L//sqCAw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si1222625edr.76.2020.08.27.03.40.46; Thu, 27 Aug 2020 03:41:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="L//sqCAw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgH0KkM (ORCPT + 99 others); Thu, 27 Aug 2020 06:40:12 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47972 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728555AbgH0KkK (ORCPT ); Thu, 27 Aug 2020 06:40:10 -0400 Received: from zn.tnic (p200300ec2f104500a980b16b3f9103d9.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:4500:a980:b16b:3f91:3d9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 400221EC037C; Thu, 27 Aug 2020 12:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1598524804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=8mEIx/a3yrzoKPFt6Yw2usL4Qm923jMWVkTk06lBsNQ=; b=L//sqCAwjZGwmVXuFDW8sL4eoTT4XyJZgIGi5kN0gd9QXF1ygzZ0qlS5ou+49LLJbAVwD+ wSC9yFS7ImOYWMXM7BQ1ljuYJwbN4qBZf6TFkzI5EBeEUo1hLvBRVxldj6poARf1eDIfrI QBEgMqCnez+tMgf4g1JTbGkCx5nVkNw= Date: Thu, 27 Aug 2020 12:40:00 +0200 From: Borislav Petkov To: Alison Wang Cc: James Morse , "tony.luck@intel.com" , "mchehab@kernel.org" , "rrichter@marvell.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores Message-ID: <20200827104000.GB30897@zn.tnic> References: <20200709082215.12829-1-alison.wang@nxp.com> <92811e33-2f57-244b-4b50-c2831b09b835@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 03:03:15AM +0000, Alison Wang wrote: > [Alison] I have a look at this patch. This patch doesn't complete all > the functions in my patch. Yep, but pls work together to see if a single driver can support your hw too. > It is just to report errors, but error injection function is all > removed. Right, because you can't use that on this hw, apparently. Also note that you should disable error injection in production for obvious reasons. Thus all the error injection stuff in EDAC is behind CONFIG_EDAC_DEBUG which should be off in production kernels. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette