Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Aug 2020 07:14:08 -0700 (PDT)
Message-Id: <20200827.071408.2257489516960391705.davem@davemloft.net>
To:     mkubecek@suse.cz
Cc:     fabf@skynet.be, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200827095025.p4mxmuh2jwmzs5kt@lion.mk-sys.cz>
References: <20200827065019.5787-1-fabf@skynet.be>
        <20200827095025.p4mxmuh2jwmzs5kt@lion.mk-sys.cz>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Michal Kubecek <mkubecek@suse.cz>
Date: Thu, 27 Aug 2020 11:50:25 +0200

> On Thu, Aug 27, 2020 at 08:50:19AM +0200, Fabian Frederick wrote:
>> Replace common flag assignment with a macro.
>> This could yet be simplified with changelink/supported but it would
>> remove clarity
>> 
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>> ---
> [...]
>> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
>> index 3a41627cbdfe5..8a56b7a0f75f9 100644
>> --- a/include/net/vxlan.h
>> +++ b/include/net/vxlan.h
>> @@ -290,6 +290,16 @@ struct vxlan_dev {
>>  					 VXLAN_F_UDP_ZERO_CSUM6_RX |	\
>>  					 VXLAN_F_COLLECT_METADATA)
>>  
>> +
>> +#define VXLAN_NL2FLAG(iflag, flag, changelink, changelink_supported) {   \
>> +	if (data[iflag]) {						 \
>> +		err = vxlan_nl2flag(conf, data, iflag, flag, changelink, \
>> +				    changelink_supported, extack);       \
>> +		if (err)						 \
>> +			return err;					 \
>> +	}								 \
>> +}
>> +
> 
> Hiding a goto or return in a macro is generally discouraged as it may
> confuse people reading or updating the code.

Agreed, please don't do this.