Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Aug 2020 17:15:20 +0300
From:   Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To:     Peter Korsgaard <peter@korsgaard.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] arm: dts: owl-s500: Add RoseapplePi
Message-ID: <20200827141520.GD2451538@BV030612LT>
References: <cover.1592123160.git.cristian.ciocaltea@gmail.com>
 <2d12521d196e2c08a30aacd0ab20d93593f94707.1592123160.git.cristian.ciocaltea@gmail.com>
 <87v9h4y4dj.fsf@dell.be.48ers.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87v9h4y4dj.fsf@dell.be.48ers.dk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Peter,

Thanks for the review!

On Thu, Aug 27, 2020 at 08:44:40AM +0200, Peter Korsgaard wrote:
> >>>>> "Cristian" == Cristian Ciocaltea <cristian.ciocaltea@gmail.com> writes:
> 
>  > Add a Device Tree for the RoseapplePi SBC.
>  > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
> 
> On a related note: There is now an owl-mmc driver for the s900. From a
> quick look at the datasheet it looks compatible with the controller on
> the s500. Did you have a look at hooking that up?

Yes, please see:
https://lore.kernel.org/lkml/cover.1593124368.git.cristian.ciocaltea@gmail.com/

The clock related patches have been already applied to v5.9 and
hopefully the pinctrl driver will follow in v5.10.

> -- 
> Bye, Peter Korsgaard

Regards,
Cristi