Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp499439pxa; Thu, 27 Aug 2020 08:02:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwcevunCKVDluk3L+T7V9xQtH8HOW3wNYWLBfO4B83Lt1vvWbYAs4cC1VF0Bxzb+sV9Mxy X-Received: by 2002:a17:906:bb06:: with SMTP id jz6mr22207426ejb.248.1598540538257; Thu, 27 Aug 2020 08:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598540538; cv=none; d=google.com; s=arc-20160816; b=REgw6weeAqk40JahoGAKO7xRbzHc638anaAfpii/cAVWRo+GATxz0p1vFZTuUnPFbd IvkPM7A4nhEMcb0UiQ5Modb1sZ7QrSE8JajiL0R758YFO0l05/mK/2bNcqx520cnAO/2 3NzoHn+xY4qXd9mI8CM6vRfVblcZO//M8BlqieNLcGu7ZsVDlsznlb4xonMyWXTCK8F0 71Z6IVwDVoAJyWvR528elBtUsSmwRwIHo3IiefKFGmixQoVZA0AuzBB5653lSLPYmpTr 9vYJWBdsJKVuUR61WfNV9ikTckc6grNeftmqvHGY/UNqGL1U/3bhHrMrHQjObUMjeZaO YZMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hzfczoY08KCAOXrJ4QPUBcOl3kLlAqwyM9dLVlxgAlg=; b=sHox5NDK5cJK6xhATNCkbn/tq5UiWRifUOIBshAPmwhSQkf0JYhn9okuiUMLmkaMNh GxBljE0RrpSmIBjMPAG1UEVWGLmVJBWZU1IlAvPKgXRSEx+1O21jHKkKpNou0q29JvHu 2sPwphTiXFfILWShIgHgTnEUI+Xfbhu55dDqZziuC+ns7LNuGIwyG2B97v4veDLxnOW+ QBDzj4z3ULIT9ob+ufC4G2nbsAKk8Eg5+3IvTKaPZL3txHnLhfbEGTjfsAdUztRjoXhk bVvhr95ZN071yTmZ47FR3dV58yBcAr/1FOClkYeFjcBsrg7/uCYAsx/rMuHvlZSfolhP OMkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XUB4mNqp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si1566022ejb.647.2020.08.27.08.01.55; Thu, 27 Aug 2020 08:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XUB4mNqp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727882AbgH0O7A (ORCPT + 99 others); Thu, 27 Aug 2020 10:59:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35549 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728067AbgH0O6s (ORCPT ); Thu, 27 Aug 2020 10:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598540323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hzfczoY08KCAOXrJ4QPUBcOl3kLlAqwyM9dLVlxgAlg=; b=XUB4mNqpQVGX1lJOTw7ArMwptRJKdM8lobpXI/acVB9WOQX4mUptM1HhIKECvN5IoS89nq DstFmxawp/RVa/5fEgiICJWEsvkK2pRX+xRBQNF/gRoZ0T0Aj0h6rze2JZlFLVGIdCkZyN 8nXnCITRriEBwucli6TqjO6JeO3NQEE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-OgZhy-oMOZaq0ggeHWE2Pg-1; Thu, 27 Aug 2020 10:58:41 -0400 X-MC-Unique: OgZhy-oMOZaq0ggeHWE2Pg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85FA08018A4; Thu, 27 Aug 2020 14:58:39 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-113-96.ams2.redhat.com [10.36.113.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D6495C1C2; Thu, 27 Aug 2020 14:58:32 +0000 (UTC) From: Stefano Garzarella To: Jens Axboe Cc: Kernel Hardening , Christian Brauner , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Alexander Viro , Stefan Hajnoczi , Jann Horn , Jeff Moyer , Aleksa Sarai , Sargun Dhillon , linux-kernel@vger.kernel.org, Kees Cook Subject: [PATCH v6 0/3] io_uring: add restrictions to support untrusted applications and guests Date: Thu, 27 Aug 2020 16:58:28 +0200 Message-Id: <20200827145831.95189-1-sgarzare@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v6: - moved restriction checks in a function [Jens] - changed ret value handling in io_register_restrictions() [Jens] v5: https://lore.kernel.org/io-uring/20200827134044.82821-1-sgarzare@redhat.com/ v4: https://lore.kernel.org/io-uring/20200813153254.93731-1-sgarzare@redhat.com/ v3: https://lore.kernel.org/io-uring/20200728160101.48554-1-sgarzare@redhat.com/ RFC v2: https://lore.kernel.org/io-uring/20200716124833.93667-1-sgarzare@redhat.com RFC v1: https://lore.kernel.org/io-uring/20200710141945.129329-1-sgarzare@redhat.com Following the proposal that I send about restrictions [1], I wrote this series to add restrictions in io_uring. I also wrote helpers in liburing and a test case (test/register-restrictions.c) available in this repository: https://github.com/stefano-garzarella/liburing (branch: io_uring_restrictions) Just to recap the proposal, the idea is to add some restrictions to the operations (sqe opcode and flags, register opcode) to safely allow untrusted applications or guests to use io_uring queues. The first patch changes io_uring_register(2) opcodes into an enumeration to keep track of the last opcode available. The second patch adds IOURING_REGISTER_RESTRICTIONS opcode and the code to handle restrictions. The third patch adds IORING_SETUP_R_DISABLED flag to start the rings disabled, allowing the user to register restrictions, buffers, files, before to start processing SQEs. Comments and suggestions are very welcome. Thank you in advance, Stefano [1] https://lore.kernel.org/io-uring/20200609142406.upuwpfmgqjeji4lc@steredhat/ Stefano Garzarella (3): io_uring: use an enumeration for io_uring_register(2) opcodes io_uring: add IOURING_REGISTER_RESTRICTIONS opcode io_uring: allow disabling rings during the creation fs/io_uring.c | 172 ++++++++++++++++++++++++++++++++-- include/uapi/linux/io_uring.h | 60 +++++++++--- 2 files changed, 215 insertions(+), 17 deletions(-) -- 2.26.2