Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp520807pxa; Thu, 27 Aug 2020 08:30:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ4AlMXtZadryKZ6i+UMpHFz3C0ur2/Pmg3xMCcfXjtWIuO4iUNvoVXfaPBjZr8Vt0M6+R X-Received: by 2002:a05:6402:1427:: with SMTP id c7mr21251460edx.245.1598542241195; Thu, 27 Aug 2020 08:30:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598542241; cv=none; d=google.com; s=arc-20160816; b=GRtvpzHuuBAFdtQFCGM2T4CDE6Tlp89kkY8pI2Zg4XelxR6ZLkZi7ruHer6LNcyUhI ZnAblkFLcoBP/tiKfTfhYpyZj8Fnib3LyMQvabik2Tfjm2F7EJfZ7BjFZxyBNqzutCS4 po1zU4BSQAD6x2vhozIaIhYFNSAAVRNzA0RgD9kRvA5ZXZqz8egUiULzFMkSKbUDXtsm zOQr5WX+kRkgWjXrr8N+qok+EzUwsKplsCyHLnUYG/Xi75ObjicDeJMMDbboDU4oKtbZ rJ6aBAhMhjepHT1zoaJyghMtAMN9EIXNJ//7flakar7cMX9qxK6K/kkjG478lWPZtk/4 cnIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=dOkNodrfUq4RA2rtzFzMIItFCjHf/knevO0NoipNtsM=; b=X5xU5JyNdLt8ny0aJ20OMTdg3huN3/NqV3d6yzySPYPLF1W36hFpiEKfGkr8qZA5UG 6Q4QeOHWm1E+i4dz9R6K5DpVKdwFq1E6V7qH9qseWpdfjv9taArhsUoswAMG1dJ2QaF7 subLUXI/Qav41+Oc+LXGjpbNENmbRFBwiiSrwzAqYAxByGvVwbu7PlOMGD+fWCs5vilw Yy0lsFsxWUkei9xsGMlQwSztxCIcRWDAm+icNVzcpUIIiUBQVfK4loehXMB8MR307KQY tuStw+cgWzEEar/6dpfQbhkUjf0TUJ4fB+mZou+OK1W1Nunw6cutgED+5nn3AzWeuZWy 2tWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si1626352ejr.369.2020.08.27.08.30.18; Thu, 27 Aug 2020 08:30:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbgH0P2k (ORCPT + 99 others); Thu, 27 Aug 2020 11:28:40 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46629 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbgH0P2k (ORCPT ); Thu, 27 Aug 2020 11:28:40 -0400 Received: by mail-lj1-f194.google.com with SMTP id h19so6885067ljg.13 for ; Thu, 27 Aug 2020 08:28:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dOkNodrfUq4RA2rtzFzMIItFCjHf/knevO0NoipNtsM=; b=oPh40ZTHlf7CEvRVzx22nfYieyosV9tBvZS1FCCnB1srQM8htvX8AriLuYwzf0dlO2 3Pu4Um+eiQJqQESJtqSr7pTf8KQqD4f6RjUnBXUxzGa2Ma16frBgty6PASQgAhmoc9nB T/BTQlwZUCjRTMNiSWBX7YksUIdRXe0k3jYXVGy/fK13oesf/OtskFXqG6mbWsTgK6bb rTmRtHIhKxugsbZPc/kRUeDhdi6COJWr8SedWxrCJZwzF2Jj3KnhDbWWclIxOti+VAyV njOTdsD2e5zITEGuTw4S2KsvNxv3iyrlvmWi1J+q+WlQLi4XMwODXmDCVwtRi5p/Pf8a aIDA== X-Gm-Message-State: AOAM530PeWL3RskgUjtbazuSH/G2wJZf3kcHcbtguYUcPp12Q+jrzab8 ILE0RSvrRoussjlUbMqAC3UZTeTzVIo= X-Received: by 2002:a05:651c:1069:: with SMTP id y9mr10067891ljm.438.1598542117708; Thu, 27 Aug 2020 08:28:37 -0700 (PDT) Received: from [192.168.1.8] ([213.87.147.111]) by smtp.gmail.com with ESMTPSA id 187sm10329lff.35.2020.08.27.08.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 08:28:36 -0700 (PDT) Subject: Re: [PATCH] udf: Use kvzalloc() in udf_sb_alloc_bitmap() To: Jan Kara Cc: linux-kernel@vger.kernel.org References: <20200827151923.40067-1-efremov@linux.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Message-ID: <741486db-29e8-e24e-32c1-9559e3a76a06@linux.com> Date: Thu, 27 Aug 2020 18:28:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200827151923.40067-1-efremov@linux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -1013,10 +1013,7 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index) > size = sizeof(struct udf_bitmap) + > (sizeof(struct buffer_head *) * nr_groups); I missed that this size is a good place to use struct_size for overflow checking. I will send v2 instead.