Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ben Levinsky <BLEVINSK@xilinx.com>
To:     Michael Auchter <michael.auchter@ni.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v9 0/5] Provide basic driver to control Arm R5
 co-processor found on Xilinx ZynqMP
Thread-Topic: [PATCH v9 0/5] Provide basic driver to control Arm R5
 co-processor found on Xilinx ZynqMP
Thread-Index: AQHWfBWgHhYT12VXOUuBHovnehXuc6lL+RkAgAAbSjA=
Date:   Thu, 27 Aug 2020 15:34:33 +0000
Message-ID: <BYAPR02MB440788CF3D35297D41DA385BB5550@BYAPR02MB4407.namprd02.prod.outlook.com>
References: <20200827015810.11157-1-ben.levinsky@xilinx.com>
 <20200827134742.GB404249@xaphan>
In-Reply-To: <20200827134742.GB404249@xaphan>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f66ff7e-1cf6-4169-3360-08d84a9eb2f6
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2020 15:34:33.9763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WECNRmMjI13LyCUKiSHc+vd5lZ3y6WOlxQssIukeaa6Xdyo222jUmhRPUh/NfaZGHj60z38+7UTK3jksPuvjlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5029
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

Thanks for comment. Maybe I missed some of the comments then? I had thought=
 that your comments were the following and that I had answered them in the =
code:
V8 3/5:
- zynqmp_pm_set_rpu_mode: pass arg1 instead of 0 to zynqmp_pm_invoke_fn
This should be reflected in v9 3/5
- update kernel docs for zynqmp_pm_set_rpu_mode
may have misunderstood the comment here. I updated the function and its com=
ments above the function so that there is no obsolete iocl_id or arg2 menti=
oned
V8 5/5:
-  " In the event that zynqmp_r5_probe() fails before zynqmp_r5_setup_mbox(=
)
has run, this will be called on an uninitialized skb_queue. (Also
obviously an issue once mailboxes are made optional again)."
To remedy this I added logic in v9 in the zynqmp_r5_release() function so t=
hat the driver checks if a pointer field in the struct is NULL or no before=
 discarding skb's

Were there other comments?

With that being said, I will make sure the R51 case is more completely cove=
red.

Thanks
Ben


> -----Original Message-----
> From: Michael Auchter <michael.auchter@ni.com>
> Sent: Thursday, August 27, 2020 6:48 AM
> To: Ben Levinsky <BLEVINSK@xilinx.com>
> Cc: Stefano Stabellini <stefanos@xilinx.com>; Michal Simek
> <michals@xilinx.com>; devicetree@vger.kernel.org;
> mathieu.poirier@linaro.org; Ed T. Mooring <emooring@xilinx.com>; linux-
> remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org; Jiaying Liang
> <jliang@xilinx.com>; robh+dt@kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v9 0/5] Provide basic driver to control Arm R5 co-
> processor found on Xilinx ZynqMP
>=20
> Hey Ben,
>=20
> On Wed, Aug 26, 2020 at 06:58:05PM -0700, Ben Levinsky wrote:
> > v10:
> > - add include types.h to xlnx-zynqmp.h for compilation
>=20
> I appreciate the quick turnaround on v10, but it looks like much of my
> feedback on v9 went unacknowledged.
>=20
> Most concerning is the fact that loading firmware on to R5 1 is _still_
> broken in v10 due to the incorrect TCM banks being used.
>=20
> Thanks,
>  Michael
>=20
> >
> > Ben Levinsky (5):
> >   firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
> >     configuration.
> >   firmware: xilinx: Add shutdown/wakeup APIs
> >   firmware: xilinx: Add RPU configuration APIs
> >   dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
> >     bindings
> >   remoteproc: Add initial zynqmp R5 remoteproc driver
> >
> >  .../xilinx,zynqmp-r5-remoteproc.yaml          | 113 +++
> >  drivers/firmware/xilinx/zynqmp.c              |  86 ++
> >  drivers/remoteproc/Kconfig                    |  10 +
> >  drivers/remoteproc/Makefile                   |   1 +
> >  drivers/remoteproc/zynqmp_r5_remoteproc.c     | 898
> ++++++++++++++++++
> >  include/linux/firmware/xlnx-zynqmp.h          |  63 ++
> >  6 files changed, 1171 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-
> remoteproc.yaml
> >  create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
> >
> > --
> > 2.17.1
> >