Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f939c3d239443a68e0aff7148b1c245ffc18643d.camel@perches.com>
Subject: Re: [PATCH] udf: Use kvzalloc() in udf_sb_alloc_bitmap()
From:   Joe Perches <joe@perches.com>
To:     Denis Efremov <efremov@linux.com>, Jan Kara <jack@suse.com>
Cc:     linux-kernel@vger.kernel.org
Date:   Thu, 27 Aug 2020 08:49:41 -0700
In-Reply-To: <741486db-29e8-e24e-32c1-9559e3a76a06@linux.com>
References: <20200827151923.40067-1-efremov@linux.com>
         <741486db-29e8-e24e-32c1-9559e3a76a06@linux.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-08-27 at 18:28 +0300, Denis Efremov wrote:
> > @@ -1013,10 +1013,7 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index)
> >  	size = sizeof(struct udf_bitmap) +
> >  		(sizeof(struct buffer_head *) * nr_groups);
> 
> I missed that this size is a good place to use struct_size for
> overflow checking. I will send v2 instead.

And you could cuddle the

	if (!bitmap)
		return NULL;

by removing the blank line between the alloc and test.