Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp559530pxa; Thu, 27 Aug 2020 09:24:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy86uDAD7qawhW8Gm58TWraI9prIMK4sX0gfIHGWjrXQK60DwIOOPs9E+jfCbOWLdJYZ3Tc X-Received: by 2002:a50:eb9a:: with SMTP id y26mr16969793edr.123.1598545486990; Thu, 27 Aug 2020 09:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598545486; cv=none; d=google.com; s=arc-20160816; b=E/NGiWDD1SuoGCfG91fnt7BTGpy4J+AW5Ns8Fi6kSSDlaw79jBhKliFgvQa2lmC5A1 zHbp1WPf/K0D+fERUPoDgWQp5Foz0yqXveTLDioVLNjyXGcdGsfZy33o3MSstrhtGRkQ GfxsmlYdBrJEPB8p41O//bZAMMZqrZETDsju0RrrpTTD3MnRfrZgXPf3B6cniWIrEdbx Qwl5Yb0XV4BmMmVO00I+YnwZVGwUMbqO4xuiEX0fLW3B+0TzSUQN37J2Eo5Mknl8CyUf CT25HWl5mJDM7yqxuxtHXlwswMGWFhT1iHy8ii/YSOQNXO6WaoaXAjGcd0WgRoSEd8V1 4lUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=15+7ZeGTiVqYsgGTf8WTKBRYLUjS9SNNpRwCigns3M8=; b=AHXCJxApzAkBxNQY0DwK8ScPLAgU/JpfbMdgN2rz/nrNSlyNrPN0Bz9Yj+Gu1pVOqq 5/6LptzKP75YfMGNC8o0nWma4jsXwcwrbz2OURf6PaMTksY5zPdzIItLtVmCdObhadAT 691XVPhc1RMLhxEAucnvFRGAhVUE+gwP34wInz5/jGh1MBehw6BJXlyIVVWfrA+kXXIR qfKUWQ8kYb7Bzz/cBAOGI8fxan2lYSIhMwzOOy0LYsvRyeNvmz2Yszg2JSHMZ3pupNzP tQ5mimzbTysp4Z7zDX1wKCHQfJBZ/L0XLy/qGSClUfgKARtTadbwGV5HVz7NsgCw+nDF CmMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=QB4W7D5e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si1751782ejl.1.2020.08.27.09.24.23; Thu, 27 Aug 2020 09:24:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=QB4W7D5e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbgH0QXu (ORCPT + 99 others); Thu, 27 Aug 2020 12:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgH0QXt (ORCPT ); Thu, 27 Aug 2020 12:23:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665B2C061264; Thu, 27 Aug 2020 09:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=15+7ZeGTiVqYsgGTf8WTKBRYLUjS9SNNpRwCigns3M8=; b=QB4W7D5eRkbr7yQH+De6JSrJuO 42UzsVfF3G+jIeAwpPRr1+Ut+b2uV/aVPqBzgeA8pFVqHeMq3Qn4KsG9zgBkoJWf+iCottELfWkXJ ny2zfnEQ9QUqFo7D7raiPaBaCuudqTz7wY8fGXmA2AElFX8XO3pV2XxOM4xsJc8KGwURzwbJ8Q6VT dwOxzuZC+/7GuoAHEIqSARpB/NQcdvmwoToRAehicBxQvQdztKrnN6mp8NHuqHTNOI4nbJ67MMjRv R21/cL36QHF8U6HYqQy2qir2GHIda/+oDojfskBBUHi1YiSPZ8t7dGbLwzX4wwcJ+XgEdTl54x9kg FbrJO33g==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBKgX-0001up-DA; Thu, 27 Aug 2020 16:23:33 +0000 Date: Thu, 27 Aug 2020 17:23:33 +0100 From: "hch@infradead.org" To: "Derrick, Jonathan" Cc: "hch@infradead.org" , "wangxiongfeng2@huawei.com" , "kw@linux.com" , "hkallweit1@gmail.com" , "kai.heng.feng@canonical.com" , "linux-kernel@vger.kernel.org" , "mika.westerberg@linux.intel.com" , "Mario.Limonciello@dell.com" , "linux-pci@vger.kernel.org" , "Williams, Dan J" , "bhelgaas@google.com" , "Huffman, Amber" , "Wysocki, Rafael J" Subject: Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain Message-ID: <20200827162333.GA6822@infradead.org> References: <20200821123222.32093-1-kai.heng.feng@canonical.com> <20200825062320.GA27116@infradead.org> <20200827063406.GA13738@infradead.org> <660c8671a51eec447dc7fab22bacbc9c600508d9.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <660c8671a51eec447dc7fab22bacbc9c600508d9.camel@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2020 at 04:13:44PM +0000, Derrick, Jonathan wrote: > On Thu, 2020-08-27 at 06:34 +0000, hch@infradead.org wrote: > > On Wed, Aug 26, 2020 at 09:43:27PM +0000, Derrick, Jonathan wrote: > > > Feel free to review my set to disable the MSI remapping which will > > > make > > > it perform as well as direct-attached: > > > > > > https://patchwork.kernel.org/project/linux-pci/list/?series=325681 > > > > So that then we have to deal with your schemes to make individual > > device direct assignment work in a convoluted way? > > That's not the intent of that patchset -at all-. It was to address the > performance bottlenecks with VMD that you constantly complain about. I know. But once we fix that bottleneck we fix the next issue, then to tackle the next. While at the same time VMD brings zero actual benefits. > > Please just give us > > a disable nob for VMD, which solves _all_ these problems without > > adding > > any. > > I don't see the purpose of this line of discussion. VMD has been in the > kernel for 5 years. We are constantly working on better support. Please just work with the platform people to allow the host to disable VMD. That is the only really useful value add here.