Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] memory: omap-gpmc: Fix build error without CONFIG_OF
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        YueHaibing <yuehaibing@huawei.com>
CC:     <tony@atomide.com>, <ladis@linux-mips.org>,
        <bbrezillon@kernel.org>, <peter.ujfalusi@ti.com>,
        <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200826125919.22172-1-yuehaibing@huawei.com>
 <20200827125316.20780-1-yuehaibing@huawei.com>
 <20200827132154.GB4384@kozik-lap>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <45d3fa05-01e8-c879-e314-ae627ca4c266@ti.com>
Date:   Thu, 27 Aug 2020 19:37:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200827132154.GB4384@kozik-lap>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 27/08/2020 16:21, Krzysztof Kozlowski wrote:
> On Thu, Aug 27, 2020 at 08:53:16PM +0800, YueHaibing wrote:
>> If CONFIG_OF is n, gcc fails:
>>
>> drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
>> omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'
>>
>> Add gpmc_read_settings_dt() helper function, which zero the gpmc_settings
>> so the caller doesn't proceed with random/invalid settings.
>>
>> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v3: zero gpmc_settings
>> v2: add gpmc_read_settings_dt() stub
>> ---
>>   drivers/memory/omap-gpmc.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
>> index cd9e80748591..e026b4cd3612 100644
>> --- a/drivers/memory/omap-gpmc.c
>> +++ b/drivers/memory/omap-gpmc.c
>> @@ -2310,6 +2310,10 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
>>   	}
>>   }
>>   #else
>> +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
>> +{
>> +	memset(p, 0, sizeof(struct gpmc_settings));
> 
> sizeof(*p) but if patch is otherwise ok (got review/ack) then I can fix
> it while applying.
> 
> If there is resend, please fix it as well.

With the sizeof(*p) change.

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki