Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Aug 2020 20:33:23 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        Anson.Huang@nxp.com, marcel.ziswiler@toradex.com,
        sebastien.szymanski@armadeus.com, michael@walle.cc,
        rjones@gateworks.com, leoyang.li@nxp.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net,
        letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2
 HD
Message-ID: <20200827183323.GE103070@latitude>
References: <20200826204251.5082-1-andreas@kemnade.info>
 <20200826204251.5082-3-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RE3pQJLXZi4fr8Xo"
Content-Disposition: inline
In-Reply-To: <20200826204251.5082-3-andreas@kemnade.info>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--RE3pQJLXZi4fr8Xo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote:
> This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based
> on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL
> SoC.
>=20
> Expected to work:
> - Buttons
> - Wifi
> - Touchscreen
> - LED
> - uSD
> - USB
> - RTC
>=20
> Not working due to missing drivers:
> - Backlight (requires NTXEC driver)
> - EPD
>=20
> Not working due to unknown reasons:
> - deep sleep (echo standby >/sys/power/state works),
>   wakeup fails when imx_gpc_pre_suspend(true) was called.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
[...]
> +		fl {
> +			label =3D "Frontlight";
> +			gpios =3D <&gpio3 26 GPIO_ACTIVE_LOW>;
> +			linux,code =3D <KEY_BRIGHTNESS_CYCLE>;
> +		};

Another option might be KEY_BRIGHTNESS_TOGGLE/KEY_DISPLAYTOGGLE, but
it's not a perfect match, either. (And perhaps a worse match due to the
connotation of turning the display off.)


Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>

Thanks

--RE3pQJLXZi4fr8Xo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl9H/GIACgkQCDBEmo7z
X9tufxAAvtp6+WXWxqDO+2LqEf6DmXG80cKCHTfpPshB+iWKBRfxjlqNrOjcD3Fn
iZH0NTxUZ3dKzAEIrY8CBi8Ygjo41Rk+9AgOkYIECJ6YBS5fUnjOJe2tUPXar9m+
wI0mI8nAoTFtSSoMX2+XvGDEOhZ7PYIc6G1mM5h9m6phtSulSYVr6M8ALJTh+wxM
VqdsWkKbHcmwOQbe0xYcro6p4WQ5xX9Y7zdsGxD8mmxwLxYD+9mB2X4EAGF0Di0W
lxdoC4DDJ6wBX/8c+8vRaQQCKX6HDgjfeVoSRGrHQi3fQOFfmieyjZZhU+j4rHjP
zKjmzXwiZjiVorDXYbhcWY84epp6hFw4wYSZwHKXzz69lOIiBjUjQM57mY2YI8yt
s5jXNlIP8crJzA8lRPtXMr6wFKLfcOOSwkgSStG2CXHrnnQvwEHgjB3J2yr5XqMu
tAgWQ9lh5Af02xcAHUttR/d1wePLo0nNEoJJUUslpDAwPfM9/juHynIYSHEXadPh
+q3qJdqTH1iC4SZAoLJXqfe9ptQo8qXArTEOD6DaGF3MEZMFOJPupU/zHEyGyND7
DDZX4OBMEF4QaY0vgT/WFghZTaEHdlZCSopMRNOb04gEHT7hPqgX5ITYEm8bjJma
AhBDQXdsY5ejCJMhtJEM+2FI4Bkdx/ArF8lZQWJ1KxFmlgbWnAI=
=ylRR
-----END PGP SIGNATURE-----

--RE3pQJLXZi4fr8Xo--