Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp642516pxa; Thu, 27 Aug 2020 11:42:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKQJJIM4K9PssAANl/G7vHp0QI3xb68D9ISIKq1q9lY7Z7ew65wm2gZUDz4YB/iNTm7yPI X-Received: by 2002:a17:906:ccd5:: with SMTP id ot21mr9833007ejb.322.1598553739845; Thu, 27 Aug 2020 11:42:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598553739; cv=none; d=google.com; s=arc-20160816; b=T5f4QITgmrtp0ayY1YY03hRgzQtm6quK5LguJW/+n+iE3nVbFKBAFG0aPaeRfAfTc8 djZGwJ1Ss78mazkEe6aMOqwWImyZ4pMLvDBCfBLJoPRzLunhPZohl/PnGatvS4qm+Rz3 iBqhTOBA+S1sXb+NrefV5hdTtf8x+UIWIUj4ClL2H42QKEFdTSzYCxBw1JFkTm5VOBVs 6svHWQHrK53E6prlwmRcHMq85Kx9L20+weeThcPDlGPUobykwVJEdTj1ge8zfaQ9ihuV TafXVPnepdwctZJ+8y7GXLvWyAfy4+Kk20i8hc5UCPU0fWtHBrnRsWT3XmfEMnUxg29O B5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=j3Vd6g98KhVU6Iqw4vSL8bglGybIxelOWt5FP/Sv7j4=; b=Mjj14kKfudjeWkSE2pbtTQLmL2gHg5r/9IXfwS4IIWaMyZJKfzLdXiR3SbhvkCv+4P PG3LqKU8eUFnGRLPZLEZ/9xc+Xm+wyw1V2cS+lJkDZycJ/7oST4Zj9Hu3YtcOm16OTEX 4YfFPpL0J8jO1X2PyP50GEcc2yV+uF273Sgp1DhHgSPSXpta2e1UpVZ31z9vSFTpR8ft 2xIiccVsnI6OTJdbw1UXpRVxBbU589MXR7WwgCTiJdHEw/44zbTK7LQzifEaP6dVH2nW fSOBpCN0vBUbR1tF4GYsBW6OOgxouWoyDGTi06Hv3J85ujzdwNpVJcWIGpgp02N43QhA NXJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=c5KMKyG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr22si2562232ejc.35.2020.08.27.11.41.56; Thu, 27 Aug 2020 11:42:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=c5KMKyG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbgH0Ski (ORCPT + 99 others); Thu, 27 Aug 2020 14:40:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbgH0Ski (ORCPT ); Thu, 27 Aug 2020 14:40:38 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 960B0C061264 for ; Thu, 27 Aug 2020 11:40:37 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id i10so7606292ljn.2 for ; Thu, 27 Aug 2020 11:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j3Vd6g98KhVU6Iqw4vSL8bglGybIxelOWt5FP/Sv7j4=; b=c5KMKyG6C7XEnhdxvESgyMYwmFezTimYCP0s3XadBQFgwZl9BYx8wM0CZwKfLEmj5Y EPdPKzf2xFbs3wsYbHXCFag04NDG6SXaKu3bMGVW7Rb1oXNSQUY0oVth6/mNM31LZ5Ks HKwLOkuzj60m09lJs5zfs8apSj9dwIjpQ+beE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j3Vd6g98KhVU6Iqw4vSL8bglGybIxelOWt5FP/Sv7j4=; b=IwtOJQNp6OGhWDAoP+2numq27H3cf0Rjgy3iLtsdtukTslypOnyObUedhpPH3Wxs9y k85lYkx4IhKUzt/ipBEAAvs7pyIBazAZ9Gv0TpXHMultTD9HsHYQlxbG26HhigsYoRYf epnYiepYFBKbESJV6fF3Zhn2X6hXGWnM2BsoXUUdEu08eturv2ykHtpo8jv72WRAS7L/ 5+VQBgG/tfgxZIzjL0c+/k6bLaE+I/0lS8xJIJ+vtBHkMvJBUZwJvAX0Dua0tpsWgiB9 gxMGqthjS47CcEDSSQ9ue3SOXHs701SkVjjvdu+hIdsYbh95z1VEcNC9UljfxJCY5WFy 03Ug== X-Gm-Message-State: AOAM532YgOlN4+OUMBDsIFnWoFufM8SI5iz+2EgagCAJgWt98DvcqKN/ EX+vC9BLaciGyRpyXIDgc+wprD8JS88LLg== X-Received: by 2002:a05:651c:1b4:: with SMTP id c20mr9878928ljn.432.1598553635692; Thu, 27 Aug 2020 11:40:35 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id j1sm641044ljb.35.2020.08.27.11.40.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 11:40:34 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id m22so7575000ljj.5 for ; Thu, 27 Aug 2020 11:40:34 -0700 (PDT) X-Received: by 2002:a05:651c:503:: with SMTP id o3mr11144185ljp.312.1598553634230; Thu, 27 Aug 2020 11:40:34 -0700 (PDT) MIME-Version: 1.0 References: <20200827013636.149307-1-allen.lkml@gmail.com> <1598553133.4237.8.camel@HansenPartnership.com> In-Reply-To: <1598553133.4237.8.camel@HansenPartnership.com> From: Linus Torvalds Date: Thu, 27 Aug 2020 11:40:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] linux/kernel.h: add container_from() To: James Bottomley Cc: Allen Pais , Andrew Morton , Kees Cook , Thomas Gleixner , Linux Kernel Mailing List , Greg Kroah-Hartman , Jens Axboe Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2020 at 11:32 AM James Bottomley wrote: > > > The tasklet rework people don't want to use container_of, which was our > first suggestion, because it produces lines which are "too long". WTF? Next somebody will decide that our list handling macros don't match their mood, and make up their own. Guys, there's a real advantage to just following convention and not confusing people with new made-up stuff that does the same thing just using slightly different names and slightly different semantics. So let the tasklet rework people work on their own little thing if they can't play with the rest of the kernel. We'll just ignore them. Linus