Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 18/18] iio: magnetometer: iio-mux: Simplify with
 dev_err_probe()
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Kukjin Kim <kgene@kernel.org>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Beniamin Bia <beniamin.bia@analog.com>,
        Tomasz Duszynski <tomasz.duszynski@octakon.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        linux-amlogic@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com
References: <20200827192642.1725-1-krzk@kernel.org>
 <20200827192642.1725-18-krzk@kernel.org>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
Message-ID: <325481bb-64b7-b063-f210-65d167888ca7@axentia.se>
Date:   Thu, 27 Aug 2020 23:52:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
In-Reply-To: <20200827192642.1725-18-krzk@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: sv-SE
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.13.3] (85.226.217.78) by HE1P195CA0004.EURP195.PROD.OUTLOOK.COM (2603:10a6:3:fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Thu, 27 Aug 2020 21:52:51 +0000
X-Originating-IP: [85.226.217.78]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb212ce4-0bee-44aa-b583-08d84ad38cfd
X-MS-TrafficTypeDiagnostic: DB6PR02MB3176:
X-Microsoft-Antispam-PRVS: <DB6PR02MB3176F05D83B87F5FF26795A6BC550@DB6PR02MB3176.eurprd02.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7Z33sRAWscyOK035iaeJVLTdnhzfui+/SL/dYZv+D5DJ8bxNsTb31/4fzrHpO7s9/veHFvKZPTnbUydU8LaoOZJWFu38YO2vfwz2/8ufHQE4SYQkkDYRt4JNpcSk0piCklIsO2KBW7GFMZRbuOeQPTdcCRJK2lsYRfNdAjTuYkeIMIpR+WoXHgZQZo/JxUy6wIn1S5mQKiX/vmUSFyS2hgb91RZzyeXuoTnvIbz82a5btN5qEXRu78hWDIA6Y4W2oZMCaTqmkJxseSAgydaLogj5ZL7sDSPeX7TG2bCYnpZHmRiZCIzMqOgkFosaLmhQTuZxCVJv/K4lbPOLKo9srU55sS3ePzo9QfsosrObQExpAK2zDIywFJATCogTN1I9tEvcW8cwLixCxhHFJyPrFA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR02MB5482.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(366004)(136003)(39840400004)(36756003)(16576012)(8676002)(316002)(53546011)(186003)(8936002)(36916002)(83380400001)(2906002)(52116002)(26005)(66946007)(6486002)(66556008)(110136005)(478600001)(66476007)(86362001)(2616005)(16526019)(6666004)(7416002)(31686004)(956004)(31696002)(5660300002)(921003)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: aBSuJ1Qg631JDAQY1otRa8HjN8rHjUEZweseGyn0E9YoyjyYpOukbSE77sVeIrkNeE5SWzQBHt2fpTRZZcx/EyfUqKmjbIn5D4MF/SKWq4VDT9PlHuHGts/t+MnIinyLByybW+5591ZUmfe9dt/inNeo2jnO9lDHESvq1IehnZE/Av7gXTioDmOxiRiux/ul8Q/saL9ih3IzxHOTkDCtOAAe3HJiJ1I5zlbV+uH4Jsjnpvc459eeZb7PpMwcxXvWb3mcYM+gYemcrxtjukBn+m38tPV7tMl0Gms6OxbjOiIDqlzAfeRqD3KrWXwIphcK3G+Hlm5dOQgQs6krdfcYJL07HijOn+tn9S7mr5zi8ilJDaalahI8GlM8BrsbGuz4iFMJg5JwtQ6oyyKl87kgzNyaLvYgtvisjAj2S/ygKd7pv/9h4NwYFSvEW6N166y62vwcpa1TSyXg7p1PiFTPAc8iZbRPPXw0koRh8Kw/n/H+qsTIOhMEIWwp0yEmiIQ6FLEYNHZFX3TexwcmWsMmDmqWXIZ2o+MZymLWFqPaUO+bnb/1c4zrUSwA9VlYjSUFioJVDNHAh/iuFRE7S4zZ1ZS1l20IM8EeeWhpCKYojwsY4gwBAYCGp9IreCr4n0oepRzBBF1krTQJis+yBR2EkA==
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: fb212ce4-0bee-44aa-b583-08d84ad38cfd
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2020 21:52:53.9925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gp8pe3RxEyeZgAS7g3nmk73OTM7sKAfnY0UfGUdpnPD0Z5saWMFXnqGXSIN85j8i
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR02MB3176
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

Wrong subject. Made me overlook it on the first pass...

On 2020-08-27 21:26, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/iio/multiplexer/iio-mux.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index 6910218fdb00..d219d4a86657 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -354,11 +354,8 @@ static int mux_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  
>  	parent = devm_iio_channel_get(dev, "parent");
> -	if (IS_ERR(parent)) {
> -		if (PTR_ERR(parent) != -EPROBE_DEFER)
> -			dev_err(dev, "failed to get parent channel\n");
> -		return PTR_ERR(parent);
> -	}
> +	if (IS_ERR(parent))
> +		return dev_err_probe(dev, PTR_ERR(parent), "failed to get parent channel\n");

As per the comment for 9/18, I'm not a fan of the long line here...

Cheers,
Peter

>  
>  	sizeof_ext_info = iio_get_channel_ext_info_count(parent);
>  	if (sizeof_ext_info) {
>