Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp893475pxa; Thu, 27 Aug 2020 20:02:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwdDWRJYeJzvlhX43P2GtcHp4IfO+agyeKobiENE6JAjCgBAQgEkvGR3uxxEWMjFyxUaE3 X-Received: by 2002:a17:907:2805:: with SMTP id eb5mr25254945ejc.254.1598583735853; Thu, 27 Aug 2020 20:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598583735; cv=none; d=google.com; s=arc-20160816; b=m7xfYqTPHaX1hxB4Rkjxo03ORs6slysl4eON2ChyN+xh0/fT0XhA5ZoG9ypNOr0t8A Ee82S/UZPsryvkWLZZHHjNjfyQD5M5tDPGT3ku2eVM+u0Q8BAw6wfpGbckmsgCrUMiCz PMVoYbeJxrND0hYPf/V2xlS7ISzWkKW8Ks1GBQPjD2UmUx8LbJVo0kVsVPQ5h60DUFwq OvPLXaL9XlmowurL7Vng0OyXSVe3rxJUHZjQuPnCRAXfmQNnWeS8LtCdEG2HyvcGT25j +3gfTt0wIZ/PCYSodR1X7yyBQ/iEtZ1qSI2NkaCJoisiSqsagx6sgHoEIJQ6WUfnDJIJ tMqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=IiuhGhzNgL/DLui8gzTK8ao7Oz/TOVe+cUKUpQqg/f0=; b=sFSowaH46MGlIWp+EnHlrAODrSBBgY4W2cRA30zOLTlUEaXhEeCWATNS7+4jR2JjdT TqlaxriRTPhkxRnfOXzKtrerkV+IBc/UA6l3yptk7dUinRVjcfBI6nedhHA/x/dHInUn +dVydM3nYctFZ7q+JDo1vrlrin39NWOkc83FXgvCorxuzd+3LWjfqPooeJ+PcidHagW1 qCcVDSPSU5SZjnZt8J8cjTzJyk34T79F8NaaakOM+Sj21PYbtd+q/KiWMQoHS/gB1djZ /iP7sbHHrKligUzYLFlxBQmSp7LcuMUQJAwuXJbj7HhkoqEzpzuJP2fEKyGNInlU8Niy IXcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=A21YlOTJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si2623857edr.513.2020.08.27.20.01.52; Thu, 27 Aug 2020 20:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=A21YlOTJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbgH1DBS (ORCPT + 99 others); Thu, 27 Aug 2020 23:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726972AbgH1DBQ (ORCPT ); Thu, 27 Aug 2020 23:01:16 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43FFBC061264 for ; Thu, 27 Aug 2020 20:01:16 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id o13so4784530pgf.0 for ; Thu, 27 Aug 2020 20:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IiuhGhzNgL/DLui8gzTK8ao7Oz/TOVe+cUKUpQqg/f0=; b=A21YlOTJEsZNmnka2SfNcYfgw1+lPMwJqhBVCkpEPv7LqDIBnDQ1HyazAFYe3K5uz2 P9BSVvy4PZtAGr2MZ3SLhzIdEgEEDcCVNXLIHl0XN5Suu0YyGuHwSJfASthuIGbDq3IQ vb5ym4nNJOEbsawe5V/XdyIOduT+k+Bd5H2LWHDaJWDfIhRafUXcWvZYFFuV3PUwNYps k20xTAnBGa9QEmhjnP0csDgUrCHWALxg/bbUVlV1EJmuQQMn2axcjNTl7+5TB7+HJd9P /X1wZdjRci0LnAeuD+O5cXn22bEFiQ2dk5WQ8V1bV2NqM4SlAQ33C+QNdmaOGpA7Eikx YclQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IiuhGhzNgL/DLui8gzTK8ao7Oz/TOVe+cUKUpQqg/f0=; b=AGb9Eaw6x1vVibh3T9AnruCR2OKn4ruQUXl8YsJPUe6KSyf8qSOghlbV+M+gh6341M Snbk70dvVm1tHCgdaXr4b70h0He6JZVy2lVw3LTFBtmqXrk4FKS69Z+U/vpYWgaYFSMl IRdtRPoqL+QT+kA8jPkUT3skstdYt27VB0eWH+EIVxyYg5nWzpaNtxdaTqmBO8Cp0SE1 Sp+uHUVSxWQstRA/pr7e9vqyBlP07yWtgPkO37/jG+MUTTkkcvJ9/FR3yfekc8ehhg57 rdWHC1GeRrR1EWVegs3cEOCNqKeb+bW2Doo6bCyzK/irVpDbVZAo2KlNSjuxHH7TWogY DRRA== X-Gm-Message-State: AOAM532yKRuHqBGOlIVasWHjUw3SA/fAFO7k/7uGhj55cPDc1XGo8dBS PwHOmMEnc/Pi7Da6AX2EGdczlg== X-Received: by 2002:a05:6a00:15cb:: with SMTP id o11mr19227116pfu.263.1598583675314; Thu, 27 Aug 2020 20:01:15 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id t10sm3575280pgp.15.2020.08.27.20.01.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 20:01:14 -0700 (PDT) Subject: Re: [PATCH v6 0/3] io_uring: add restrictions to support untrusted applications and guests To: Stefano Garzarella Cc: Kernel Hardening , Christian Brauner , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Alexander Viro , Stefan Hajnoczi , Jann Horn , Jeff Moyer , Aleksa Sarai , Sargun Dhillon , linux-kernel@vger.kernel.org, Kees Cook References: <20200827145831.95189-1-sgarzare@redhat.com> From: Jens Axboe Message-ID: <8a86fc8a-56f6-351e-aaee-d80c4798d152@kernel.dk> Date: Thu, 27 Aug 2020 21:01:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827145831.95189-1-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/27/20 8:58 AM, Stefano Garzarella wrote: > v6: > - moved restriction checks in a function [Jens] > - changed ret value handling in io_register_restrictions() [Jens] > > v5: https://lore.kernel.org/io-uring/20200827134044.82821-1-sgarzare@redhat.com/ > v4: https://lore.kernel.org/io-uring/20200813153254.93731-1-sgarzare@redhat.com/ > v3: https://lore.kernel.org/io-uring/20200728160101.48554-1-sgarzare@redhat.com/ > RFC v2: https://lore.kernel.org/io-uring/20200716124833.93667-1-sgarzare@redhat.com > RFC v1: https://lore.kernel.org/io-uring/20200710141945.129329-1-sgarzare@redhat.com > > Following the proposal that I send about restrictions [1], I wrote this series > to add restrictions in io_uring. > > I also wrote helpers in liburing and a test case (test/register-restrictions.c) > available in this repository: > https://github.com/stefano-garzarella/liburing (branch: io_uring_restrictions) > > Just to recap the proposal, the idea is to add some restrictions to the > operations (sqe opcode and flags, register opcode) to safely allow untrusted > applications or guests to use io_uring queues. > > The first patch changes io_uring_register(2) opcodes into an enumeration to > keep track of the last opcode available. > > The second patch adds IOURING_REGISTER_RESTRICTIONS opcode and the code to > handle restrictions. > > The third patch adds IORING_SETUP_R_DISABLED flag to start the rings disabled, > allowing the user to register restrictions, buffers, files, before to start > processing SQEs. Applied, thanks. -- Jens Axboe