Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp982743pxa; Thu, 27 Aug 2020 23:42:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV/yro+FcpFAbpDDN8KLrEeMmcST1SV2cX6um7VaipwgqDBM6kCP1gKYaCtlzYK2762yhl X-Received: by 2002:aa7:c143:: with SMTP id r3mr378749edp.38.1598596925331; Thu, 27 Aug 2020 23:42:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598596925; cv=none; d=google.com; s=arc-20160816; b=uJYVns9e8cRzsE0FkPUS3SMkSWOz1ZTMWwGIeY39e2rhmyhaqOgbe5E5qFNYPUIZIp EkPQqQOqgiJfPtIQu1GpEIeUZigzlwfc4KPtI9Xzk9XXWf9zuRCXamWoMd/nUdnUbzfR nfT7s1sgyMyZx9BDnT5q9MpJPliOkcayAEaYLuB+IIafaUD3Xc0yazN90+XbIA7y07iR OxwQDCSueMNz1WPTZ/upO/FYc8hjBMRCUjw/FG0BZ1nVUtaGp04xSPbXLnsJ/Z7ZeYuy 07X55XgxmRLXDoj0EmqxL63BIAC+cc8zeX3zZgfE0EWRQyuuZDz5KLcNOR/w99d5IGJH iTsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=CdphvIxkab/YX1ffuXPnoifp6qWQpQf0APCtuuMP1Lw=; b=YSw/HFan8jof6ffzzh+3T1Apv/f9+iOGvAx7fL+fP4x86o59dc8am3UbcSNfve/6mN brMRLZq6H1jBcmllSNyBDpTisUg19MR2IlFZpK3h+e4RmTaKTw6Y3FsQ4foKrhOGMQJy U4YqRnd842BHCa7ADThDUYulCIy2OnvNAq3CasFVyb+SOtUH/H8cyEdbqXjMNaNXKn4Q nz38LVjmGy6zJy7TrKjhVHfTHfR8GAtGkFR+VgjEjFeBxk7JxfGdMGrX849xuDbRcaAX c2eS9sHkMnF94BPQUbLcV/9rnJBn7WT9qxFqX8HMuBFuVa/HHZQuzaiHiqUXpW5Go6WB ef+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si925edx.86.2020.08.27.23.41.42; Thu, 27 Aug 2020 23:42:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726644AbgH1Gkv (ORCPT + 99 others); Fri, 28 Aug 2020 02:40:51 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:43184 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgH1Gkv (ORCPT ); Fri, 28 Aug 2020 02:40:51 -0400 Received: by mail-ej1-f67.google.com with SMTP id m22so54395eje.10; Thu, 27 Aug 2020 23:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CdphvIxkab/YX1ffuXPnoifp6qWQpQf0APCtuuMP1Lw=; b=nX03C9yhufTPAh5mHQQQTIQwn16/VdoduYkKzR9PyE7danmJlLzUlWR4AI7yPYJKgv tTy49WHYMQ+okTnF4hohwB1+EuqGjF0aj5SMsThA3QYl5sEl9RWSICe6olHvGiMnCq8d CEvNgDOcoc1SI7RwCblu/vcF7T6Ll0HwkQET8vsrs+M+u5x7ahTfocl6+vKPd+KJJL0Z Uy6goLsBykTThMqC731YeXo4SwY4oVcmzLqDJQgqnBvY0/tG6ooV7IzjOH2ZaWS/73nb aZJHAFAzry3eGtzWCtspwAxDmgOz1BvihfiqwNK7yrDFTwTrk6L4LipnqySG4mBOIpWg wkfw== X-Gm-Message-State: AOAM532Pp89juW6y8TBoi+An54BTV5KS1yT/vwUNQH5P4VcAYVUue0bP U8wYS5B71RGle1/qrKUjRUU= X-Received: by 2002:a17:906:970e:: with SMTP id k14mr291072ejx.417.1598596848763; Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Received: from pi3 ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id 24sm162457edx.35.2020.08.27.23.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Date: Fri, 28 Aug 2020 08:40:45 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: linux-clk@vger.kernel.org, Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Kukjin Kim , Rob Herring , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 3/3] clk: samsung: Use cached clk_hws instead of __clk_lookup() calls Message-ID: <20200828064045.GC17406@pi3> References: <20200826171529.23618-1-s.nawrocki@samsung.com> <20200826171529.23618-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200826171529.23618-3-s.nawrocki@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 07:15:29PM +0200, Sylwester Nawrocki wrote: > For the CPU clock registration two parent clocks are required, these > are now being passed as struct clk_hw pointers, rather than by the > global scope names. That allows us to avoid __clk_lookup() calls > and simplifies a bit the CPU clock registration function. > While at it drop unneeded extern keyword in the function declaration. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/clk/samsung/clk-cpu.c | 37 +++++++++++++++--------------------- > drivers/clk/samsung/clk-cpu.h | 6 +++--- > drivers/clk/samsung/clk-exynos3250.c | 6 ++++-- > drivers/clk/samsung/clk-exynos4.c | 7 +++++-- > drivers/clk/samsung/clk-exynos5250.c | 4 +++- > drivers/clk/samsung/clk-exynos5420.c | 6 +++--- > drivers/clk/samsung/clk-exynos5433.c | 10 ++++++++-- > 7 files changed, 41 insertions(+), 35 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof