Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200827180904.96399-1-ubizjak@gmail.com> <20200827201423.GD1236603@ZenIV.linux.org.uk>
In-Reply-To: <20200827201423.GD1236603@ZenIV.linux.org.uk>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Fri, 28 Aug 2020 08:41:18 +0200
Message-ID: <CAFULd4ai5mWTSB_9-G+brpJJ6_3VFtqdcFm-4YtoNbhskXNctA@mail.gmail.com>
Subject: Re: [PATCH v2] x86: Use xorl %0,%0 in __get_user_asm
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 27, 2020 at 10:14 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Thu, Aug 27, 2020 at 08:09:04PM +0200, Uros Bizjak wrote:
> > xorl %0,%0 is equivalent to xorq %0,%0 as both will zero the
> > entire register.  Use xorl %0,%0 for all operand sizes to avoid
> > REX prefix byte when legacy registers are used and to avoid size
> > prefix byte when 16bit registers are used.
> >
> > Zeroing the full register is OK in this use case.  xorl %0,%0 also
> > breaks register dependency chains, avoiding potential partial
> > register stalls with 8 and 16bit operands.
>
> No objections, but talking about stalls is more than slightly
> ridiculous - we'd just taken a #PF, failed there, flipped
> pt_regs %rip to fixup section, returned from fault and are
> about to fail whatever syscall that had been; a stall here
> is really not an issue...

Should I submit a v3 with the offending sentence removed, or could I
just ask a committer to remove it on the fly?

Uros.