Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Peter Rosin <peda@axentia.se>, Kukjin Kim <kgene@kernel.org>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Beniamin Bia <beniamin.bia@analog.com>,
        Tomasz Duszynski <tomasz.duszynski@octakon.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v2 13/18] iio: imu: inv_mpu6050: Simplify with
 dev_err_probe()
Thread-Topic: [PATCH v2 13/18] iio: imu: inv_mpu6050: Simplify with
 dev_err_probe()
Thread-Index: AQHWfKhP9EoLl2DH4kG3ErVWqrVkfKlNELaV
Date:   Fri, 28 Aug 2020 06:36:02 +0000
Message-ID: <MN2PR12MB439074B42FE1114B62189130C4520@MN2PR12MB4390.namprd12.prod.outlook.com>
References: <20200827192642.1725-1-krzk@kernel.org>,<20200827192642.1725-13-krzk@kernel.org>
In-Reply-To: <20200827192642.1725-13-krzk@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c529cfe-f087-4ab0-b116-08d84b1ca25a
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2020 06:36:02.4390
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 462b3b3b-e42b-47ea-801a-f1581aac892d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hGmIj4EPrsJmTxyinPjmc6sYmo35TCcJ/ItiWZli9WxNiSmzr9gdnqUkhmLW20lGlWlSrcwU5o4+esuLKWPO9OzYfmGQ5KR68z+i94pgFb8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4205
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-08-28_03:2020-08-27,2020-08-28 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=999 spamscore=0 priorityscore=1501 mlxscore=0 clxscore=1011
 suspectscore=0 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2006250000 definitions=main-2008280050
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

thanks for the patch.

Best regards,
JB

Reviewed-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>

________________________________________
From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> on =
behalf of Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, August 27, 2020 21:26
To: Jonathan Cameron; Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald-St=
adler; Peter Rosin; Kukjin Kim; Krzysztof Kozlowski; Michael Hennerich; Kev=
in Hilman; Neil Armstrong; Jerome Brunet; Martin Blumenstingl; Marek Vasut;=
 Maxime Coquelin; Alexandre Torgue; Beniamin Bia; Tomasz Duszynski; Linus W=
alleij; Andy Shevchenko; linux-iio@vger.kernel.org; linux-kernel@vger.kerne=
l.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.=
org; linux-amlogic@lists.infradead.org; linux-stm32@st-md-mailman.stormrepl=
y.com
Subject: [PATCH v2 13/18] iio: imu: inv_mpu6050: Simplify with dev_err_prob=
e()

 CAUTION: This email originated from outside of the organization. Please ma=
ke sure the sender is who they say they are and do not click links or open =
attachments unless you recognize the sender and know the content is safe.

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i=
nv_mpu6050/inv_mpu_core.c
index 3fee3947f772..18a1898e3e34 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1475,22 +1475,14 @@ int inv_mpu_core_probe(struct regmap *regmap, int i=
rq, const char *name,
        }

        st->vdd_supply =3D devm_regulator_get(dev, "vdd");
-       if (IS_ERR(st->vdd_supply)) {
-               if (PTR_ERR(st->vdd_supply) !=3D -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get vdd regulator %d\n",
-                               (int)PTR_ERR(st->vdd_supply));
-
-               return PTR_ERR(st->vdd_supply);
-       }
+       if (IS_ERR(st->vdd_supply))
+               return dev_err_probe(dev, PTR_ERR(st->vdd_supply),
+                                    "Failed to get vdd regulator\n");

        st->vddio_supply =3D devm_regulator_get(dev, "vddio");
-       if (IS_ERR(st->vddio_supply)) {
-               if (PTR_ERR(st->vddio_supply) !=3D -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get vddio regulator %d\n",
-                               (int)PTR_ERR(st->vddio_supply));
-
-               return PTR_ERR(st->vddio_supply);
-       }
+       if (IS_ERR(st->vddio_supply))
+               return dev_err_probe(dev, PTR_ERR(st->vddio_supply),
+                                    "Failed to get vddio regulator\n");

        result =3D regulator_enable(st->vdd_supply);
        if (result) {
--
2.17.1