Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1013926pxa;
        Fri, 28 Aug 2020 00:51:34 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxLgXssVwFE6fUSoPl4dpsdDxN9UHL1zLZFOnE+xpci7tt0bfY62bnaDWk+Eha97THQXoc1
X-Received: by 2002:a05:6402:b72:: with SMTP id cb18mr89904edb.299.1598601094253;
        Fri, 28 Aug 2020 00:51:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598601094; cv=none;
        d=google.com; s=arc-20160816;
        b=N7ymbnZQWa5SmTtqex82HkaSgFHutYqamCKhWta0LgujU7ZZq6NINgPZzL0mCJXjoY
         jtJrpUccMtbAOD3KmhpS/+VqgWUcJUx4s3iKYeBw4/EGUCo1Nk6a2H9NuiURpC3WdC11
         c8zxXSlPHbK6Rk2xL4JyUIfufXmi7xhHBXMbAL/PC12hAgpp+jnwWk1rOK6Nc24JphKf
         Rw+RETw0oGRnWxt4sWFn3aAN0UupVu0h2cg4LfP6s9qLixUct1YnUJcAnkL9veavAZse
         K4zIrG8+yFa+hhMpL7hfj+MRXEDC8Ovrv6iVsYDsyUDJ4RtHm1PngZsFAKi/c65JacM6
         tdAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Y/4A5EBWUA45JwNfKQf3/6dssv6HB9d+HsxhAXiEAsI=;
        b=u5EphSd+9vEZpri2ZUONUlV//Xw/TWLzvKwO4r0z/+pnt386tM1nj09X/3jm2SKLvG
         ytxJnzoA5U/+uF7SJv7mrBXeaGp44oBuvS1rQdsCrcuqzhXCFRqv0934JdOPgxC6sW02
         0I/PvV6Md5t/r5OrtAz01WFv0p38RegfM9MOuIlZmS4yDdkOmP/EvGnwEg7EBNNY65jX
         XkgQgAtJ3FejMgo8tC8l4I+szYYlYnGBaWrBL1Onpe1EGAxNFgO30bIG+TkB4vbrFEJM
         4cdqGuLDozVyy7FkOWWV7dPUBGxNXq1Hvq0rJeusgMf1X6RK0vp2T4m1j0fDoxIw6QnF
         03yQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=KOvtTNpG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id m18si123378ejk.743.2020.08.28.00.51.11;
        Fri, 28 Aug 2020 00:51:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=KOvtTNpG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728565AbgH1HsP (ORCPT <rfc822;linuxbirdgao@gmail.com>
        + 99 others); Fri, 28 Aug 2020 03:48:15 -0400
Received: from mail.kernel.org ([198.145.29.99]:42250 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728094AbgH1HsO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Aug 2020 03:48:14 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id AC9BC2078A;
        Fri, 28 Aug 2020 07:48:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1598600894;
        bh=wRcVqBDYNzDuiSshPZs2cXM/gGy3dQf2olqwI/4YQWk=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=KOvtTNpGyZ/bA7W7C4eRyBc3JDsu+jZEKA5Xp+3MiQMz8UOTMXiBjv5NQaTVfbPEz
         nYavUkuVh44jcDUJMJI/pxbf72uUckc/eGYsFhr+IDezg6t1gA1qudlKiINIoUCX9N
         Q49VPPAN2DQ3+WQ/7K289wo1vR1J7BH7CgIQ9pi0=
Date:   Fri, 28 Aug 2020 09:48:26 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     yanfei.xu@windriver.com
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h
Message-ID: <20200828074826.GA962117@kroah.com>
References: <20200825154421.5463-1-yanfei.xu@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200825154421.5463-1-yanfei.xu@windriver.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 25, 2020 at 11:44:21PM +0800, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
> 
> include/linux/usb.h also contains 'Hard limit' and 'Arbitrary limit'
> macro definitions in it, hence we can integrate these from config.c
> into include/linux/usb.h

Why?  No one uses these values outside of this .c file, so why put a
value in a global .h file?

Who else wants to use these values?  If something else needs it, then
sure, it could be moved, but until then, there's nothing wrong with the
existing code as-is from what I can tell.

thanks,

greg k-h