Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1027155pxa; Fri, 28 Aug 2020 01:19:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOzmFCsqe+kLBgIBFp/rmpCNGA/rQLmjgtVkwGXb+U8t06Z530JEuIVf1MwwlV5sYKPMSj X-Received: by 2002:aa7:c389:: with SMTP id k9mr691464edq.220.1598602776503; Fri, 28 Aug 2020 01:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598602776; cv=none; d=google.com; s=arc-20160816; b=KeaDtQ622S24SurUWFPmcbn7oImNq2j8t4qZu4Q2NdkotkQ66b1gMa+vNLRSe5+vh+ dKuhk4fDB3aq31rtbdrOXJ3ze9DAgSt3XUr97Qhe3sgKgnXe01Jj1eDX85Ot8NTS2W31 bVRJJ4rnXJbmQPU/V8fFPXR3IcsVDo+jnw0KfepSSvmtHljvg2ZmIoJ/TmknvNXO3Lub pSvFt89K5FZQJLvFNqMdgGGUs4P7GxZIHYaVKLRPMk7TR20s2cERXHo5fXERfIKLudUH 73iCCZyDFhEDyI+v1Jc/EdG3KBzI1TcK3XXGdeq4CP3ziHWUkHVBkq/Rh1f21hMB+ZNA eeOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pSHaNmr8+2nayE4WsNmj86aHekSOM5bkcuGA8zU5cI8=; b=cAa1fR74wK6lJj5VuSVoSVENzsUifdzdB5QlgD4zeUjWpMIagnJJ1m9XIc/Tmxu3vg LjMkPsMxtEZG99GbUD3+lSfW4u02RuFmFrefSxFVxGfeB23qsFuit9hcE6iQS3YMkB70 pt4x3pGsEd5xDOyaKhbZRfWt4BEE9fIUwfmcn4fDmp32O//PwV+TFADX2io0CH8pZlnh QBH548docf+vYolWWnUzYZmAdd10GKkfk0qiKvb4KzS4GM5YLDaH/hyNb2ifwgy8h1G/ RG7lD1EV51RlDb5mMpw5QM22DpWfBQVlLWxezt/NWBiODvhZ3ppUwa9+PhopTkeYfSBY bw4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nJsPSQJE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si194787ejg.156.2020.08.28.01.19.14; Fri, 28 Aug 2020 01:19:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nJsPSQJE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgH1ISj (ORCPT + 99 others); Fri, 28 Aug 2020 04:18:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:55962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbgH1ISi (ORCPT ); Fri, 28 Aug 2020 04:18:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6796E20776; Fri, 28 Aug 2020 08:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598602718; bh=73FhKi65XqUq6hi2IN55t0uqmSmIWYCAODCd/AinFj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nJsPSQJEodX0ILukgCu32ZmCyFPd04361JBvas+tLcZqSeuXnBYQE6EWhzOZiCBot V+CSUzgLhcKl2HAP+JS+kdHG0DHJXBDgm52im535Wzdhvp5YDXJuMS0qpX6oJEJEvp QOsXVXqsaMOdyZmCeyfd2EFKXoSsP19IZMPaIATg= Date: Fri, 28 Aug 2020 10:18:49 +0200 From: Greg Kroah-Hartman To: Paras Sharma Cc: Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic Message-ID: <20200828081849.GC1007729@kroah.com> References: <1597131794-1076-1-git-send-email-parashar@codeaurora.org> <20200811082330.GC113774@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200811082330.GC113774@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 11, 2020 at 10:23:30AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 11, 2020 at 01:13:14PM +0530, Paras Sharma wrote: > > The current implementation reduces the sampling rate by half > > if qup HW version greater is than 2.5 by checking if the geni > > SE major version is greater than 2 and geni SE minor version > > is greater than 5. > > > > This implementation fails when the version is 3 or greater. > > > > Hence by adding the another check for geni SE major version, > > this problem can be solved. > > > > Signed-off-by: Paras Sharma > > --- > > drivers/tty/serial/qcom_geni_serial.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Should this go to stable kernels? If so, how far back? What git commit > id is this patch fixing? And if so, why not put a Fixes: tag on this as > well? Dropped from my review queue due to lack of response, please fix up and resend when you wish to have it reviewed again... greg k-h