Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1043358pxa; Fri, 28 Aug 2020 01:55:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvGdxto5OcTTsuK6Zz2KH0+RDEkoEdLYsU2zvvTnJ9PLr/uOSr6uvwfjKG6VWVSU4MaBio X-Received: by 2002:a17:906:72c7:: with SMTP id m7mr732557ejl.64.1598604922918; Fri, 28 Aug 2020 01:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598604922; cv=none; d=google.com; s=arc-20160816; b=WCTqcWDid6WOTZL++WqhZiCel0A2HNP4/5v+DlieZMBxDUTcpu6h4Fq5gJi9KhuHae c/Eh1DukdMBFEzh+TL026tEH8gDtJxsc0BY6NiWBf1Hsc7GgZzaZ0/JqiBu0kVvKjjNC bepdPsmnhGMhKUqnre1HKeper4QSBLYTGMNESqEHdmXii1UV0abjvBja8AEpC8gBaMcb k7rMHuJBwbKdP3ijQc9ZEfaVb8XDbmzCIqmxkVFi0ouT2KHlsLQdjI+WKJvwWZYglkTO tnsxqnTsX83KBfHxWr584NB+REm1w0dPDJQhdVQxy1sVmv16Vk3G9SQWY19wEr2tfKuL y37A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=vnx68nadQclGIeDhGr6pWSbN+pnG01fFisH9ohM4NOU=; b=mbT1xLjLtomhAMALEdw1dOc/anGdqQgaSi2oq7ioE/Z4m8B27EJZsf4+JXoI7XCRBV l7K7aQzRfQUm6wNFm9xp2yd1jIc3ksAjwqbbx7CsI2KnCX5Q7IPZrRnAu+bopIiHzGJj 3aIEeLn6rPCmcIQLiZuPLfsYefEDOnXaFJe9Ictdq/T4TtnhTA3nx0Bh8TVpFEBeAxRZ odXSlEBbEy2gDJwJRGEoU57oNuWn2ABPPHYdmMjTHzoQx+y/SrT1Mg5bPTseXYfhHexo M53Eb+3VbE2FjHjD77PJAEtvRgq2lPQjXg3NOxkeAX7i7FGxcJNuWsPjamzCh6FpRO/3 atzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si249857ejx.11.2020.08.28.01.54.59; Fri, 28 Aug 2020 01:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728690AbgH1IyQ (ORCPT + 99 others); Fri, 28 Aug 2020 04:54:16 -0400 Received: from mga17.intel.com ([192.55.52.151]:49188 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728357AbgH1IyP (ORCPT ); Fri, 28 Aug 2020 04:54:15 -0400 IronPort-SDR: R4bqAzZeiDQ9wovcXGVwQWq0ojTAG6FuznRJ1hEa7A0W2e/c0lMak21syIrNDKEySCu68mucFU WGTeCLUxRduA== X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="136697480" X-IronPort-AV: E=Sophos;i="5.76,363,1592895600"; d="scan'208";a="136697480" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 01:54:15 -0700 IronPort-SDR: LZE/KZPpjd2cGa1IAhn+L2N0biOQvd/G2yIcuYUE0ExINP7VUMP5/LqiDqgpw0J6AH0JcYbIRr WpV0EJW4NkmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,363,1592895600"; d="scan'208";a="332483483" Received: from chenyi-pc.sh.intel.com ([10.239.159.72]) by fmsmga002.fm.intel.com with ESMTP; 28 Aug 2020 01:54:13 -0700 From: Chenyi Qiang To: Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Xiaoyao Li Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] Fix nested VMX controls MSRs Date: Fri, 28 Aug 2020 16:56:17 +0800 Message-Id: <20200828085622.8365-1-chenyi.qiang@intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first three patches fix a issue for the nested VMX controls MSRs. The issue happens when I use QEMU to run nested VM. The VM_{ENTRY, EXIT}_LOAD_IA32_PERF_GLOBAL_CTRL and VM_{ENTRY_LOAD, EXIT_CLEAR}_BNDCFGS in L1 MSR_IA32_VMX_TRUE_{ENTRY, EXIT}_CTLS MSR are always cleared regardless of whether it supports in L1. This is because QEMU gets the nested VMX MSRs from vmcs_config.nested_vmx_msrs which doesn't expose these two fields. Then, when QEMU initializes the features MSRs after SET_CPUID, it will override the nested VMX MSR values which has been updated according to guest CPUID during SET_CPUID. This patch series just expose the missing fields in nested VMX {ENTRY, EXIT} controls MSR and adds the support to update nested VMX MSRs after set_vmx_msrs. The last two patches are a minor fix and cleanup. Chenyi Qiang (5): KVM: nVMX: Fix VMX controls MSRs setup when nested VMX enabled KVM: nVMX: Verify the VMX controls MSRs with the global capability when setting VMX MSRs KVM: nVMX: Update VMX controls MSR according to guest CPUID after setting VMX MSRs KVM: nVMX: Fix the update value of nested load IA32_PERF_GLOBAL_CTRL control KVM: nVMX: Simplify the initialization of nested_vmx_msrs arch/x86/kvm/vmx/nested.c | 79 +++++++++++++++++++++++++++------------ arch/x86/kvm/vmx/vmx.c | 9 +++-- 2 files changed, 62 insertions(+), 26 deletions(-) -- 2.17.1