Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 Aug 2020 12:31:06 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jim Cromie <jim.cromie@gmail.com>
Cc:     jbaron@akamai.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"
Message-ID: <20200828103106.GE1470435@kroah.com>
References: <20200825173339.2082585-1-jim.cromie@gmail.com>
 <20200825173339.2082585-4-jim.cromie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200825173339.2082585-4-jim.cromie@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 25, 2020 at 11:33:39AM -0600, Jim Cromie wrote:
>  14775b049642 dyndbg: accept query terms like file=bar and module=foo
> 

What does that above line mean???

> That commit broke on a tokenization modality where a word could start
> with a quote, but couldnt continue with one.  So the above would
> tokenize as 'format="foo' and 'bar"', and fail hard.
> 
> This commit fixes the tokenizer by terminating an unquoted token on
> the '=', avoiding that problem.  And since ddebug-parse-query will
> never see a combined 'keyword=value', revert those parts of the
> previous commit.
> 
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>

Again, a Fixes: tag, and fix up your text above please.

Can you do this and send a v3 of this series and any other pending
dyndbg fixes for 5.9-final?

thanks,

greg k-h