Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1103999pxa; Fri, 28 Aug 2020 03:58:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3CiG52TC7eDyKUXQB0cIgTBlFXynybXCO+UBPKVN27vsq5kG131rNHU8yVH2u52APlFDC X-Received: by 2002:a17:906:6853:: with SMTP id a19mr1112661ejs.506.1598612298740; Fri, 28 Aug 2020 03:58:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598612298; cv=none; d=google.com; s=arc-20160816; b=ssJLOdfy/QZrkLB8hXqyUhozxr57RWjCB1pDkBGBxADS1zQRCEqOLXMYmTaixh/VYC t6CpeviuRV/XXTwDTxh8cLyyovbgSGDRIaM/P6CICZnTyijrbXFdlfGSdu908+4dPI1D LsYOnf7hqcPmK9tioXzS5PzVRTcD6+wH7RnTJtluVH+921JLOIRBTbjV+R3TUOw8x7YK bLzUwJuVkL3PMgVFslNMNYpiJVFcpXrI1O4ON/spO6i9SYmjYYDIwl4ireZyi7CYd7B3 ynxqci1p8UQN9mlrzRyi5/4jlgoxuCAO+xkmkvAidvivEwBpQujqJ0RZQvk4qdjxSOs6 umVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=e6iXM6C5sJ3FBz3LIMthXRBWXK9iTp3RhCVsBFe2ot4=; b=GG6rbXN3xFohThb76byEf+lmNy4esOaG4xnzpYLaqKnodEdc2J23olQSt2oPdY6GEj 7nJRQ9rYMYt4EyufISKAK3YkOAfdJvQLOr+30/8otYxc+w7M3KjufNnTEIPcp2YuzAl4 tW9VIOqxlYYAcNq8tquYgxtuQPi4luuYYGM/ORsPmumr0iBe5qpVpNZo3R/i66dm8/Jp mGXmVoIiE6y1v2ahJ+AlJAIwKxSszZKdsmwBLt+4wEUshlMeLWhtKmJiMMnSmkzWcgmn gBPZWuvWrkfBDrujcKsq8RMJze3yseUu8T1t/lUll3u8Ccn0n24KpmIB+hDFGLiWnRs2 B1Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="YrriV/Zp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si343856edv.367.2020.08.28.03.57.55; Fri, 28 Aug 2020 03:58:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="YrriV/Zp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729178AbgH1K4P (ORCPT + 99 others); Fri, 28 Aug 2020 06:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729123AbgH1Kx3 (ORCPT ); Fri, 28 Aug 2020 06:53:29 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE51FC061232 for ; Fri, 28 Aug 2020 03:53:08 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id k20so484885wmi.5 for ; Fri, 28 Aug 2020 03:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=e6iXM6C5sJ3FBz3LIMthXRBWXK9iTp3RhCVsBFe2ot4=; b=YrriV/ZpxSVeR1zNRjbVh0hZsksEyHhLgrOl31e0w2SDO/H8Bjh/dcb34Qq3dSVt8h uiOhYVGDo6GywbGQ453rFe6xo1Yo4hMj+KVM1hv/A6Wm1QY6rBkeJ7BrYrrj4p7aUjn1 BO/Cn7KyMnoVy5Ka6E+TfXreZM2tII4pyNxLPM2QKyIQ8+xV541NqaHAPOYwePYBuTbX sD+tbJf0KJvFjKoikZg7/vVmIdZQctlcrnzpPzhWe0x0ApPVnwsSuTwYgFVJHE8MmpBy M12aXSVVQjbNuvEwKf2gUCy7mVf7wXrDAaKk7Tp/hz3zPA7ndKo2EXfLC3QcA+wayEfv utTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=e6iXM6C5sJ3FBz3LIMthXRBWXK9iTp3RhCVsBFe2ot4=; b=TEsO7R4qCRNcAKRjlPXxsDsrlW6ZMBl+l+olxDbULbM0nxwB9GMBeWotIwAeeQwKyh R4EiBgpCWYVlZHu6vseIGmjC5OBJ1A7wUTjUlEwx491AgS5kJ0drDG5SihY6LWSlSa9q d96XtYrhZ4a//TRxH0L8WNTqZ6kJNwx1SbSEgNjKzSAsWMDnQ/v68apD8LftGnFqv3ob VRvXkYgLtIpEHE9qlv6F/7PUwqFq8xmT2WR/eslqZm32PQqPIe+on1xaBDLLh76xOkBF zfTKhGyENzA3xKGuvlxjFYc56Tx5cm6Gqmc1e5/erUgDc0an1LY8B0fScbQggJ5jUguj vvjg== X-Gm-Message-State: AOAM531DMhBu6Fe1oXSB5lgR9sR6p4tvukNngQJ0Ry/2GgH0A5PqjCXW bfXMESPAhCQLXhnaCELeJEJteQ== X-Received: by 2002:a1c:a506:: with SMTP id o6mr1019921wme.3.1598611987242; Fri, 28 Aug 2020 03:53:07 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id r129sm1531390wmr.40.2020.08.28.03.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 03:53:06 -0700 (PDT) Date: Fri, 28 Aug 2020 11:53:04 +0100 From: Lee Jones To: "David E. Box" Cc: dvhart@infradead.org, andy@infradead.org, bhelgaas@google.com, alexander.h.duyck@linux.intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH V5 2/3] mfd: Intel Platform Monitoring Technology support Message-ID: <20200828105304.GS1826686@dell> References: <20200819180255.11770-1-david.e.box@linux.intel.com> <20200819180255.11770-3-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200819180255.11770-3-david.e.box@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020, David E. Box wrote: > Intel Platform Monitoring Technology (PMT) is an architecture for > enumerating and accessing hardware monitoring facilities. PMT supports > multiple types of monitoring capabilities. This driver creates platform > devices for each type so that they may be managed by capability specific > drivers (to be introduced). Capabilities are discovered using PCIe DVSEC > ids. Support is included for the 3 current capability types, Telemetry, > Watcher, and Crashlog. The features are available on new Intel platforms > starting from Tiger Lake for which support is added. > > Also add a quirk mechanism for several early hardware differences and bugs. > For Tiger Lake, do not support Watcher and Crashlog capabilities since they > will not be compatible with future product. Also, fix use a quirk to fix > the discovery table offset. > > Co-developed-by: Alexander Duyck > Signed-off-by: Alexander Duyck > Signed-off-by: David E. Box > Reviewed-by: Andy Shevchenko > --- > MAINTAINERS | 5 + > drivers/mfd/Kconfig | 10 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/intel_pmt.c | 220 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 236 insertions(+) > create mode 100644 drivers/mfd/intel_pmt.c For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog