Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200827065355.15177-1-himadrispandya@gmail.com> <5dd266df-33cf-f351-7253-33a7f589cd56@gmail.com>
In-Reply-To: <5dd266df-33cf-f351-7253-33a7f589cd56@gmail.com>
From:   Himadri Pandya <himadrispandya@gmail.com>
Date:   Fri, 28 Aug 2020 16:36:22 +0530
Message-ID: <CAOY-YV=Ad6E2nbJ-m9SHW4zuet9VeDMLw9M-VtTebp0Far-8SA@mail.gmail.com>
Subject: Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Greg KH <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 27, 2020 at 1:28 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
>
> Hello!
>
> On 27.08.2020 9:53, Himadri Pandya wrote:
>
> > The buffer size is 2 Bytes and we expect to receive the same amount of
> > data. But sometimes we receive less data and run into uninit-was-stored
> > issue upon read. Hence modify the error check on the return value to match
> > with the buffer size as a prevention.
> >
> > Reported-and-tested by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com
> > Signed-off-by: Himadri Pandya <himadrispandya@gmail.com>
> > ---
> >   drivers/net/usb/asix_common.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> > index e39f41efda3e..7bc6e8f856fe 100644
> > --- a/drivers/net/usb/asix_common.c
> > +++ b/drivers/net/usb/asix_common.c
> > @@ -296,7 +296,7 @@ int asix_read_phy_addr(struct usbnet *dev, int internal)
> >
> >       netdev_dbg(dev->net, "asix_get_phy_addr()\n");
> >
> > -     if (ret < 0) {
> > +     if (ret < 2) {
> >               netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
>
>     Hm... printing possibly negative values as hex?
>

Yeah. That's odd! Fixing it.

Thanks,
Himadri

> [...]
>
> MBR, Sergei