Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1121907pxa; Fri, 28 Aug 2020 04:29:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwMTlJNNDXgUQoanBzBE0dkFBiebY2t4puFjkO3dvygwo8CG4qVHRExC5FBIUE/c8w3Bui X-Received: by 2002:a05:6402:1427:: with SMTP id c7mr1387209edx.245.1598614164894; Fri, 28 Aug 2020 04:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598614164; cv=none; d=google.com; s=arc-20160816; b=C9vM2CqGqdVn9Gf4mSFCJP+z9GQCLmGqj6QraIU8RX1ojbtudXXyuBAvr3sH8JVcxJ /mwHwBklsAxzB5wPtwIy0eyOUeU8x9Zel7M4nA003kDx1ozUoLXW+OyWoaq6xaSp3hdg hSZrVK4Vx8jUBIy03a/kPr8RiY1jfp5s1fwI4mKClkq7oS/GqLAhIOIjVVdxl9ixs1V/ 6PBaXkVTHnGwfcgyLzbGvR+XKXzxXx3of50HIYl46MSZDTrCMIi0eSIsJ4PG6/BbSBLO gYWXPgM7VkCqXZfz4VkolqQZoFfk991jeku3P17PRqkISP6D4Od9UHlh2z6vGywCaiUe LTEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vcVCnDfXCrpqdXroEZsRpzoOz05edQsOh2pIT4QY95E=; b=AVHJgmF+ztXxTxWkPyYmVZOvciy3uGoFem4yRBESejdX5f4z+ER/oZZOC+9LbUkmJd ptmJ5MgFcszvCe7b9cMIP3FjVCPl7YJieXvnWPVk+98ABZtjbPXbaHlcl01HdXahDr1y JfBn5xDCWtXN9pO65za9mxTCBXdHTP1U6/IVos3PvIYAwIAEVl470o02XMJ1buuFDEB9 pkupHVqw5A8SeTbRc5AzGNoRgnRH4l3BbE6nLjb0BfrqPQhzgH0hOcpiQkVNNyMXiR/C 8hIG/pdL9Kfior1M8qYl9cU+969BTJE6nh9Xf3AvVlXfh2O116aHy8rbgbQsGPTolzX9 wR+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d4u9wTJI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay7si393317edb.183.2020.08.28.04.29.02; Fri, 28 Aug 2020 04:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d4u9wTJI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729202AbgH1L22 (ORCPT + 99 others); Fri, 28 Aug 2020 07:28:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27244 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729198AbgH1L2H (ORCPT ); Fri, 28 Aug 2020 07:28:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598614084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vcVCnDfXCrpqdXroEZsRpzoOz05edQsOh2pIT4QY95E=; b=d4u9wTJIhYCrrklCfYatvJ9ry1ZYxNLYhLyL6BtFCNGqMG38xjtTiIXHcUkdnk4bItdP99 Y8uD9oC2y7fCfjnIJ4gM3FyzqqZTpuUiLcxQi4xIwGaqaIYNluhdFIdG1DudZaALBl/ZHg YdFCHwGUW9pV/AB0uQrtaxKH4A7Hel4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-KhS13XkaMoyyK4EiseYxow-1; Fri, 28 Aug 2020 07:28:02 -0400 X-MC-Unique: KhS13XkaMoyyK4EiseYxow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43BEF64090; Fri, 28 Aug 2020 11:28:01 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCF325D9F3; Fri, 28 Aug 2020 11:28:00 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C877C9C87; Fri, 28 Aug 2020 13:27:59 +0200 (CEST) Date: Fri, 28 Aug 2020 13:27:59 +0200 From: Gerd Hoffmann To: Jiri Slaby Cc: dri-devel@lists.freedesktop.org, David Airlie , open list , "open list:VIRTIO GPU DRIVER" , 1882851@bugs.launchpad.net Subject: Re: [PATCH 1/2] drm/virtio: fix unblank Message-ID: <20200828112759.rmeeh5bonrewiqte@sirius.home.kraxel.org> References: <20200818072511.6745-1-kraxel@redhat.com> <20200818072511.6745-2-kraxel@redhat.com> <88ae71c2-c3ed-e0e4-e62c-bdf9d6534f2a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88ae71c2-c3ed-e0e4-e62c-bdf9d6534f2a@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 09:24:40AM +0200, Jiri Slaby wrote: > On 18. 08. 20, 9:25, Gerd Hoffmann wrote: > > When going through a disable/enable cycle without changing the > > framebuffer the optimization added by commit 3954ff10e06e ("drm/virtio: > > skip set_scanout if framebuffer didn't change") causes the screen stay > > blank. Add a bool to force an update to fix that. > > > > v2: use drm_atomic_crtc_needs_modeset() (Daniel). > > > > Cc: 1882851@bugs.launchpad.net > > Fixes: 3954ff10e06e ("drm/virtio: skip set_scanout if framebuffer didn't change") > > Signed-off-by: Gerd Hoffmann > > Tested-by: Jiri Slaby Ping. Need an ack or an review to merge this. thanks, Gerd