Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1219055pxa; Fri, 28 Aug 2020 07:04:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzucKigXavCcxtGtz/12RYJf844OANcovhHOl36JSF8h/YXxPaXdGB2SwMVsOT5NAyJes/5 X-Received: by 2002:a05:6402:342:: with SMTP id r2mr2100851edw.353.1598623470242; Fri, 28 Aug 2020 07:04:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598623470; cv=none; d=google.com; s=arc-20160816; b=DFC9CBUl2Qb1M+tSqhEMCuvo580pRNohfzLGFroCQpSH1MkL4srZFZ72tU8mTpbZT9 rUXmaQbLDyReK5YpWhPYYx+ng7BhIQzbgByKBJ5NTML8EBMmH56ROTv57dAozUPzECkF ornvjr6/kfU8ub5rSjT5Uwdh5r3gHq6qed6BcDttDSbUyVpNAszON8oN8xgqobhIiaz8 gfnzvXbXOKBUWFbqxaz6Y8WoBq6bitAedvDc2SnTni2/kHBycSU5jrNvScHeQ5HstCzY 8euno/UXDYOjbf7UCAV4RSY688H0XtDtfu4YeO9B8iDeexAhEaPQW2I2PzNTnUNta/xu jlsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject; bh=ahw/B8u6uYA5iiRfUKeDFn2R7CyBluhOvRJcID3cFbE=; b=IdC/wh5aDS29jhO2VvKjamNI4fBiyxmwTFavt/EI8ogjnLdoLdhVVZrsI3S2SHeBoU D7Ef2toC0XtX9Tv6GhPTLYNNo0TMvfHCgTCzl/jO/g432TA8lqXGLVNDx9BvLarjAUL7 Jjd6dvKL+yn+9QuxsA3mP7cJdPUBpG9ThLehM+Tmz1PCykpp3XdfR0nCT+vmHmvCxCHY jS+v/cYC+HHcgQQJzztPsiyF0ampyo6PkDonre+rB7qdsA4ddXoOQfnQD1F8lqJ1Nq7f vIodFLTvHyazXMN5Fs76itZUPBhCWBx48BQSOl9uWjuaQJ8zZ+7spmo0xkvJpjm+ofK1 y2qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o6si661155ejb.289.2020.08.28.07.04.06; Fri, 28 Aug 2020 07:04:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgH1OCd (ORCPT + 99 others); Fri, 28 Aug 2020 10:02:33 -0400 Received: from foss.arm.com ([217.140.110.172]:50010 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgH1OAY (ORCPT ); Fri, 28 Aug 2020 10:00:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E22081FB; Fri, 28 Aug 2020 07:00:10 -0700 (PDT) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82F923F71F; Fri, 28 Aug 2020 07:00:09 -0700 (PDT) Subject: Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node To: Florian Fainelli , Rob Herring , devicetree@vger.kernel.org Cc: Thomas Gleixner , Daniel Lezcano , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200826183805.19369-1-andre.przywara@arm.com> <20200826183805.19369-4-andre.przywara@arm.com> <44992125-7eaa-f35b-3344-16ae0d48f646@arm.com> <3a3ce1d4-ddd5-f000-9cf0-5d06e2cc2047@gmail.com> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Autocrypt: addr=andre.przywara@arm.com; prefer-encrypt=mutual; keydata= xsFNBFNPCKMBEAC+6GVcuP9ri8r+gg2fHZDedOmFRZPtcrMMF2Cx6KrTUT0YEISsqPoJTKld tPfEG0KnRL9CWvftyHseWTnU2Gi7hKNwhRkC0oBL5Er2hhNpoi8x4VcsxQ6bHG5/dA7ctvL6 kYvKAZw4X2Y3GTbAZIOLf+leNPiF9175S8pvqMPi0qu67RWZD5H/uT/TfLpvmmOlRzNiXMBm kGvewkBpL3R2clHquv7pB6KLoY3uvjFhZfEedqSqTwBVu/JVZZO7tvYCJPfyY5JG9+BjPmr+ REe2gS6w/4DJ4D8oMWKoY3r6ZpHx3YS2hWZFUYiCYovPxfj5+bOr78sg3JleEd0OB0yYtzTT esiNlQpCo0oOevwHR+jUiaZevM4xCyt23L2G+euzdRsUZcK/M6qYf41Dy6Afqa+PxgMEiDto ITEH3Dv+zfzwdeqCuNU0VOGrQZs/vrKOUmU/QDlYL7G8OIg5Ekheq4N+Ay+3EYCROXkstQnf YYxRn5F1oeVeqoh1LgGH7YN9H9LeIajwBD8OgiZDVsmb67DdF6EQtklH0ycBcVodG1zTCfqM AavYMfhldNMBg4vaLh0cJ/3ZXZNIyDlV372GmxSJJiidxDm7E1PkgdfCnHk+pD8YeITmSNyb 7qeU08Hqqh4ui8SSeUp7+yie9zBhJB5vVBJoO5D0MikZAODIDwARAQABzS1BbmRyZSBQcnp5 d2FyYSAoQVJNKSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT7CwXsEEwECACUCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheABQJTWSV8AhkBAAoJEAL1yD+ydue63REP/1tPqTo/f6StS00g NTUpjgVqxgsPWYWwSLkgkaUZn2z9Edv86BLpqTY8OBQZ19EUwfNehcnvR+Olw+7wxNnatyxo D2FG0paTia1SjxaJ8Nx3e85jy6l7N2AQrTCFCtFN9lp8Pc0LVBpSbjmP+Peh5Mi7gtCBNkpz KShEaJE25a/+rnIrIXzJHrsbC2GwcssAF3bd03iU41J1gMTalB6HCtQUwgqSsbG8MsR/IwHW XruOnVp0GQRJwlw07e9T3PKTLj3LWsAPe0LHm5W1Q+euoCLsZfYwr7phQ19HAxSCu8hzp43u zSw0+sEQsO+9wz2nGDgQCGepCcJR1lygVn2zwRTQKbq7Hjs+IWZ0gN2nDajScuR1RsxTE4WR lj0+Ne6VrAmPiW6QqRhliDO+e82riI75ywSWrJb9TQw0+UkIQ2DlNr0u0TwCUTcQNN6aKnru ouVt3qoRlcD5MuRhLH+ttAcmNITMg7GQ6RQajWrSKuKFrt6iuDbjgO2cnaTrLbNBBKPTG4oF D6kX8Zea0KvVBagBsaC1CDTDQQMxYBPDBSlqYCb/b2x7KHTvTAHUBSsBRL6MKz8wwruDodTM 4E4ToV9URl4aE/msBZ4GLTtEmUHBh4/AYwk6ACYByYKyx5r3PDG0iHnJ8bV0OeyQ9ujfgBBP B2t4oASNnIOeGEEcQ2rjzsFNBFNPCKMBEACm7Xqafb1Dp1nDl06aw/3O9ixWsGMv1Uhfd2B6 it6wh1HDCn9HpekgouR2HLMvdd3Y//GG89irEasjzENZPsK82PS0bvkxxIHRFm0pikF4ljIb 6tca2sxFr/H7CCtWYZjZzPgnOPtnagN0qVVyEM7L5f7KjGb1/o5EDkVR2SVSSjrlmNdTL2Rd zaPqrBoxuR/y/n856deWqS1ZssOpqwKhxT1IVlF6S47CjFJ3+fiHNjkljLfxzDyQXwXCNoZn BKcW9PvAMf6W1DGASoXtsMg4HHzZ5fW+vnjzvWiC4pXrcP7Ivfxx5pB+nGiOfOY+/VSUlW/9 GdzPlOIc1bGyKc6tGREH5lErmeoJZ5k7E9cMJx+xzuDItvnZbf6RuH5fg3QsljQy8jLlr4S6 8YwxlObySJ5K+suPRzZOG2+kq77RJVqAgZXp3Zdvdaov4a5J3H8pxzjj0yZ2JZlndM4X7Msr P5tfxy1WvV4Km6QeFAsjcF5gM+wWl+mf2qrlp3dRwniG1vkLsnQugQ4oNUrx0ahwOSm9p6kM CIiTITo+W7O9KEE9XCb4vV0ejmLlgdDV8ASVUekeTJkmRIBnz0fa4pa1vbtZoi6/LlIdAEEt PY6p3hgkLLtr2GRodOW/Y3vPRd9+rJHq/tLIfwc58ZhQKmRcgrhtlnuTGTmyUqGSiMNfpwAR AQABwsFfBBgBAgAJBQJTTwijAhsMAAoJEAL1yD+ydue64BgP/33QKczgAvSdj9XTC14wZCGE U8ygZwkkyNf021iNMj+o0dpLU48PIhHIMTXlM2aiiZlPWgKVlDRjlYuc9EZqGgbOOuR/pNYA JX9vaqszyE34JzXBL9DBKUuAui8z8GcxRcz49/xtzzP0kH3OQbBIqZWuMRxKEpRptRT0wzBL O31ygf4FRxs68jvPCuZjTGKELIo656/Hmk17cmjoBAJK7JHfqdGkDXk5tneeHCkB411p9WJU vMO2EqsHjobjuFm89hI0pSxlUoiTL0Nuk9Edemjw70W4anGNyaQtBq+qu1RdjUPBvoJec7y/ EXJtoGxq9Y+tmm22xwApSiIOyMwUi9A1iLjQLmngLeUdsHyrEWTbEYHd2sAM2sqKoZRyBDSv ejRvZD6zwkY/9nRqXt02H1quVOP42xlkwOQU6gxm93o/bxd7S5tEA359Sli5gZRaucpNQkwd KLQdCvFdksD270r4jU/rwR2R/Ubi+txfy0dk2wGBjl1xpSf0Lbl/KMR5TQntELfLR4etizLq Xpd2byn96Ivi8C8u9zJruXTueHH8vt7gJ1oax3yKRGU5o2eipCRiKZ0s/T7fvkdq+8beg9ku fDO4SAgJMIl6H5awliCY2zQvLHysS/Wb8QuB09hmhLZ4AifdHyF1J5qeePEhgTA+BaUbiUZf i4aIXCH3Wv6K Organization: ARM Ltd. Message-ID: <60929faf-fdcf-a434-1acb-c77f92818955@arm.com> Date: Fri, 28 Aug 2020 14:59:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/2020 21:55, Florian Fainelli wrote: > On 8/26/20 11:59 AM, Florian Fainelli wrote: >> On 8/26/20 11:53 AM, André Przywara wrote: >>> On 26/08/2020 19:42, Florian Fainelli wrote: Hi Florian, >>> >>> Hi, >>> >>>> On 8/26/20 11:38 AM, Andre Przywara wrote: >>>>> The DT binding for SP804 requires to have an "arm,primecell" compatible >>>>> string. >>>>> Add this string so that the Linux primecell bus driver picks the device >>>>> up and activates the clock. >>>>> >>>>> Signed-off-by: Andre Przywara >>>> >>>> The commit subject should be: >>>> >>>> ARM: dts: NSP: Fix SP804 compatible node >>>> >>>> and we should probably have a Fixes tag that is: >>>> >>>> Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT") >>>> >>>> Could you please re-submit with those things corrected? Thanks >>> >>> Sure, will include that in a v2. >>> >>> Out of curiosity, do you have the hardware and can check the impact that >>> has? >> >> I have the hardware and could run some tests if you would like. >> >>> Not sure we actually create the device without the primecell compatible? >>> Or is the sp804 an exception here, compared to the other AMBA devices >>> (SP805, PL011)? >> >> No idea, I have never used those timers personally, and I doubt that >> anybody besides me within broadcom and hobbyists actually care about NSP >> these days. > > Seems to be working fine for me with your patch applied, it probes: > > # dmesg | grep sp804 > [ 0.035363] clocksource: arm,sp804: mask: 0xffffffff max_cycles: > 0xffffffff, max_idle_ns: 15290083572 ns > > and it is usable: > > # cat clocksource0/available_clocksource > arm_global_timer arm,sp804 > > and appears to work: > > # echo "arm,sp804" > clocksource0/current_clocksource > [ 105.108547] clocksource: Switched to clocksource arm,sp804 > > # date; sleep 5; date > Thu Jan 1 00:01:51 UTC 1970 > Thu Jan 1 00:01:56 UTC 1970 > > Feel free to add Tested-by: Florian Fainelli in > your v2, thanks André! Wow, thanks a lot for this test! Sending out a v2 in a minute. Cheers, Andre