Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arvind Sankar <nivedita@alum.mit.edu>
Date:   Fri, 28 Aug 2020 11:09:28 -0400
To:     Joerg Roedel <joro@8bytes.org>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>, x86@kernel.org,
        Joerg Roedel <jroedel@suse.de>, hpa@zytor.com,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Jiri Slaby <jslaby@suse.cz>,
        Dan Williams <dan.j.williams@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Juergen Gross <jgross@suse.com>,
        Kees Cook <keescook@chromium.org>,
        David Rientjes <rientjes@google.com>,
        Cfir Cohen <cfir@google.com>,
        Erdem Aktas <erdemaktas@google.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mike Stunes <mstunes@vmware.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Martin Radev <martin.b.radev@gmail.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v6 13/76] x86/boot/compressed/64: Add IDT Infrastructure
Message-ID: <20200828150928.GA1203097@rani.riverdale.lan>
References: <20200824085511.7553-1-joro@8bytes.org>
 <20200824085511.7553-14-joro@8bytes.org>
 <20200827152657.GA669574@rani.riverdale.lan>
 <20200828121226.GC13881@8bytes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200828121226.GC13881@8bytes.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 28, 2020 at 02:12:26PM +0200, Joerg Roedel wrote:
> Hi Arvind,
> 
> On Thu, Aug 27, 2020 at 11:26:57AM -0400, Arvind Sankar wrote:
> > On Mon, Aug 24, 2020 at 10:54:08AM +0200, Joerg Roedel wrote:
> > > +	pushq	%rsi
> > > +	call	load_stage1_idt
> > > +	popq	%rsi
> > > +
> > 
> > Do we need the functions later in the series or could this just use lidt
> > directly?
> 
> The function also sets up the actual IDT entries in the table before
> doing the lidt, so this needs to be a call to a C function. Setting up
> IDT entries in assembly does not result in readable code.
> 

Ah ok, I missed that in the later patches.

Thanks.