Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1272502pxa; Fri, 28 Aug 2020 08:17:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGB/zl/S17bBs5b9oOf90RZJZUk6cvnHV/PCWbqI5mZ60XJzlQharEWcT0L/f7VLTT59eW X-Received: by 2002:a05:6402:b1c:: with SMTP id bm28mr2415986edb.116.1598627822076; Fri, 28 Aug 2020 08:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598627822; cv=none; d=google.com; s=arc-20160816; b=JGffpSvqzxBs2CXcqw2kkg3MIlhq7ZIYSlvwnQ6T1CydAffnxMUtKD7xoKqpEV1ZSe 8caEv6xKsQeAcQRk+dkMQ+/8b6L8Gn6Juk8acP1xPDxqoNbGFQ9ppBc65GRkOaLMov99 as+2mpLNsAvWUU2MXnS5XGE+CLiKAayIPzYC9J7NmtAFNIN9kdA9S06H0VTs7Pr9fLuA XmgqVKvHBLRfIeNV0maB9p1Nd/JNU0eC8NmDwl0W/olNrWNlpWDtATpRX0ItLB6cz+1k jHF0b/f66cJenze6lFEShXd05KGMgmDGYc1rWsv614IYw56rhwpwMjBDyILEQ6/X3nwV mVeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=JL1tN8qfCphkBQ/Kqcy5JVznfUhLu4hW0sYjZpVa/1o=; b=jJ2DCZY/Wr+evzx0Q7aWSC9whBkbiRar5ZRyvIwMgc1zg03M19iLVeNJ02iC4ca13c bSN3S/Sv2qmIV5jMU5HpYAXU6LzwVqL19CJ3K9I2tToWIh6J/tr5PIDhxXAPBkrcWfvm 0MS0guk/6aMfx+tYCDpLVC/kBxdDn4GMYGo9D2sskN+k5+BVg36Zn3zgGp3B8aAd80Ee 6CRICzxpw2T6e/W+WiZwLT6rAgjYffLU3wtIaqcHeyj4vWfmxZCCcy+C1u9wLJNsDjdx ZYhK8xcHN26jXIdOXnTFFrumtSckI0pOraiD9IocyMfvYhBNin0d2dpjMiN/YI0j/3hv sQMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DARVhXa3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f18si822894ejk.237.2020.08.28.08.16.38; Fri, 28 Aug 2020 08:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DARVhXa3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728238AbgH1PNn (ORCPT + 99 others); Fri, 28 Aug 2020 11:13:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:59416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727867AbgH1PNl (ORCPT ); Fri, 28 Aug 2020 11:13:41 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E07C208C9; Fri, 28 Aug 2020 15:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598627621; bh=rPCsaXfaJ8tMmGrgiB0WKcJSn4iPxStyfSWM6ySl1p8=; h=From:To:Cc:Subject:Date:From; b=DARVhXa3li9phBOgNWUfeg2fCJMjVpOKbCCZHgwV2fOGVIPW8647779WTR2CHgE/Y DPvV5Xh8Li+GlNAFkCfFUdRey9SyxEM3YKYo873lsc8zrjRQSxFhOkXd70RT29B9dg TsX74lPyiwxdZ5YVPsy5nEdXfibiMOHZkgXxgmUs= From: Krzysztof Kozlowski To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] extcon: palmas: Simplify with dev_err_probe() Date: Fri, 28 Aug 2020 17:13:37 +0200 Message-Id: <20200828151337.6748-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-palmas.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index e8e9eebe6b1d..a2852bcc5f0d 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -205,21 +205,15 @@ static int palmas_usb_probe(struct platform_device *pdev) palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_IN); - if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) { - return -EPROBE_DEFER; - } else if (IS_ERR(palmas_usb->id_gpiod)) { - dev_err(&pdev->dev, "failed to get id gpio\n"); - return PTR_ERR(palmas_usb->id_gpiod); - } + if (IS_ERR(palmas_usb->id_gpiod)) + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->id_gpiod), + "failed to get id gpio\n"); palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus", GPIOD_IN); - if (PTR_ERR(palmas_usb->vbus_gpiod) == -EPROBE_DEFER) { - return -EPROBE_DEFER; - } else if (IS_ERR(palmas_usb->vbus_gpiod)) { - dev_err(&pdev->dev, "failed to get vbus gpio\n"); - return PTR_ERR(palmas_usb->vbus_gpiod); - } + if (IS_ERR(palmas_usb->vbus_gpiod)) + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->vbus_gpiod), + "failed to get id gpio\n"); if (palmas_usb->enable_id_detection && palmas_usb->id_gpiod) { palmas_usb->enable_id_detection = false; -- 2.17.1