Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1274470pxa; Fri, 28 Aug 2020 08:19:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/vjEGmpHiI/WHEald4x14fi3D/DdMvpSUo6RH/KHhReWE7S+9FFBaTn4EpKfRdUVxbL02 X-Received: by 2002:a05:6402:847:: with SMTP id b7mr2481562edz.39.1598627982946; Fri, 28 Aug 2020 08:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598627982; cv=none; d=google.com; s=arc-20160816; b=wSosSs2ZPALaJzQsEcKvkUiNjg9BinVQSo41KfYaE4DK01wtf22NWshW7kl5gIYj2d OpNIRyhSHxVaMkT93l9ZB2Nfer305hsgBOg9Mm2v//Ga/H6FO00IbaTEmSmEJrpp1LIT E9SVAoQWG0RV/iMuzYjIvt47zfPNKo/9r48mlBinUEsDjGfXRIm/u41r4yW4dRMfEa+T +0WvNEnqCORrRxllD9yFj9m0dd8dhAIt04a1lFZJSPCnRm6jQp2GPD2iHx4gHX5wJEcO J8myUQbZic2neSqxneyS+cpDnoOCsOOQ8P3Gc/oYfLI9l+4XMjYlHI8/hKDFadJl5dWr BSOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=4SlRleKW8vmw+cIDfqWdCOlLLf00/dZ6h/yc5sGQ/ZM=; b=zZR5BEOJZ9V1xGFUh+JL0ghgjMAKAiOfQQEaa7GhS5apdRqOH+vc+5Y2xaPgsK+psC I4p+9ZtVtLqZOUCMO+19R+PJL1bhGjgNpy8HjF0I1i4AHn4JRbXduXL9No47NjynjhJ2 KkBVGjRaYMkbwuBZ7qZ1t0TyPeKboemGVLjhBHpeGkzEnCuKkCUSHirFSwO9qfaUcWak auT3ndMvzuZWKbcqiwU7+P4nQUcBRFyK9oUlkCaUGI+22aWWC+5z9Vo39pMRyPD/5fOz EBeRILBt4cbLuR/7wpTezOlr70i4HhUMekYRgvvJV+snKo3bK5cIkYHbZa9krczrkIO1 sSuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si888021ejx.85.2020.08.28.08.19.19; Fri, 28 Aug 2020 08:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgH1PS1 (ORCPT + 99 others); Fri, 28 Aug 2020 11:18:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:1989 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbgH1PSU (ORCPT ); Fri, 28 Aug 2020 11:18:20 -0400 IronPort-SDR: pz4LaaT+8mwjNDf4JDySGScND6n/AzhucaSjsG6E5qq24R6aTSZHpDZl/+dpQlAcJF/Ju9wrFo W8Hvc/ca1MRg== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="174732357" X-IronPort-AV: E=Sophos;i="5.76,364,1592895600"; d="scan'208";a="174732357" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 08:18:20 -0700 IronPort-SDR: lpnUix3jb1jq5RniOzI6GlxCPQkIhMwJ2N2ThQElCFiFYWFOWsKKR9DPQKVUtEpN5FFTJ5NW61 g8ymFrLqnyBg== X-IronPort-AV: E=Sophos;i="5.76,364,1592895600"; d="scan'208";a="300266458" Received: from lilymao-mobl.amr.corp.intel.com (HELO [10.209.185.175]) ([10.209.185.175]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 08:18:18 -0700 Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs To: Vinod Koul Cc: Bard Liao , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, sanyog.r.kale@intel.com, mengdong.lin@intel.com, bard.liao@intel.com References: <20200818024120.20721-1-yung-chuan.liao@linux.intel.com> <20200818024120.20721-10-yung-chuan.liao@linux.intel.com> <20200826094817.GC2639@vkoul-mobl> <21038e8d-dbd9-76c7-c758-9933fb45024a@linux.intel.com> <20200828074952.GO2639@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Fri, 28 Aug 2020 09:54:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200828074952.GO2639@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> Detect cases where the clock is assumed to be stopped but the IP is >>>> not in the relevant state, and add a dynamic debug trace. >>> >>> you meant a debug print..and it looks like error print below (also in title). >> >> I don't understand the comment. Is the 'trace' confusing and are you asking >> to e.g. change the commit message to 'add dynamic debug log'? > > Question is what is dynamic about this? dev_dbg() is part of the kernel dynamic debug capability... https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html Not sure what you are asking here?