Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1283105pxa; Fri, 28 Aug 2020 08:32:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/A7vfl7Pe+j00pj5+p2c7nGF1gxKDMMrHvi0pRjHZ3Sw6sFPlheyG3X+UJDpFdSTR1lF7 X-Received: by 2002:a17:906:f1da:: with SMTP id gx26mr2466871ejb.261.1598628751070; Fri, 28 Aug 2020 08:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598628751; cv=none; d=google.com; s=arc-20160816; b=xpx35Phh0XxNVRFSQYiVpd8jef6s3vZ4kwyCVtdCjoABoFA3fSB/AplN0YU+c55vAh Nf1KEaaKL3F2oU7glOA0OskUWJpfuJ4BFfk1rX/ryZmmT35c/PQJJ2easP2iMAEf/mN/ YcD+8B6vZyJMAwOfrPo8p6G+EU1d6LXO5qiULtBUFOkqO6qY+KVExhLDxBQ/+VpuHncf Ecr1GKwHCkNmkufvdDsvpX9M9TY8VJI9n8RC4eTv8tyC1zAwBSzkbxHkZofQxfMCozmL lmwppr+u0YVF5xcGuXpQbwOqCzzvn61XP03T10oxrMRelVW0m/eFoH1wQaDSSIqv4e2k UhYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=hmI7vw3dLPfXyl7oCOYp3tTk6yrBRG904Qipl71XXrw=; b=G9gg+ChWxhKYNDWx2/4iwPAiyYgtDSqCskleIdGTMXO/w7s9xc/jZsKb/XpmB83rGy 51nlvKvgQiWHd5zQ9KePWJ3dE1JTCClXVlXiBwcfyYUwKbMOpDqLR8+Pbe/XNxMahSew wB3rAy+5s5+AQF58jFG7gBlQbm78xDc2y2aPddjn6QVRG//u5fLnrmUY+7xFd20S8qTR TE5q6HyAIYEr1/vBilDPjWEN6JO4mzY2Lhgrxj6GqWVX+8niJ5a2XJP0nh4JsB+Ke6OV 0Zh5fPMiDtALGeQbYDyt8nFzI5XSbiQw9viEWZ7qHMeVFaRRd/VbfDt3cEb2fD8XBQJ9 Ep5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v3LCcNlD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d11si867410edn.451.2020.08.28.08.32.07; Fri, 28 Aug 2020 08:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v3LCcNlD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgH1PbH (ORCPT + 99 others); Fri, 28 Aug 2020 11:31:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:41176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725969AbgH1PbF (ORCPT ); Fri, 28 Aug 2020 11:31:05 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B01AC20825; Fri, 28 Aug 2020 15:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598628665; bh=ZRmEHvNeCWySdppo9f+Xpr/wkwy/XVp3F0fZ+psgUTA=; h=From:To:Cc:Subject:Date:From; b=v3LCcNlDRdLEhs0PxlDleb95PcfWSDsKdDgeXwh15QXXmxlrQ73XLS5fE/5rSR8Ld dCexiKcqZ7pcxg7ivfQQchWY6N5t0XdRxmdKtpb+8m7FKn2HH4LrGPuQ+HAe2N4zTW jBi8MpMAVLxrEcXK8GDLj3LKF5ZTCzzRn7nXNkls= From: Krzysztof Kozlowski To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] devfreq: rk3399_dmc: Simplify with dev_err_probe() Date: Fri, 28 Aug 2020 17:31:00 +0200 Message-Id: <20200828153100.19006-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/devfreq/rk3399_dmc.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 027769e39f9b..35b3542f1f7b 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -324,22 +324,14 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) mutex_init(&data->lock); data->vdd_center = devm_regulator_get(dev, "center"); - if (IS_ERR(data->vdd_center)) { - if (PTR_ERR(data->vdd_center) == -EPROBE_DEFER) - return -EPROBE_DEFER; - - dev_err(dev, "Cannot get the regulator \"center\"\n"); - return PTR_ERR(data->vdd_center); - } + if (IS_ERR(data->vdd_center)) + return dev_err_probe(dev, PTR_ERR(data->vdd_center), + "Cannot get the regulator \"center\"\n"); data->dmc_clk = devm_clk_get(dev, "dmc_clk"); - if (IS_ERR(data->dmc_clk)) { - if (PTR_ERR(data->dmc_clk) == -EPROBE_DEFER) - return -EPROBE_DEFER; - - dev_err(dev, "Cannot get the clk dmc_clk\n"); - return PTR_ERR(data->dmc_clk); - } + if (IS_ERR(data->dmc_clk)) + return dev_err_probe(dev, PTR_ERR(data->dmc_clk), + "Cannot get the clk dmc_clk\n"); data->edev = devfreq_event_get_edev_by_phandle(dev, 0); if (IS_ERR(data->edev)) -- 2.17.1