Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1287860pxa; Fri, 28 Aug 2020 08:39:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZ295+rlRfWHdt4w2JKa3bRzENTDwArpyf9YObIHkwQvoXmkNJLuW20tKYWkdfgiV68nd1 X-Received: by 2002:aa7:d515:: with SMTP id y21mr2407437edq.381.1598629163891; Fri, 28 Aug 2020 08:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598629163; cv=none; d=google.com; s=arc-20160816; b=T2TkexaORowlXImYWYXJvSgzRb9yl9/FtmpAcYNMGAU+geXqfmiKVwDPKDxZpyjv2e yIkINTJMaxl+WIuavRJ2t8j7RzTu3yAN1YxPZLxTTXqbA6PJN+goGDT8tKtwqEZUMNsQ J86uwGqZb05bkVySwaxo+eC8qpKYNLCkAt4uvrdJWqNSvL7fCBXSEHLusyFsEe69cCZP UOul3MnXUKCT4bFGAuHq2lRvbTUQ5Pno+SWEkhORtBLzIX1VFO9wqVrwlWqd6d43A0nM bH2xf9u+/jdf09lbXuRKUe/FUeg1R9ytOxL3WAz5HPyYo42uTMXISvKDBnXRusKpod+f wqDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=w1qwBfhAHR6/rSMOeX4h6IS0kOh5MEg299PYfT44Yco=; b=vOv6GnubwT4cuX9CnVSHvFOsehZP/y7SbKhYLSMw8YJQrDKQQYV8dNld9cHfnM5YzW 9W2U4vR8PkTGNSNMnpNdyGRk6hjlih6pXKBtXsnHJGnyLhC1lSnjlNBSSpr6HhFY8tEF G02UPk4CKEp8I4bG2WncpEHxpmsyvKdw08xBbnBGh8rKTBjRHjdXZdElR8brW7zCXyz3 V85FFMrZ15Y2dpWBnzQX0F/5JuIA7g1984vNiYuwuNyEsaeyU+AHEZ0c7rt+RCOZODlt ETMszh4M+8/ld6C3GV9fSqDxNVvxp1VxZ0stUC+AZDGgmt5v1jpRtK0fwNTVSjGaykHB uxFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DCUJH1ir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e23si862693edq.329.2020.08.28.08.38.59; Fri, 28 Aug 2020 08:39:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DCUJH1ir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727993AbgH1PiA (ORCPT + 99 others); Fri, 28 Aug 2020 11:38:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:45064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgH1Phy (ORCPT ); Fri, 28 Aug 2020 11:37:54 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18676208D5; Fri, 28 Aug 2020 15:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598629074; bh=bVYPscE2UBKBhFn06TrP+ynYjgB6CV0jt1duhkGi9WM=; h=From:To:Subject:Date:From; b=DCUJH1irLKUaWrJgPrJ201haS5Iw2ukY/GcMtF5GGEDWVaI99jmPMbb2kO606D7cg bu6HmZcN3c5pTyrgGbxkCkIifVWo1mScoxd1h1C9/LsU1+3YLvHokLHxaU4rGXiVx0 zUIIJGoW1tbAOHVVwxenjzCGH9pp5fms0DGTmngg= From: Krzysztof Kozlowski To: Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Krzysztof Kozlowski , Florian Fainelli , Thierry Reding , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe() Date: Fri, 28 Aug 2020 17:37:46 +0200 Message-Id: <20200828153747.22358-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/brcmstb_dpfe.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index dcf50bb8dd69..f43ba69fbb3e 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) } ret = brcmstb_dpfe_download_firmware(priv); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "Couldn't download firmware -- %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Couldn't download firmware\n"); ret = sysfs_create_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); if (!ret) -- 2.17.1