Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1287912pxa; Fri, 28 Aug 2020 08:39:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+Z/988kGPmvNxH/mlhwbbhyLWPTKU08GxwUwnhTS48zPkqwrb4coznyaKmYQpEc7i5bQy X-Received: by 2002:a17:906:680a:: with SMTP id k10mr2461997ejr.82.1598629169554; Fri, 28 Aug 2020 08:39:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598629169; cv=none; d=google.com; s=arc-20160816; b=k+NCUjZ1bxxnAJfP5e5tSTyinM/CQgDyoj5WedFOHB3lTTTX4vn6HeqcI5KR8rbWCX nyW+OG2I8CyFv2n+Dkn2Smztz5RtBNRaEmTqhl9hthx/JoirqycA4DcQ3bGCpPap4BEl NYvnLkerR16PY7cQoCjTW1tjwjdJD3qEW/VNTtX17Og0LDT9xpGNKNlabJ6su6JEu5Fx f6hG4CR51hp/qdP9eSadQYo3mFg65y8plxOob2Du3O3eICGjWrU8vSCeqf0Nl7kDivxy qzCSOKN8QQagY79W5GlaUxQa7JkDea2uZhLynVKli7xVGh8c8a8oQCt17oH71Ea54MWt Jqpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from:dkim-signature; bh=GVIqokNN0l+Rcq78s0a/BGM99cAKC0Jx6TbNPp/Frf8=; b=aKzrxnLBc6eenu6OrPXiZfHo4tD4HX74IW2z2Yw4UC4pegXESTtIkcb4VLpzZWMxK1 ZTbNEhg85HKsBrKmgtUidXLl/b1SNVX5IYakDb+oYNRwZpVQ+A4b92O/3iJT9r79lzmJ GGWZClAnoIZXtGF8eoln3ypR8zlNCdfF8R+05/WpCmf7xwbuTmMtZrLcAjCJsNg4TGSt BdiOZ0q0ilQYfROPyzlgau5S0ksf6iWkCiGC5vhcxDx/U8gE6k/6M9FfM0bZPmHMg0Hj g60WicqIuCPACkohJCDrfwljJ1vhvce8QmnMn4CWplNRbB5eoofVAG3PYPbh9HCEJQst Tr3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RaOWpqbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si883701ejq.742.2020.08.28.08.39.07; Fri, 28 Aug 2020 08:39:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RaOWpqbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728093AbgH1PiH (ORCPT + 99 others); Fri, 28 Aug 2020 11:38:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbgH1Ph5 (ORCPT ); Fri, 28 Aug 2020 11:37:57 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1158208FE; Fri, 28 Aug 2020 15:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598629077; bh=rz+YnW/NU1w7RBHrnA+Vdo53RMowxauy6+hc7EkPeBw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RaOWpqbCF//gU0W3Oxad24QDE98DGFLI3m0uxEgchtqQW7iHq45gGFlf2wgmmRTmg qXD08AbJkBZflYJyGVkcN5+ymNT3X774q5SVqOw0WtOdOpkP/s73yH07iSVQ02NoIu ohzZNPzJeDCUhTtXbcJlL1XliSafKc7kryECVmeo= From: Krzysztof Kozlowski To: Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Krzysztof Kozlowski , Florian Fainelli , Thierry Reding , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 2/2] memory: tegra186-emc: Simplify with dev_err_probe() Date: Fri, 28 Aug 2020 17:37:47 +0200 Message-Id: <20200828153747.22358-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200828153747.22358-1-krzk@kernel.org> References: <20200828153747.22358-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra186-emc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c index 8478f59db432..fa8af17b0e2d 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -172,14 +172,8 @@ static int tegra186_emc_probe(struct platform_device *pdev) return -ENOMEM; emc->bpmp = tegra_bpmp_get(&pdev->dev); - if (IS_ERR(emc->bpmp)) { - err = PTR_ERR(emc->bpmp); - - if (err != -EPROBE_DEFER) - dev_err(&pdev->dev, "failed to get BPMP: %d\n", err); - - return err; - } + if (IS_ERR(emc->bpmp)) + return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get BPMP\n"); emc->clk = devm_clk_get(&pdev->dev, "emc"); if (IS_ERR(emc->clk)) { -- 2.17.1