Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1292240pxa; Fri, 28 Aug 2020 08:46:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGnwjvLI050WePTESY4eXPjG9apy7cIllkpN34iIluAre/Cyt62Z98nqygM+TalfhmSzz0 X-Received: by 2002:a17:906:14ce:: with SMTP id y14mr2618573ejc.314.1598629570005; Fri, 28 Aug 2020 08:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598629569; cv=none; d=google.com; s=arc-20160816; b=n0SO7zApG1I7/ITbCdkPNenDEr58hnq1qy8EpDTrDp4nBgIzaO7tFeiI3dvFffDbkr yHfhLxZRW3ONIqGnQprU3pU/oT8GaM8Z4ademb9svsL3kn80bAWyaXTWe+L9u/RJ1Vnm 8p++dRFgFTwUuAvinn6tMzCVOC0MmF5mRdpYBiG3AG7T26U8Z3ALDIZ+0kOLXhP+EmE+ rhXcL84/sfsDL+0bWbdHfYrawyWTBQpQjTFLsIqMiX3SAQXCaIC86MS+ShSO3yeu7MRg o2X/4GixQvw+SndjuoyoU1L8ELtWPJRV2q2qZnt+FZmZe5A3Eunbm7r7Lo6L3dpIkCxS ZfeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject; bh=EkXOWXVgdfd5enRHXBssAuyMPtef9SLDyWj3UhcJ6IM=; b=ngB9KuuCUHMht3D8CVAbQFjeUgI5P1b5Nsj6VwSUEescXe3FMvKErJT8P7adYNasaW j1oD07wZPo/HvGYWBGbKA0wZLsnyPGs8LbpPdUw6tlSX1X/M+DZlx6v7zW8/RaDvZqvH XGBejN1U2e5/7Ee8WESVzeWo4uhEWmp9JJ9LEPgeVWzDGK9iBnu9mfWGL737eG7zaB3T 5LEurCJRlAvDhK1hteeIqs7YH6MeKsTCIKOj6IKyosVAvEM2wuCkXtyUtQNG6H6nV7Av LzfTkPpo6AiP6iX2ims+BmxQUhkxRjIRzddjdcE3nweshvTW1pL8mIsu4IrYuVpT8eyt t7EQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu10si822224edb.215.2020.08.28.08.45.45; Fri, 28 Aug 2020 08:46:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgH1PpA (ORCPT + 99 others); Fri, 28 Aug 2020 11:45:00 -0400 Received: from foss.arm.com ([217.140.110.172]:52206 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgH1Pos (ORCPT ); Fri, 28 Aug 2020 11:44:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC94DD6E; Fri, 28 Aug 2020 08:44:47 -0700 (PDT) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBFED3F71F; Fri, 28 Aug 2020 08:44:45 -0700 (PDT) Subject: Re: [PATCH v2 0/6] dt-bindings: Convert SP804 to Json-schema (and fix users) To: Linus Walleij Cc: Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Thomas Gleixner , Daniel Lezcano , Haojian Zhuang , Linux ARM , "linux-kernel@vger.kernel.org" , Chanho Min , Liviu Dudau , Lorenzo Pieralisi , Sudeep Holla , Ray Jui , Scott Branden , Florian Fainelli , Wei Xu References: <20200828142018.43298-1-andre.przywara@arm.com> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Autocrypt: addr=andre.przywara@arm.com; prefer-encrypt=mutual; keydata= xsFNBFNPCKMBEAC+6GVcuP9ri8r+gg2fHZDedOmFRZPtcrMMF2Cx6KrTUT0YEISsqPoJTKld tPfEG0KnRL9CWvftyHseWTnU2Gi7hKNwhRkC0oBL5Er2hhNpoi8x4VcsxQ6bHG5/dA7ctvL6 kYvKAZw4X2Y3GTbAZIOLf+leNPiF9175S8pvqMPi0qu67RWZD5H/uT/TfLpvmmOlRzNiXMBm kGvewkBpL3R2clHquv7pB6KLoY3uvjFhZfEedqSqTwBVu/JVZZO7tvYCJPfyY5JG9+BjPmr+ REe2gS6w/4DJ4D8oMWKoY3r6ZpHx3YS2hWZFUYiCYovPxfj5+bOr78sg3JleEd0OB0yYtzTT esiNlQpCo0oOevwHR+jUiaZevM4xCyt23L2G+euzdRsUZcK/M6qYf41Dy6Afqa+PxgMEiDto ITEH3Dv+zfzwdeqCuNU0VOGrQZs/vrKOUmU/QDlYL7G8OIg5Ekheq4N+Ay+3EYCROXkstQnf YYxRn5F1oeVeqoh1LgGH7YN9H9LeIajwBD8OgiZDVsmb67DdF6EQtklH0ycBcVodG1zTCfqM AavYMfhldNMBg4vaLh0cJ/3ZXZNIyDlV372GmxSJJiidxDm7E1PkgdfCnHk+pD8YeITmSNyb 7qeU08Hqqh4ui8SSeUp7+yie9zBhJB5vVBJoO5D0MikZAODIDwARAQABzS1BbmRyZSBQcnp5 d2FyYSAoQVJNKSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT7CwXsEEwECACUCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheABQJTWSV8AhkBAAoJEAL1yD+ydue63REP/1tPqTo/f6StS00g NTUpjgVqxgsPWYWwSLkgkaUZn2z9Edv86BLpqTY8OBQZ19EUwfNehcnvR+Olw+7wxNnatyxo D2FG0paTia1SjxaJ8Nx3e85jy6l7N2AQrTCFCtFN9lp8Pc0LVBpSbjmP+Peh5Mi7gtCBNkpz KShEaJE25a/+rnIrIXzJHrsbC2GwcssAF3bd03iU41J1gMTalB6HCtQUwgqSsbG8MsR/IwHW XruOnVp0GQRJwlw07e9T3PKTLj3LWsAPe0LHm5W1Q+euoCLsZfYwr7phQ19HAxSCu8hzp43u zSw0+sEQsO+9wz2nGDgQCGepCcJR1lygVn2zwRTQKbq7Hjs+IWZ0gN2nDajScuR1RsxTE4WR lj0+Ne6VrAmPiW6QqRhliDO+e82riI75ywSWrJb9TQw0+UkIQ2DlNr0u0TwCUTcQNN6aKnru ouVt3qoRlcD5MuRhLH+ttAcmNITMg7GQ6RQajWrSKuKFrt6iuDbjgO2cnaTrLbNBBKPTG4oF D6kX8Zea0KvVBagBsaC1CDTDQQMxYBPDBSlqYCb/b2x7KHTvTAHUBSsBRL6MKz8wwruDodTM 4E4ToV9URl4aE/msBZ4GLTtEmUHBh4/AYwk6ACYByYKyx5r3PDG0iHnJ8bV0OeyQ9ujfgBBP B2t4oASNnIOeGEEcQ2rjzsFNBFNPCKMBEACm7Xqafb1Dp1nDl06aw/3O9ixWsGMv1Uhfd2B6 it6wh1HDCn9HpekgouR2HLMvdd3Y//GG89irEasjzENZPsK82PS0bvkxxIHRFm0pikF4ljIb 6tca2sxFr/H7CCtWYZjZzPgnOPtnagN0qVVyEM7L5f7KjGb1/o5EDkVR2SVSSjrlmNdTL2Rd zaPqrBoxuR/y/n856deWqS1ZssOpqwKhxT1IVlF6S47CjFJ3+fiHNjkljLfxzDyQXwXCNoZn BKcW9PvAMf6W1DGASoXtsMg4HHzZ5fW+vnjzvWiC4pXrcP7Ivfxx5pB+nGiOfOY+/VSUlW/9 GdzPlOIc1bGyKc6tGREH5lErmeoJZ5k7E9cMJx+xzuDItvnZbf6RuH5fg3QsljQy8jLlr4S6 8YwxlObySJ5K+suPRzZOG2+kq77RJVqAgZXp3Zdvdaov4a5J3H8pxzjj0yZ2JZlndM4X7Msr P5tfxy1WvV4Km6QeFAsjcF5gM+wWl+mf2qrlp3dRwniG1vkLsnQugQ4oNUrx0ahwOSm9p6kM CIiTITo+W7O9KEE9XCb4vV0ejmLlgdDV8ASVUekeTJkmRIBnz0fa4pa1vbtZoi6/LlIdAEEt PY6p3hgkLLtr2GRodOW/Y3vPRd9+rJHq/tLIfwc58ZhQKmRcgrhtlnuTGTmyUqGSiMNfpwAR AQABwsFfBBgBAgAJBQJTTwijAhsMAAoJEAL1yD+ydue64BgP/33QKczgAvSdj9XTC14wZCGE U8ygZwkkyNf021iNMj+o0dpLU48PIhHIMTXlM2aiiZlPWgKVlDRjlYuc9EZqGgbOOuR/pNYA JX9vaqszyE34JzXBL9DBKUuAui8z8GcxRcz49/xtzzP0kH3OQbBIqZWuMRxKEpRptRT0wzBL O31ygf4FRxs68jvPCuZjTGKELIo656/Hmk17cmjoBAJK7JHfqdGkDXk5tneeHCkB411p9WJU vMO2EqsHjobjuFm89hI0pSxlUoiTL0Nuk9Edemjw70W4anGNyaQtBq+qu1RdjUPBvoJec7y/ EXJtoGxq9Y+tmm22xwApSiIOyMwUi9A1iLjQLmngLeUdsHyrEWTbEYHd2sAM2sqKoZRyBDSv ejRvZD6zwkY/9nRqXt02H1quVOP42xlkwOQU6gxm93o/bxd7S5tEA359Sli5gZRaucpNQkwd KLQdCvFdksD270r4jU/rwR2R/Ubi+txfy0dk2wGBjl1xpSf0Lbl/KMR5TQntELfLR4etizLq Xpd2byn96Ivi8C8u9zJruXTueHH8vt7gJ1oax3yKRGU5o2eipCRiKZ0s/T7fvkdq+8beg9ku fDO4SAgJMIl6H5awliCY2zQvLHysS/Wb8QuB09hmhLZ4AifdHyF1J5qeePEhgTA+BaUbiUZf i4aIXCH3Wv6K Organization: ARM Ltd. Message-ID: <28acf821-fa6f-7259-ec1b-4810ca1ff48f@arm.com> Date: Fri, 28 Aug 2020 16:44:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2020 15:54, Linus Walleij wrote: Hi, > On Fri, Aug 28, 2020 at 4:20 PM Andre Przywara wrote: > >> This is the second attempt at converting the SP804 timer binding to yaml. >> Compared to v1, I forbid additional properties, and included the primecell >> binding. Also the clock-names property is now listed, although without >> further requirements on the names. Changelog below. > > The series: > Acked-by: Linus Walleij > >> I couldn't test any of those DT files on actual machines, but tried >> to make the changes in a way that would be transparent to at least the >> Linux driver. The only other SP804 DT user I could find is FreeBSD, >> but they seem to use a different binding (no clocks, but a >> clock-frequency property). > > That's annoying. I suppose FreeBSD just made that up and doesn't > even have a binding document for it? I couldn't find bindings at all in their git tree. I don't think they treat this very formally, it seems to be more use-case driven. Their SP804 driver does not know how to handle clock properties, so most of the DTs (in sys/gnu/dts, so apparently copied from Linux) would not work really well, because the driver assumes a hardcoded frequency of 1MHz by default. There is only one DT (Annapurna Alpine with Cortex-A15) that provides this clock-frequency property. The Linux DT does not mention the SP804 in there at all, interestingly. > In an ideal world I suppose we should go and fix FreeBSD but I have > no idea how easy or hard that is. It seems to be messy, at least in this case, and I guess unifying DTs means some work on drivers as well. But AFAIK most of the more modern platforms copy the DTs (and thus implicitly the bindings) from Linux, so there is probably much less deviation for many more relevant boards. Cheers, Andre