Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1309574pxa; Fri, 28 Aug 2020 09:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzquZ7RQai6Nlh1zAzzV3jz04CroXnPXWCFg04NvNYooU1zJNzOqbaTRnPlMe1JYRwObRjV X-Received: by 2002:a17:906:7197:: with SMTP id h23mr2561100ejk.20.1598631029664; Fri, 28 Aug 2020 09:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598631029; cv=none; d=google.com; s=arc-20160816; b=0NcsDjaRyXxMaX0uHD3D5GEf6rlwke+WQW//n9NciaC8KJ2UP5ifmzaLnh84bp+2LC v/RZVHiUnyqQj0nYm7rH4+P7In4mdY8uTgjeCZbo3FNv/5C6zcJi0AaS64Bk4Hhf1S0B JdgHZ07gufapD9HKPE+hu+VhDm+yw90bc1v68iKMzarM+4po2/FpHFo8OF4rbKU8Xgsh nulJ7a9r0tj540AFm8BzJ+eQfIvLTjz6Kn9Z6PwqmxOBQ4ciy0eCqcZHlJA0z2QqTIP9 xjHxJuoHh84A1hryAyjW4QJLRFcFMjENWrJvA2DyuTJE4VSbDYbbFJ9QyzULN1KBut39 JKKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kAf74PpfTZmPP+SpD4MqAGQy0XO86XXUqOViNiI2p4U=; b=PzyXksjCzWscB35TXhwe7GxjzOkEk41K/t78hbkC0tjQRUFoUaluyn/1TG9Wx3sFoB 4VMJm1J1ucpQNgBrC1NwsSfZjO+P6VO1gLtvkbQ6misLzJQh4YMJU7D/EGvmnVJIZHPE jih+hdHWKzEdgTwFUl1gm0/o5flzwuMdeYfiHi+m7rBQsgRaTHMYlWlAMRx9ShUOA9EK 9cIWT7Bc+orKJNFIN1hu0zoZDQ7CAPISKtEwap9tqnJmYgHsZ29v/ZTt97NFGle9QPKt rBwHfAbMUXAvSR+1tcqsv9ye6893B0DxdaMc2mRW4pEsQixQBYKA+NHnpgrL1QjGOXkQ RipA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc15si1009491ejb.285.2020.08.28.09.10.04; Fri, 28 Aug 2020 09:10:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726804AbgH1QJP (ORCPT + 99 others); Fri, 28 Aug 2020 12:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbgH1QJO (ORCPT ); Fri, 28 Aug 2020 12:09:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E63CC061264; Fri, 28 Aug 2020 09:09:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7FE321287C095; Fri, 28 Aug 2020 08:52:26 -0700 (PDT) Date: Fri, 28 Aug 2020 09:09:12 -0700 (PDT) Message-Id: <20200828.090912.720183995781297697.davem@davemloft.net> To: alex.dewar90@gmail.com Cc: paul@paul-moore.com, kuba@kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] netlabel: remove unused param from audit_log_format() From: David Miller In-Reply-To: <20200828135523.12867-1-alex.dewar90@gmail.com> References: <20200828135523.12867-1-alex.dewar90@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 28 Aug 2020 08:52:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Dewar Date: Fri, 28 Aug 2020 14:55:23 +0100 > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > added a check to return an error if ret_val != 0, before ret_val is > later used in a log message. Now it will unconditionally print "... > res=1". So just drop the check. > > Addresses-Coverity: ("Dead code") > Fixes: d3b990b7f327 ("netlabel: fix problems with mapping removal") > Signed-off-by: Alex Dewar > --- > v2: Still print the res field, because it's useful (Paul) Applied to net-next, thank you.