Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1312687pxa; Fri, 28 Aug 2020 09:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxftB1Yz3i8k/ESrl8T7rbTBvLo3CYMHku0zAklpkk1Vv92PhtiN7yKvJBeQ+w+2pJyPtTp X-Received: by 2002:a05:6402:b45:: with SMTP id bx5mr2680229edb.214.1598631268616; Fri, 28 Aug 2020 09:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598631268; cv=none; d=google.com; s=arc-20160816; b=YY292Fl4XTPsBkh8NjcN6Xhjj5Cb7ZVC/JTlkGTmmfPw1BptqAxKYUOthreHu32yWY I9Gf+RBoVfog8SY0gbtOyBDKt17ioVfcYlCFFHVPv4kjM5T0r87BkQyqLkY7lv4mw9To eIuU/zh85va1M5U8xsBXqHk8PU3TPp5+9+3DLDQETVqVI0/ZKM3+fPlrUmCdkhecV2A6 M/hJAnyT7ywtkGoBmgfIcPsPTH2pkkrjN4E+fVEljFUpEtUYv2NIc2yrb+cm5hF4SuaI TE6OvYA38J+R8RknOeRLK1e29f3O5gkKvumGtlUwVbFJfSdlrIy5RMOmbJ5+XmBk6D2S AAyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=68eDttIIdaNDtczAU5J2J6maRd1hjk4vD2eKoip4OiM=; b=h/NospSnBgfaouFuCsMKBrXEgjAAGJ63MlI31QCDJFB7cO7ide/W24+FhoHl7VSeFh BQazmKxgTm6EegO5IKrCfifSd+K1UUxUandWA0nn4anaPYP7q3hppo/BRW2NwG3WqD2C mHUp2XlM7+jqHENyrmZ0hIdDtdVFqcDBLx1B0lE+ot7GqDf7T1xy3d3TRlp88f48sLAn 457fsKQEpEaNY3gj64s5NG9hu9CuwyNf40oNSipDuEFzDn9a4wQot2wUvCh3XV5RTNyy 9QfcTWtObx4zGLYOWGEaW96ZMcHQjBOZMHCbjonjlhhvqh8HGjCpNyEZeS33ohhW6+Ar R4Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Lh2vPqbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc15si1009491ejb.285.2020.08.28.09.14.02; Fri, 28 Aug 2020 09:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Lh2vPqbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbgH1QMU (ORCPT + 99 others); Fri, 28 Aug 2020 12:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgH1QMQ (ORCPT ); Fri, 28 Aug 2020 12:12:16 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40914C06121B for ; Fri, 28 Aug 2020 09:12:14 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id u1so1638499edi.4 for ; Fri, 28 Aug 2020 09:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=68eDttIIdaNDtczAU5J2J6maRd1hjk4vD2eKoip4OiM=; b=Lh2vPqbCKyX+nvWywFutd7Njub4N1BKB0z0SGWL4Kx1eUvmeKx98gqs12jpOwZUImx a/jJy/VxVHxeuWC+9vl12hBlpQ2rX8aiOEU1VYo1rsgOsG1qrqbeJzCivpQEZsT3pdGN U3N/rtrQqwEOfPYjkaHZ+l/GidodYIOBDxzug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=68eDttIIdaNDtczAU5J2J6maRd1hjk4vD2eKoip4OiM=; b=ZQT8fx1glhYe8TK6u4vdsiDXEnWYHX6YYJ8szEcQoPk610vLrqwb1D9198Sa7npoGq BflF2neT+5Gtj7O57MMCzFBOqaiP45UqXYVzG9qBnE/MBQyUwrbvzJ+biDPzkEKoAwco 1OFYr3PJykkXIeLhMD7L3lVdoxXrlZOshSaiFUnGGH8MyFV5aRK0ym+ETUU1CnZhDki0 b8CuWeNnGkQgy2VJ7EW/fBU/C0BML4H0JvCUrQYS1neilC6ryVoq32MOf+MTd0naDYes ppA2QzewvZHqd68t6CabDEhI1O9skHboQeYuRimX7duRoTtJis308/O/1XEu/bQuKXO1 v5eQ== X-Gm-Message-State: AOAM530vz5uFhwDEP3lnjQRiQ002YzJBsbav5cOAT3YZiu/yu5ayAXRl aOvtQEbfO4ZOjb1qwQOgcSKezQhNNUvwIetvh4mPhQ== X-Received: by 2002:a05:6402:2212:: with SMTP id cq18mr2673132edb.34.1598631132537; Fri, 28 Aug 2020 09:12:12 -0700 (PDT) MIME-Version: 1.0 References: <20200828153747.22358-1-krzk@kernel.org> In-Reply-To: <20200828153747.22358-1-krzk@kernel.org> From: Markus Mayer Date: Fri, 28 Aug 2020 09:12:01 -0700 Message-ID: Subject: Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: BCM Kernel Feedback , Florian Fainelli , Thierry Reding , Jonathan Hunter , Linux ARM Kernel , Linux Kernel , linux-tegra@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Aug 2020 at 08:37, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Markus Mayer > --- > drivers/memory/brcmstb_dpfe.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c > index dcf50bb8dd69..f43ba69fbb3e 100644 > --- a/drivers/memory/brcmstb_dpfe.c > +++ b/drivers/memory/brcmstb_dpfe.c > @@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) > } > > ret = brcmstb_dpfe_download_firmware(priv); > - if (ret) { > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "Couldn't download firmware -- %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "Couldn't download firmware\n"); > > ret = sysfs_create_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); > if (!ret) > -- > 2.17.1 >