Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1385358pxa; Fri, 28 Aug 2020 11:08:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQnnbDhCDsBQ+Kut98uRkNVUrWDHY7AxDnW8tc6LYpINmK9JB8RZZBpVJimPEb78C+pqbj X-Received: by 2002:a50:9d8a:: with SMTP id w10mr3146778ede.16.1598638130282; Fri, 28 Aug 2020 11:08:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598638130; cv=none; d=google.com; s=arc-20160816; b=j/Jp2xJrRa1G0iKEGVZ7v45TsSShipVhw6eFPkPuAllNfgTGpx9lW4yrYg5DKhzhff RbaaNo+Bzn9jm5iHiDmNftzLFdm+LSJXvYQbbNT1UXCaOlAP4W8JUCrny65Ff7R3lZKe si/Vrhs5pH2XW8Pl383u4iGqaORxeh19IbcBJg62rodq7KgJj/ZgE/YC/9p92ZM5NnFX R9L+ILJPg+bCdjgCkIhxMrPmLAt1T0BfvO1MS6bIAJXt2q1Ow6jZ+bNtuV8VtbgEc8Rl qYPH49oRo+MvaNketIivEhMugfxGvLRbNCegDmmxOg0KuTUvQ+Ks/o8h+aKpmSQe9II7 IPLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Pu5Ace11sew4YK64btJv3JxoO9E8cFj226aB1o8LzyE=; b=cK96rY3MdY+9e6Mj6zDyilq0zHFWW2HT5jhGBOVEoiSLAeXaTatu/65+4Hp//h4VSe n/oPbBKmx1gGc6XT1sno45wkoSqfK7Sn61MMWIBvXfy/ieLfqR4fd/QTCEF1HFCu/db0 7s4oEaVxzTRfARcjOPdEBBcOvwGltNk8PsxGUx7R5eDrayeQJrkNStFBUYuChqD+ob3Q cHtM6xs++2YCKBrgvXL2egY5S8S5YCT7+WUBsc1z3lVRsnos2ZgdITYBwhgLwVeELx2l iQKPsPyJGqNDJkAnA0GqMW0scN0TaIF+EFmxNnl4FEvLM7NM25I7qHaPM4QTbs0zj/on T93g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si177112ejz.445.2020.08.28.11.08.25; Fri, 28 Aug 2020 11:08:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgH1SHu (ORCPT + 99 others); Fri, 28 Aug 2020 14:07:50 -0400 Received: from correo.us.es ([193.147.175.20]:38482 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbgH1SHr (ORCPT ); Fri, 28 Aug 2020 14:07:47 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 16BAA2A2BB2 for ; Fri, 28 Aug 2020 20:07:46 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 08FABDA792 for ; Fri, 28 Aug 2020 20:07:46 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id ED457DA78A; Fri, 28 Aug 2020 20:07:45 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,URIBL_BLOCKED,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 668DFDA704; Fri, 28 Aug 2020 20:07:43 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 28 Aug 2020 20:07:43 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3BCB542EF4E1; Fri, 28 Aug 2020 20:07:43 +0200 (CEST) Date: Fri, 28 Aug 2020 20:07:42 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Tong Zhang Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error Message-ID: <20200828180742.GA20488@salvia> References: <20200815165030.5849-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200815165030.5849-1-ztong0001@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 15, 2020 at 12:50:30PM -0400, Tong Zhang wrote: > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is > checking parsing error using < 0 Is this are real issue in your setup or probably some static analysis tool is reporting? You are right that ct_sip_parse_numerical_param() never returns < 0, however, looking at: https://tools.ietf.org/html/rfc3261 see Page 161 expires is optional, my understanding is that your patch is making this option mandatory.