Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1393702pxa; Fri, 28 Aug 2020 11:22:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp9Uzwmp+/qzLrrHE9LRKNWYBxmCmDQd/RsYXvb7K/fqLJqnPNGp0iqBg2h0ZCvGC8Pe5E X-Received: by 2002:a17:906:3f82:: with SMTP id b2mr3371435ejj.240.1598638945815; Fri, 28 Aug 2020 11:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598638945; cv=none; d=google.com; s=arc-20160816; b=EIbcHJRfD239RHvM9Qxgkj5KCTqSRFBbuZ/Z6JsXDzuyC9NHT+QvBKLOeRvK0uwsjE dEadpExRXX8I7278UJg7Cg4gO4NHwUniFxnVAbh6Z8pGbs94YLxvGh74RCcVFcfEl1YA zYDAOR6fPIXU5Qtlz+8bw33ULpKzeVuLcNoSPuA0uT5QngUJeitF2MTnalPkPujWwqlc DuQ+d8LZ0lNr7HXxiL0BnB6Wd3IXVg4kqdAajTrkpwLEqBFKWLQgOmbye8sjeHdECgj0 jTv9MwMpjzlmbF5V8Sb6xIjpriO4rXgEVorKoqCpN/l7NCKFJMMou/eIXkepm3eEejUQ FoOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eWhF1suZnWUlnTjsB1Pks2mZwsjaYVNvvQyJBnJsxP0=; b=0rAGCN04HRHLsrmzfTnUunvQIqdJIIrS93+5atAc2giHjY5iC/s0K6kM4Es/ZfdxEr hYbgd+bPnadiwbAh9fxysmYr1muVkxn6ob3zZ+SrNo536udnvgCz1ppBm3rpF/cqBg5M LKbTaLI8J+iW6X9/qySpziBWVcjfetZSJMHVds9QXgXDuVtWY8bnB21wCc1pVBHixviG 9C7Wg3GE7tRMsCuoyuSHv5vw/ulaRrwKZ0/IJ9zhDaKnyEWSmhSZbH9oPfEbrcA7LKNN BdFBtaDoK3lwnE+NoVvFTacapaE/3ToodARQXS8pYdulEB/T+KAm+a257rgS/2prz7Fm SHgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn22si1403856edb.175.2020.08.28.11.22.01; Fri, 28 Aug 2020 11:22:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgH1STc (ORCPT + 99 others); Fri, 28 Aug 2020 14:19:32 -0400 Received: from correo.us.es ([193.147.175.20]:40486 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbgH1STc (ORCPT ); Fri, 28 Aug 2020 14:19:32 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 360F12A2BB4 for ; Fri, 28 Aug 2020 20:19:31 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2838FDA730 for ; Fri, 28 Aug 2020 20:19:31 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 16134DA78E; Fri, 28 Aug 2020 20:19:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EFC0BDA730; Fri, 28 Aug 2020 20:19:28 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 28 Aug 2020 20:19:28 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id CB44942EF4E1; Fri, 28 Aug 2020 20:19:28 +0200 (CEST) Date: Fri, 28 Aug 2020 20:19:28 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Tong Zhang Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error Message-ID: <20200828181928.GA14349@salvia> References: <20200815165030.5849-1-ztong0001@gmail.com> <20200828180742.GA20488@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 28, 2020 at 02:14:48PM -0400, Tong Zhang wrote: > Hi Pablo, > I'm not an expert in this networking stuff. > But from my point of view there's no point in checking if this > condition is always true. Understood. > There's also no need of returning anything from the > ct_sip_parse_numerical_param() > if they are all being ignored like this. Then probably update this code to ignore the return value?