Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1400365pxa; Fri, 28 Aug 2020 11:34:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPS6KbSqZ8cxBLjDNCsgk7bTK7eH1k5+ys6cWiWb7HAD1vbTuKieOMljms1hDg41n3Ynke X-Received: by 2002:a17:906:d282:: with SMTP id ay2mr3130585ejb.265.1598639662963; Fri, 28 Aug 2020 11:34:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598639662; cv=none; d=google.com; s=arc-20160816; b=NpBmKdyYZEHJqSvhxjo3Kbe5aurqXjc1p3NYcIj0YOECc1wWswOfZUN/gUEnlsd0D5 oC20Rls5u30v+OLl9LeXCcJuzxNXrixplqDgntgzLzC7HLCCinJZYP3uU+tEsockz9Qu ZLsuL70kt2v46lSwzKqC1u+dUi0GrtmqqZ5EGl9SfCGWAHxEv6oX0ND9yNbXLYxmA5dA 2+3xQ9pMP7L/v5v5FPuckf4SHR2fax9Zec89Lj04KDcAQmwXCxm8D1C9lciE2vagqzLG F5NSuu98zvPPhD+qXHpzK69+pTw9Vkigq/u9L5t/SxVBh7/0YRAqyd1zZ8Eq3U3Z2wZ6 8zOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WtlD/YX0ISFkWguzbH4vW7Oxt2gP0SItAMBJ51jlhgA=; b=lRrC5qnjey4NWMfG4d1nhRcdBXMLsYXymP989cjzMt6r/5dTsuQS7uPZ0V9BLOo4fx 0iABeggAi8DC7x8CsK0J3NM1tQw3WdZXpklGTx7U2hb2Lz1AJQQjIyDShyvvzEEIB+Tp ZDGmAXwc9Nj0RskWzwGU65Nsma5yDtNqddiJiW630LRxrnyuDEJtZ+M2TeE6aw+HvCqY oOnige5LB5czWHv5c6LRJEcS/+UGFLUkJAIkk6n/RKLHGHGc8F5znKZAfmKi5WQJpQky izmHob7olXRDjKhLjLDnpP5X0A+PDlQyxwZoyqf1aWtBVGQkaaM9cwB+FSfk0Uga8KdW 5HRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u5ZZ+sOo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si1226156edk.48.2020.08.28.11.33.58; Fri, 28 Aug 2020 11:34:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u5ZZ+sOo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbgH1Sa6 (ORCPT + 99 others); Fri, 28 Aug 2020 14:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgH1Sa5 (ORCPT ); Fri, 28 Aug 2020 14:30:57 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB838C061264; Fri, 28 Aug 2020 11:30:56 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id l8so22905ios.2; Fri, 28 Aug 2020 11:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WtlD/YX0ISFkWguzbH4vW7Oxt2gP0SItAMBJ51jlhgA=; b=u5ZZ+sOob/NWIylD3FsfSRO2o52LyPkjnkvg6BJJxLxSFcoY7xVzCeX4o5AGNyENgh I0Mtklx0pRK3QUFdILooXaJLmJSj3Zur8vtXO0BEWiBRvQtlY0JKXlNT4jlCOrhFcnh1 1a+KUhcq6JxCCvZRlGHL2USpA9248WhAKkf261bFTE/QE+9+b+qGpsJjA2G1/hq9YJea 2xJpQ0Znplfsa8P4kG9U326heJw15KaQ2fmJxtG0t371dOMMZojXjDsMupXG4O0shg6S ps8DwCx2MwUEbulW0xnuo1CB5WK7kUJT4sPD+0c5+8pQ7AezyP4AOp/tZahCkw7gtGuf tkJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WtlD/YX0ISFkWguzbH4vW7Oxt2gP0SItAMBJ51jlhgA=; b=oFX7RbgpZQV8KdiTdcYXqvwHzLsqthzyC11O1X+oFUM4gIXRPfq5bSLv1kBMJ5xab/ XYtGttlKc1YEk6a/cSB3cZyxnFWAXYmRLlFSVLc3zkY1QuolV6/4NXz1UUx7lxT0cXIX JVF6/dKWnkPCGWldqZnh94ONenqBN9bl/zBmrXKN0X1+qUaI2CD26xT+ej8t+icavnbV F7whKLz9bMDD+W0rKmPbO3HrKrnUmcK3VeG9pkydEJR3/57qsuew2HJzRaFYfZ8MoLr4 c2fhcWu32+7uebxDU3sFurx0ohl5ZG/zOhH79vYtCKTBgb5NfSJhmdV6v7uCbTDcQfvy gWeQ== X-Gm-Message-State: AOAM533IQz2Buxby9NdVj4o4Clpv0I+ckMzbBSmhIwAVVnwVkMIiJcXn 41brg19dhxkeuAiVU87aV4X1IPR8+DUpoALuyHta29gl2wA7y+wh X-Received: by 2002:a02:e4a:: with SMTP id 71mr2317041jae.133.1598639456198; Fri, 28 Aug 2020 11:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20200815165030.5849-1-ztong0001@gmail.com> <20200828180742.GA20488@salvia> <20200828181928.GA14349@salvia> In-Reply-To: <20200828181928.GA14349@salvia> From: Tong Zhang Date: Fri, 28 Aug 2020 14:30:45 -0400 Message-ID: Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error To: Pablo Neira Ayuso Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think the original code complaining parsing error is there for a reason, A better way is to modify ct_sip_parse_numerical_param() and let it return a real parsing error code instead of returning FOUND(1) and NOT FOUND(0) if deemed necessary Once again I'm not an expert and I'm may suggest something stupid, please pardon my ignorance -- - Tong On Fri, Aug 28, 2020 at 2:19 PM Pablo Neira Ayuso wrote: > > Then probably update this code to ignore the return value?