Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1707972pxa; Fri, 28 Aug 2020 23:49:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuqI3TPpd76uoICSOz/4CJMgOmPmrSyxh60ZUBgNS15bUs7CKCJeq5v05ktNAGVTHbqbP8 X-Received: by 2002:a17:906:3a41:: with SMTP id a1mr2338085ejf.260.1598683772217; Fri, 28 Aug 2020 23:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598683772; cv=none; d=google.com; s=arc-20160816; b=ky7QAS/K0zMvu0BHQPLJAIf45Xh3ZTSVTtSkis5NcOC5LaGErJJ/koheZyzP6Bkxse /yqm1NbHQgNCGlRvbUYzLx6tKV1penvvnlFcrf/A7ZvrPk3uqekKq7ZqoC4eKRxCxmwJ Teij2s15vInFrlGuP6OfpwC4NzB7mGZFDJa602rrdqu0LUB8PZs0eIFbfaBEDmBrlkPn mF8vcc9rNAk2WsgLEquGufvUgXxI+VO1Y6wr9mhGLdhsJbEVT2NHNUpQIuZBB09tL6Za uNqmFTTa+fqrUrAqcqSbdy3O6aWmj++39f5iUPMbPF+Cqr0KtcsC+3MjFmBjFo74X1Ew sSaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=AIYW0TkN97s22gPCaB2C2ARspY69puD4ypkIrI3F+sQ=; b=eBZmQbEYO1iuBknP6wZleuikxhUigRaE35PXAHC5OuscQmYvJn/PwXqLizWp8Lomyv b8tygjf+/Lx9tscohT5mXcq5wGhtFQGgQyIisJjA4C5zm2nl1UXJM0dr0E5b+or4jYto QQkgrykfFvoJuNo0hNHd9nl0z28mIIYEsWSsPp/FJMcIVamjLk8FWSK5msAYdT5zepKw FkUc0g21z6NkXtMhqZuloqB8DcfnmKsTnDgV94Hf9aaCyrdHkHBWUy/EfyTfLuTJ6LtF SsRrwfslIWSgTuCTIYRiBwCGRFm4JBQybURG/mav6ZScFw9jai7sm8yyTKn/Fiqv3oBQ LeoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GpwEXvL9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x7si1253815ejv.609.2020.08.28.23.49.09; Fri, 28 Aug 2020 23:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GpwEXvL9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgH2GsW (ORCPT + 99 others); Sat, 29 Aug 2020 02:48:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:40756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgH2GsT (ORCPT ); Sat, 29 Aug 2020 02:48:19 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8023E214D8; Sat, 29 Aug 2020 06:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598683699; bh=yN2CXKQfY/uZdOl3rgqKv39aMA7Qb1yuEX/j8QscrAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GpwEXvL9qr/48IVmL4F6CQvkM2Et247vmZQD1fZ8sDc2nHJfg2ENTpNrjb3oHGy6+ 4AffxnMZWvXHtYlHuP1dTYidoVKasMJD6YBsm3nVUrS18Pj/HXXBtTeinPZQ8JyX9C TtRo1Xjrzvm6reSLMOB9fiNB8VSYs2nBGfYkkD8Y= From: Krzysztof Kozlowski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin , Michael Hennerich , Marek Vasut , Tomasz Duszynski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Cc: Andy Shevchenko , Krzysztof Kozlowski Subject: [PATCH v3 05/18] iio: adc: ltc2497: Simplify with dev_err_probe() Date: Sat, 29 Aug 2020 08:47:13 +0200 Message-Id: <20200829064726.26268-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200829064726.26268-1-krzk@kernel.org> References: <20200829064726.26268-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andy Shevchenko --- Changes since v2: 1. Wrap dev_err_probe() lines at 80 character Changes since v1: 1. Wrap dev_err_probe() lines at 100 character --- drivers/iio/adc/ltc2497-core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c index 9b8fd9c32364..2a485c8a1940 100644 --- a/drivers/iio/adc/ltc2497-core.c +++ b/drivers/iio/adc/ltc2497-core.c @@ -180,13 +180,9 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev) return ret; ddata->ref = devm_regulator_get(dev, "vref"); - if (IS_ERR(ddata->ref)) { - if (PTR_ERR(ddata->ref) != -EPROBE_DEFER) - dev_err(dev, "Failed to get vref regulator: %pe\n", - ddata->ref); - - return PTR_ERR(ddata->ref); - } + if (IS_ERR(ddata->ref)) + return dev_err_probe(dev, PTR_ERR(ddata->ref), + "Failed to get vref regulator\n"); ret = regulator_enable(ddata->ref); if (ret < 0) { -- 2.17.1