Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1708966pxa; Fri, 28 Aug 2020 23:52:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNAa0PQMstNhnUy5sB5QT5xUSKMy18s8sNJ98Lt3ytdZ/8GyVsdrD1wEOn3MC5z+EIIc78 X-Received: by 2002:a17:906:2408:: with SMTP id z8mr2247707eja.421.1598683948566; Fri, 28 Aug 2020 23:52:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598683948; cv=none; d=google.com; s=arc-20160816; b=Hw876Mk9PoV+KCnRKucTBCEFFGPovYofdbAbZ3yr/ZR/h5KHzkh9jLk3n9HWDn/wPU m5zOHYR2oUd/2PbOSiVsvrQqyE2+duc2eLKx+TSpsI3GZXkn6o3uN5pZ3Rp70kVLNheJ A/YZwTdoIW5eHWQ6BCSV/gkjdZt7OeJYhDonCZc9b/fboBJe0lHPmIDsRWlfRSQT3xm3 MXadZ7c1RixICl19heXm+t6eg+JYcbCOAw36y0KXw4UcnXVzhQwWicqnnK1BjCPfvBYB djaTVvS35ycORuCte0klFcUNXVzbCLYzPl8pAqAhRLrh9TLCPQici5+dlj/Y/Vk10Ja/ vyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=1lsPxW4SuYBrj2HxqZ37ykszkneU5KbNh6+yRUD05hw=; b=GHbq9LXn1mX+IkTqD5z5u3CmmB/f3xjaDf/SjAG1AJaGPPt7nnMAJ5BzKbJ1hi9hrD Qt30FcEP73LZRIgqlNgve3qG14803XlaauxieHzlD2l71MGFZI1AaL7cp2YgvMFe+Dvp J/gA5fyWj197mRAQ7jA8rZ1K4A3fTAfsQKf2Iw+w4KY8bnJoY9yf03GUrr5qZ+pwvK0T 2VDbXCw8DvMZlutlks65iiZX1pjXxDYDCsS3LsOFoYKXR6AdeVpuna9owelAEabWGHy5 1wRD0vtzx2DY9BYXN2/vw2pakkcN+hrIodVf0xEoXi6krtmpXO6NKZi1VL98zQpP6lMH xI9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2q5UJCJT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si936298edq.456.2020.08.28.23.52.06; Fri, 28 Aug 2020 23:52:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2q5UJCJT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbgH2GtI (ORCPT + 99 others); Sat, 29 Aug 2020 02:49:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:42904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbgH2GtF (ORCPT ); Sat, 29 Aug 2020 02:49:05 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D3B3820E65; Sat, 29 Aug 2020 06:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598683744; bh=4Lu3EJuJBkPkkhNm8cEkffiFcH6Q42bc9rp03XpBrfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2q5UJCJTz4MbOA8HJ/KI2YbH8ixBYNWTU5cscPWHOwBazmyqOMEXvAJA/TxjhKgCc dcJSIcEFEFv2wOtJLH1DrUOpfmGGfdCCzR7rTAP/4bqEVf4iq8xpZCegelD2iVSsM7 wejsuCcOP7LOR8iIyXVxYXrH/DNE/16YWdxioG8c= From: Krzysztof Kozlowski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin , Michael Hennerich , Marek Vasut , Tomasz Duszynski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Cc: Andy Shevchenko , Krzysztof Kozlowski Subject: [PATCH v3 18/18] iio: multiplexer: iio-mux: Simplify with dev_err_probe() Date: Sat, 29 Aug 2020 08:47:26 +0200 Message-Id: <20200829064726.26268-18-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200829064726.26268-1-krzk@kernel.org> References: <20200829064726.26268-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andy Shevchenko --- Changes since v2: 1. Wrap dev_err_probe() lines at 80 character --- drivers/iio/multiplexer/iio-mux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c index 6910218fdb00..d54ae5cbe51b 100644 --- a/drivers/iio/multiplexer/iio-mux.c +++ b/drivers/iio/multiplexer/iio-mux.c @@ -354,11 +354,9 @@ static int mux_probe(struct platform_device *pdev) return -ENODEV; parent = devm_iio_channel_get(dev, "parent"); - if (IS_ERR(parent)) { - if (PTR_ERR(parent) != -EPROBE_DEFER) - dev_err(dev, "failed to get parent channel\n"); - return PTR_ERR(parent); - } + if (IS_ERR(parent)) + return dev_err_probe(dev, PTR_ERR(parent), + "failed to get parent channel\n"); sizeof_ext_info = iio_get_channel_ext_info_count(parent); if (sizeof_ext_info) { -- 2.17.1