Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1709323pxa; Fri, 28 Aug 2020 23:53:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqAotoM9S1v00briZoVIFJVVs4uAbWkNdITJOk7hz1M9TnUfj34jsXO6q96ulpBh5bNbjw X-Received: by 2002:a17:906:f18d:: with SMTP id gs13mr2277891ejb.222.1598684005961; Fri, 28 Aug 2020 23:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598684005; cv=none; d=google.com; s=arc-20160816; b=CmudfLi/csQvA8ozPmE1Yv711C5aI7lqioT8fHgq2FG3n4qljThqCsNmnZG01BFfha YG8KES0+2bC4JyyII2iD2NYTUF+GogOw6OMjMqadISJk9pKj4Rf281h7aaX/HumHJbwC B2DUq7K1480rF8KiN5j3xiQrZpSLC1p6koyVsC8pMHRv5/9JNAq2RB69Jo57qebgjGzT 49tb41cnkyAEgYHDap6TZfkkRDFN7q765tO3e3y+dCubHsQK/6yLUjYGp5LHSsDHK0zL Z8vxZdeETxH1EmLTc+0t21i/Zl+VrmbgS7idmNc5SLwCu9///NeOLiag3ONAFNxd1Tby ar7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=zrcVy+Xl/RjqMbXuk4TZApkl2zuQECa4+s28ZF6NM4I=; b=ZdQLHpwX28rDoEDs1BsRW81IIiKgCfaPVBPRV3PXlNMAI372uzoJ0mKKGBSlD+dj0e 2YDME7PBLdD13iR9GsT3O0/hmVFTTuxz/XI4CVP2LVTcCwKHwjOBb4LJehXsT2EtWHqk P521a37ZZwuY8hL7tJqrq9kx2B8d1dmEAadJlOeYMWCXhogVekxB7In8vxblzyli9HEi 4L1A5AZ+P7muHRHFOuveRfR+JMZmeEAGFKGSs/prXvlD+VPvE3T+oBXMy7rHjJvYJoPp eabZI2G9I9NYE009biGmdOwuIxJLWrZO5Zxe/FKBxKJCkiqv9MPtikiSsqiToEoTzjc7 GYUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uSXg2zIx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si1311848ejb.68.2020.08.28.23.53.03; Fri, 28 Aug 2020 23:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uSXg2zIx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727968AbgH2Gt2 (ORCPT + 99 others); Sat, 29 Aug 2020 02:49:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:40664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbgH2GsQ (ORCPT ); Sat, 29 Aug 2020 02:48:16 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1023B2145D; Sat, 29 Aug 2020 06:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598683696; bh=6UjWOMAikeIKWUaBl4tPRLctxnQGbZpjLVEks3gNgKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uSXg2zIxy8JCQQMU9GNo8vzeCcIH9Cl8GLGs31FuNsQFSjWQ/WODKkPey/7NiX7YT FKYLIBOi8lPv8/6Cz5mu4QT5EikjWMxZRBTuJtOoWzwyrlzvpUVNn4TfUm7FQHDIeo yZ+kVAsZJLS5U6RHnRv+oYSPioypghIe05aqCujI= From: Krzysztof Kozlowski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin , Michael Hennerich , Marek Vasut , Tomasz Duszynski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Cc: Andy Shevchenko , Krzysztof Kozlowski Subject: [PATCH v3 04/18] iio: adc: exynos_adc: Simplify with dev_err_probe() Date: Sat, 29 Aug 2020 08:47:12 +0200 Message-Id: <20200829064726.26268-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200829064726.26268-1-krzk@kernel.org> References: <20200829064726.26268-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andy Shevchenko --- Changes since v2: 1. Wrap dev_err_probe() lines at 80 character Changes since v1: 1. Wrap dev_err_probe() lines at 100 character --- drivers/iio/adc/exynos_adc.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index 7d23b6c33284..20477b249f2a 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -844,13 +844,9 @@ static int exynos_adc_probe(struct platform_device *pdev) } info->vdd = devm_regulator_get(&pdev->dev, "vdd"); - if (IS_ERR(info->vdd)) { - if (PTR_ERR(info->vdd) != -EPROBE_DEFER) - dev_err(&pdev->dev, - "failed getting regulator, err = %ld\n", - PTR_ERR(info->vdd)); - return PTR_ERR(info->vdd); - } + if (IS_ERR(info->vdd)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->vdd), + "failed getting regulator"); ret = regulator_enable(info->vdd); if (ret) -- 2.17.1