Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1735167pxa; Sat, 29 Aug 2020 01:05:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzr1HGzBZeA+lMqd8vKbJG/eSRjH1rG9rp+X1RGW7bRWreCTQGvH2gsEM7hnR+8GqX4S28C X-Received: by 2002:a17:906:4d04:: with SMTP id r4mr2633828eju.450.1598688326871; Sat, 29 Aug 2020 01:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598688326; cv=none; d=google.com; s=arc-20160816; b=PPZ+5c6ztdiZPjrFymxgXp9JH6gvdHWAttIvGm3WRcKsyT9Pau2Vc4YnxUYcRHatTK YW+gIX1VFXRxvVne3CNbaZiod6FXlQtWbqB66g2aEuuvC+iXQqKtTjRG5b9XgXI9fQNV UwKvjNewcVf/lNxaZ5I9B8CkBJpQVzhnDhgS+Yy7jPpGcHN2DKtDF0EuSfOLsIcM5H7J N59F3dW/D1+7bk1iwO+OjepK+KmfhZRTwTBDA/FMbo2s1IBj77y6ew0HYK5L52dV/Kj6 VDWQuL4TapHI4ag8vNTNXzU/tz1Sn+uwqQ4qPaRR+9y+lgw5JEp8+68fCC1RUV2tvk12 hnnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=4suMcctfz6Bm64a3CG1Q4ZhgpBQhJ/zmSGep484vR+o=; b=JTX9XgGIb3Map1dxcOE+hRHlajToD99LsbF29er6K46wLo9a38C4NlyQnFO3zg3TcF 7ARUHEOZub8WFiPUr8xStApImkKqLuX63bOLiq3kntbTendGmhcwQRs8AVbCoXVBWsGY fx232lk5/Uf8OylNu8sr3VvnuD9oIzQ0Grarq98rXwWBNmvMh+kI3hH1tFm6IKyYlb1+ 5XiAkylpBWCGfnsyk4EzysVHgbroHkIVmZIOIiFIOk1N408CwmuDN/AqxqqUtLA/EkSd dhv6rCl34S+HlMd+L9ptBw0NBH/VlYshHeo9oOL+8rtBKW5entymGTrpp6iWY2Lvs77c gs1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pJ47QGaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lh7si1268772ejb.271.2020.08.29.01.04.51; Sat, 29 Aug 2020 01:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pJ47QGaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbgH2IDz (ORCPT + 99 others); Sat, 29 Aug 2020 04:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgH2IDy (ORCPT ); Sat, 29 Aug 2020 04:03:54 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 952EDC061236 for ; Sat, 29 Aug 2020 01:03:53 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id c15so1174150wrs.11 for ; Sat, 29 Aug 2020 01:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=4suMcctfz6Bm64a3CG1Q4ZhgpBQhJ/zmSGep484vR+o=; b=pJ47QGaYLlIR0FCfo0Miafdetuo7SIrjDhAYZe3baVWNIffFQ8eGsS/Yu85Y9w1l59 ptK9re46VkClF3RnLFwNZdVrIB0SG8HYrsnzhsYmiVCotUnnpEFbvqbLu1OP9GrS1Bz5 QgHrdyWB0ZTICHq3dCHYNcJaEW5sfHNBAL+GSXlbSHO+gvSRVx5Ei+XO8gzE1CUmPm44 yB/rybsaI0kyY8hR/uyrapT/ImAYCIr9lIilkC/dxbVsdchivhCidcgqnObWWX9LAGXw GILb4VK0BwXseLqmv6egjWZ45NwVtg6O/oJZrYHURW2LNWpbJ+U5JGZyUeiCpAFqJzOE C3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4suMcctfz6Bm64a3CG1Q4ZhgpBQhJ/zmSGep484vR+o=; b=GWrxuGPqSuYE7LArxRNHiVGwk3tZN0nrssAzUz9v1a/I1yEzsHygUwkY/0exIGsN5l fM2H/D1BM4uwUeiitUkmHx+HwwTRXrncPKiMYnrwLJC39LsGbgUaP2DO0dtsXUCX7Vox WECKjoZt0yU05bGR3TQWqAAXN7QEZUwsGBVCOhH9mxIhGKT6511rAza2Y+IQ1gKIqQWN /gBh6ZOVzxi+ijnd5h+efQl69/HkXwTbWN4JtY3APLXZdLU+Izs+U964mc5SuWmsyqcQ xhalPRkmmMBExFS6PoZUKLLOkkCEz1goVq5rfxGf8JtXXYZHml0+MTg2Hl4oXfuH6xwF LZtQ== X-Gm-Message-State: AOAM531ZVJY03g2OtbVZfdq2t1M3Vti5EQ8FFZflbHEPXr9FqYKVmzRq ARXuAeorNZ72Cw6Iz3ux3ByHwTVL0J0= X-Received: by 2002:adf:f10a:: with SMTP id r10mr2429157wro.86.1598688231122; Sat, 29 Aug 2020 01:03:51 -0700 (PDT) Received: from ogabbay-VM.habana-labs.com ([213.57.90.10]) by smtp.gmail.com with ESMTPSA id g15sm2632631wrx.66.2020.08.29.01.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2020 01:03:50 -0700 (PDT) From: Oded Gabbay To: linux-kernel@vger.kernel.org, SW_Drivers@habana.ai Cc: Moti Haimovski Subject: [PATCH 1/2] habanalabs: prevent user buff overflow Date: Sat, 29 Aug 2020 11:03:46 +0300 Message-Id: <20200829080347.26050-1-oded.gabbay@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Moti Haimovski This commit fixes a potential debugfs issue that may occur when reading the clock gating mask into the user buffer since the user buffer size was not taken into consideration. Signed-off-by: Moti Haimovski Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c index 37701e4f9d5a..aa77771635d3 100644 --- a/drivers/misc/habanalabs/common/debugfs.c +++ b/drivers/misc/habanalabs/common/debugfs.c @@ -982,7 +982,7 @@ static ssize_t hl_clk_gate_read(struct file *f, char __user *buf, return 0; sprintf(tmp_buf, "0x%llx\n", hdev->clock_gating_mask); - rc = simple_read_from_buffer(buf, strlen(tmp_buf) + 1, ppos, tmp_buf, + rc = simple_read_from_buffer(buf, count, ppos, tmp_buf, strlen(tmp_buf) + 1); return rc; -- 2.17.1