Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1736829pxa; Sat, 29 Aug 2020 01:09:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhQtQ8BtyvsK0ChO+qILdDcyEZWNTXyJAI8A8ocpB/CtfCwJgeZhIzo+duDGgYYJuOPzbQ X-Received: by 2002:a50:9f22:: with SMTP id b31mr1588547edf.345.1598688574688; Sat, 29 Aug 2020 01:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598688574; cv=none; d=google.com; s=arc-20160816; b=RnMazzxkVyIJdlGYkxJKR/dVWyGFI66jdPihbMwITBaEXj+MBsM04ETt6zk35L4eK3 ijp9wmlPD8bd59GalcttTSfs7YFoMh9CqrbbCDVeMWWezFfdIwDhXuRzVnIBF4C27IOW JlS1H3mmFtFJhiN5J66PK2FngExQSsziLBIO7Zp4Mqv0tuekVQ374n/SVZc72ySpAMXz E7/ApZLjzI9NGl79yAJfLC6LGWLCItLH2sLjPysXPsb0dx44N5pqjGJuDu+SvF9IJfBE UlqzZWlz/m+Uv27XibyNycwe4cSvSqdog/pCmUSBdupApnz1THS+Q/6Gh9jkWFJZ6VIU pZWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=3gCyYnwKppV46B5nToO4KA5BEvL0iRbo+wfijE/GVSg=; b=t2vGDpGgVXfOEvg5wV5CiUyqUAR3pkXblB315aJpfBSPWc+ocsNU/2pHeFGo6hpWBs Rxs5ccG2VXX5Pos3O4h7vmcUykEe0j5m6sYc0eHc7/hD55iHKa0K2Hnxy1LuNNbARe7/ 7uN13yL6L9ypjI/uqT3a0EHRxVEGkMLwfmfFEflSAtccNjgC6KL2486QnuZroyl9uEjo Lmjei/+xKDaiPHWI6XTncSxQMGFG43MrssMkqLmtz0MS/PPZVj2HKpT+a5By8Db8bx5B qmp034iOINGd1O0IK+ys1OtnvAaqS3MRSlsAcFtcMU4gRDYVVtmFCEsPOEs7EGVsZpkZ Tb4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e13si975672edc.33.2020.08.29.01.09.11; Sat, 29 Aug 2020 01:09:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbgH2IFf (ORCPT + 99 others); Sat, 29 Aug 2020 04:05:35 -0400 Received: from smtp.h3c.com ([60.191.123.50]:28059 "EHLO h3cspam02-ex.h3c.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbgH2IFc (ORCPT ); Sat, 29 Aug 2020 04:05:32 -0400 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([10.8.0.66]) by h3cspam02-ex.h3c.com with ESMTPS id 07T84e5w028045 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 29 Aug 2020 16:04:40 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from localhost.localdomain (10.99.212.201) by DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 29 Aug 2020 16:04:43 +0800 From: Xianting Tian To: , , , CC: , , Xianting Tian Subject: [PATCH] scsi: qla2xxx: Fix the return value Date: Sat, 29 Aug 2020 15:57:46 +0800 Message-ID: <20200829075746.19166-1-tian.xianting@h3c.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.99.212.201] X-ClientProxiedBy: BJSMTP01-EX.srv.huawei-3com.com (10.63.20.132) To DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) X-DNSRBL: X-MAIL: h3cspam02-ex.h3c.com 07T84e5w028045 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A negative error code should be returned. Signed-off-by: Xianting Tian --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index fbb80a043..612e001cc 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd) "multiple abort. %p transport_state %x, t_state %x, " "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state, cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags); - return EIO; + return -EIO; } cmd->aborted = 1; cmd->trc_flags |= TRC_ABORT; -- 2.17.1