Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1797135pxa; Sat, 29 Aug 2020 03:44:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn0mQa3bTJktzNkv1CaACnfDAjIRRTX75phCyT2QKfSvU0RwDRXdDp2qqWPfnRxwqUnauo X-Received: by 2002:a17:906:4f08:: with SMTP id t8mr3071183eju.164.1598697886736; Sat, 29 Aug 2020 03:44:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598697886; cv=none; d=google.com; s=arc-20160816; b=DWak8VIy40ZIVKJ+ZyuaJNnCKRI3uqAdLgnbQa1dQDdR9r81Qiwnv4afz5oVin1Wj2 nDTl+kpDBY0MpyvJN/d9M+aS8TRrzd6ROaDhyO8JZnAei3rKdzGLy5UXIe2wjW7qr+XW UU+496GpOPw/iHInbECO0Aoj3mBVHjfDXdsmz8qn1QxsYg22H4IJky9rtEj0/40HC16z PO1e4bfK04WURCzZPi4jVqxAdz1PPu9tgHTDr+CBXGRcyBZZ1aHZr3uy78os3Kw9dptB +D5kXRlBNm5U463IH2VvCH8c7rwCgjU9AcvwNZsRIWSXY6BkrrYZjCnG/kNKxi8GwJNP 2ejg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rDscDuyOWFwbtbjjAlUR20Y302z4oHLswsiZ5heGBJg=; b=edezisq/VRSi6HCeEvq9Ho28qnAkRhxhNQ4Auqwl1O+e59KRXaJojSAK7GF4EGi/oD 6yQEYuVmJe+5GIPHvJV+PjXlh9s62aesPr0bpkuZzexVv8w3y2jnX6i4OkpT83qndRF0 21Pd7OIEELzfgYYLsKRHTr+/S1qiqntHgzBjH/bcfO97KWwGixJ3m/i3GqJp7yYrqidn RKxcErPebQwHU3xqnGi5f0i5he2Lv7OQ/S/DFKlPIuYAha3U/JSfeR+MPbVkwPxoLCsK 98LFd/xAjje9FmH3KFMMhlm2/3ohg2aIL+5ZFeH3qQNbyO3RCiX1cc0s/oXZc5mGJl/B 1RyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=Bb+YFGXE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g26si1195992edr.126.2020.08.29.03.44.23; Sat, 29 Aug 2020 03:44:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=Bb+YFGXE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727783AbgH2Knp (ORCPT + 99 others); Sat, 29 Aug 2020 06:43:45 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:1453 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbgH2Kno (ORCPT ); Sat, 29 Aug 2020 06:43:44 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4BdtNt4GLxz18; Sat, 29 Aug 2020 12:43:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1598697822; bh=fGConhRjkD/M4qym9EGNNIyAY17CNESN0/THcr9p2aU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bb+YFGXEs9oiPnrzOBfO949QntwH5VfoT7O5zmecy1SzOTtsdVf1P4r1jO6KW0MBi 8EAjY46G7w9g2IDC43othJPebfc3jj9sqN0usmVhJIoNSdoAgViF5CR3YOtKt6IxQh Ey6Sfoof4CjdQWK0aDraTFdLpYGBl3x7wA5nt0T87fnFOxQwG9w+jVuP53gucZAqly myxSNBestBtMDLLuGDKnpdsbcglpVG5AEklhrVTedYlxw8RSVrhtUiNTzsWwq3QM+z gTt+i0cdvSjVwdeqctrr2VDS3s620uD/3n33C9oCqqc+XBopEheGQEr/1ThMJzadQF r7a3FDxEjM62g== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at mail Date: Sat, 29 Aug 2020 12:43:38 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Tom Rix Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrzej Hajda , Andy Shevchenko , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver code: print symbolic error code Message-ID: <20200829104337.GA11179@qmqm.qmqm.pl> References: <434ca0ab-1c9b-5c4f-c844-5e792725f9ab@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <434ca0ab-1c9b-5c4f-c844-5e792725f9ab@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 28, 2020 at 11:22:25AM -0700, Tom Rix wrote: > > On 8/28/20 9:14 AM, Micha? Miros?aw wrote: > > dev_err_probe() prepends the message with an error code. Let's make it > > more readable by translating the code to a more recognisable symbol. > recognizable > > > > Fixes: a787e5400a1c ("driver core: add device probe log helper") > is this change really to fix a bug? [...] Yes, but this depends on how you define a bug. :-) Best Regards, Micha? Miros?aw